fix(release): do not mark prereleases as the latest release - #321
Merged
Conversation
Every tag published with make_latest: true unconditionally, so v0.1.6-rc.1 through rc.5 each claimed the repository's latest release in turn. An RC is currently presented as the latest release, which is wrong for anyone reading the releases page or resolving 'latest' programmatically, and it would remain wrong in ordering terms even after v0.1.6 is cut. Derives both flags from the tag: a hyphen means prerelease (v1.2.3-rc.1), its absence means a real release (v1.2.3). Matches the semver convention the existing docker/metadata-action tags already rely on.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
blue4209211
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.ymlsetsmake_latest: truefor every tag, so each ofv0.1.6-rc.1…rc.5claimed the repository's latest release in turn. An RC is currently shown as the latest release.That is wrong for anyone reading the releases page or resolving "latest" programmatically, and the ordering stays wrong even after
v0.1.6is cut.Fix
Derive both flags from the tag shape:
v1.2.3is a release;v1.2.3-rc.1is a prerelease. This matches the semver conventiondocker/metadata-actionalready relies on in the same job — it skips the mutable{{major}}.{{minor}}and{{major}}tags for prereleases, which is why the RCs correctly never moved0.1/0/lateston the image side. This brings the GitHub release side in line with that.Why now
v0.1.6is ready to cut after ~20h of soak on dev. Cutting it while an RC holds "latest" would leave the releases page misleading, so this should land first.YAML validated. No behaviour change for real releases.