Skip to content

fix(release): publish prereleases from a draft so assets upload #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayankpande88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): publish prereleases from a draft so assets upload #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,26 @@ jobs:
# v1.2.3-rc.1 is not.
prerelease: ${{ contains(github.ref_name, '-') }}
make_latest: ${{ !contains(github.ref_name, '-') }}
# Immutable releases reject asset uploads after publication, and a
# prerelease is published the moment it is created — so uploading the
# binaries failed outright on v0.1.7-rc.1:
#
# Cannot upload asset nudgebee-node-agent-0.1.7-rc.1-arm64 to an
# immutable release.
#
# Creating prereleases as a draft keeps them writable long enough for
# the upload; the next step publishes. Full releases are unaffected
# and stay non-draft, which is why this only ever broke RCs.
draft: ${{ contains(github.ref_name, '-') }}
files: |
/tmp/nudgebee-node-agent-${{ steps.meta.outputs.version }}-amd64
/tmp/nudgebee-node-agent-${{ steps.meta.outputs.version }}-arm64

# Publishing from the draft is what makes the assets stick. Downstream
# consumers should watch release.published, which fires here for both
# prereleases and full releases.
- name: Publish prerelease draft
if: github.event_name == 'push' && contains(github.ref_name, '-')
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release edit "${{ github.ref_name }}" --draft=false --repo "${{ github.repository }}"
Loading