docs(agent): scannerAutoCopyPullSecrets now defaults to on - #847
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Helm values documentation to reflect that runner.scannerAutoCopyPullSecrets now defaults to true and clarifies its behavior under readOnly mode. The reviewer noted a contradiction in the updated description, which refers to both the "scanner namespace" and "release namespace," and suggested a cleaner phrasing to avoid user confusion.
The chart flipped the default (nudgebee/k8s-agent#603): an image scan copies the scanned pod's registry credentials for the life of the scan Job, because the node-local image copy it used to rely on is usually gone by scan time. Also corrects the read-only note. readOnly no longer fails the install when combined with auto-copy -- with the new default that would break every read-only install -- it turns auto-copy off instead.
mayankpande88
force-pushed
the
docs/agent-pull-secret-default
branch
from
September 8, 2026 08:55
dfcf70f to
03e9b1b
Compare
RamanKharchee
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent chart changed a default and the Helm values reference no longer matched it. Image scans now copy the scanned pod's registry credentials by default, so private images can be scanned even when the node no longer has a copy of the image (nudgebee/k8s-agent#603). The row also explains what the copies are, where they live, and when they go away, so a reader deciding whether to turn it off has the facts.
Read-only mode used to be documented as incompatible — the install failed if you set both. It no longer fails; read-only turns auto-copy off instead. Corrected in both places it was stated.
Type of change
Checklist
npm run build— not run; single-table text edit in an existing page, no new pages, links, or MDX constructs