Skip to content

fix(release-publish-oci): discard release lookup capture on HTTP error #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebasnallar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release-publish-oci): discard release lookup capture on HTTP error #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/release-publish-oci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,13 @@ jobs:

# Direct lookup first; drafts are not resolvable via releases/tags,
# so fall back to listing (upsert also covers backfilled tags that
# never had a release).
RELEASE_ID=$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$TAG" --jq '.id' 2>/dev/null || true)
# never had a release). On an HTTP error gh api prints the error
# BODY to stdout — the capture must be discarded on a non-zero
# exit, or a 404's JSON gets used as a release id and the next
# request is garbage.
if ! RELEASE_ID=$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$TAG" --jq '.id'); then
RELEASE_ID=""
fi
if [ -z "$RELEASE_ID" ]; then
RELEASE_ID=$(gh api "repos/$GITHUB_REPOSITORY/releases" --paginate \
--jq "[.[] | select(.tag_name==\"$TAG\")][0].id // empty")
Expand Down