Skip to content

fix(assume-role): resolve the IAM provider by category instead of specification slug #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agustincelentano wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Open

fix(assume-role): resolve the IAM provider by category instead of specification slug #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a34e8a
fix(assume-role): resolve the IAM provider by category instead of spe…
agustincelentano Sep 4, 2026
25768e7
fix(requirements): allow iam:ListInstanceProfilesForRole so delete-sc…
agustincelentano Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lambda/scope/tests/scripts/assume_role_lib.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ JSON='{"attributes":{"iam_role_arns":{"arns":[{"selector":"s3","arn":"arn:aws:ia
@test "resolve_assume_role_arn: IAM provider when no env override" {
np() {
case "$*" in
*"--specification_slug aws-iam-configuration"*) echo '{"results":[{"id":"iam-1"}]}' ;;
*"--categories identity-access-control"*) echo '{"results":[{"id":"iam-1"}]}' ;;
*"provider read"*) echo '{"attributes":{"iam_role_arns":{"arns":[{"selector":"lambda","arn":"arn:provider:lambda"}]}}}' ;;
*) echo '{}' ;;
esac
Expand All @@ -143,7 +143,7 @@ JSON='{"attributes":{"iam_role_arns":{"arns":[{"selector":"s3","arn":"arn:aws:ia
@test "resolve_assume_role_arn: scope-config fallback when provider misses" {
np() {
case "$*" in
*"--specification_slug aws-iam-configuration"*) echo '{"results":[]}' ;;
*"--categories identity-access-control"*) echo '{"results":[]}' ;;
*"--categories scope-configurations"*) echo '{"results":[{"attributes":{"assume_role":{"arn":"arn:scopecfg:legacy"}}}]}' ;;
*) echo '{}' ;;
esac
Expand Down
1 change: 1 addition & 0 deletions lambda/specs/requirements/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ resource "aws_iam_policy" "nullplatform_lambda_iam_policy" {
"iam:CreateRole",
"iam:GetRole",
"iam:DeleteRole",
"iam:ListInstanceProfilesForRole",
"iam:PutRolePolicy",
"iam:GetRolePolicy",
"iam:DeleteRolePolicy",
Expand Down
6 changes: 4 additions & 2 deletions lambda/utils/assume_role_lib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ provider_arn_for_selector() {
[ -n "$selector" ] || return 0

local pid data
# Filter by category: the API ignores --specification_slug and returns every
# provider under the nrn, so "first" would pick an unrelated one.
pid=$(np provider list --nrn "$nrn" \
--specification_slug aws-iam-configuration \
--format json --limit 100 2>/dev/null \
--categories identity-access-control \
--format json 2>/dev/null \
| jq -r '[ (.results // [])[] ] | first | .id // ""' 2>/dev/null)
[ -n "$pid" ] && [ "$pid" != "null" ] || return 0

Expand Down