Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Fix: a rollback now diagnoses the failed deployment before deleting it. The hints step ran after the deletion, so it never found the pods it inspects and every rollback ended with the same generic "Application Startup Issue Detected" text, even when nothing had failed to start. Rollbacks now surface the actual reason (image pull error, crash loop, OOM, failed health check) when there is one.

## [1.14.0] - 2026-08-03
- k8s scope deployments now report launched and healthy instance counts, so the deployment page shows live "X/Y launched" and "X/Y healthy" progress
Expand Down
11 changes: 8 additions & 3 deletions k8s/deployment/workflows/rollback.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ steps:
- name: SERVICE_TEMPLATE_PATH
type: file
file: "$OUTPUT_DIR/service-$SCOPE_ID-$DEPLOYMENT_ID.yaml"
# Diagnose BEFORE deleting: the hints read the failed deployment's pods
# (kubectl get pods -l deployment_id=$DEPLOYMENT_ID). Running this after the
# delete step below always found nothing, so every rollback fell through to
# the generic "Application Startup Issue Detected" text regardless of why the
# rollback happened — or whether anything had failed at all.
- name: print_deployment_error_hints
type: script
file: "$SERVICE_PATH/deployment/print_failed_deployment_hints"
- name: delete deployment
type: script
file: "$SERVICE_PATH/apply_templates"
Expand All @@ -90,6 +98,3 @@ steps:
file: "$SERVICE_PATH/deployment/delete_cluster_objects"
configuration:
DEPLOYMENT: green
- name: print_deployment_error_hints
type: script
file: "$SERVICE_PATH/deployment/print_failed_deployment_hints"
Loading