fix(k8s/instance): honor the request limit instead of always capping at 10 - #236
Merged
Conversation
…at 10 The instance list sliced the pods to LIMIT with a hard default of 10 that nothing in the chain could override, so scopes with more pods showed only the first 10 in the dashboard. A `limit` in the request now wins, the LIMIT env var stays as the operator override, and with neither every pod is returned.
francocirulli95
force-pushed
the
fix/k8s-instance-list-limit
branch
from
September 2, 2026 19:56
d4576a9 to
e9edcc9
Compare
Closed
francocirulli95
marked this pull request as ready for review
September 2, 2026 20:40
fedemaleh
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops the k8s instance list from always returning the first 10 pods.
instance/build_contexthadLIMIT=${LIMIT:-10}andinstance/listsliced to it. Nothing in the chain setLIMIT, so a scope with 20 pods showed 10 in the performance view, with no next page.limitin the request now wins, theLIMITenv var stays as the operator override, and with neither every pod is returned.k8s/instance/testscover the resolution order and the slice.bats k8s/instance/testspasses.limitto the agent.