fix: delete workflow shouldn't require bucket_name_suffix - #22
Merged
Merged
Conversation
The bucket_name_suffix check in build_context ran unconditionally, before the fallback that reuses the existing bucket_name from service attributes. This made delete fail requiring a field that's only needed to compute a new bucket name on create.
sebastiancorrea81
deleted the
fix/s3-delete-requires-bucket-name-suffix
branch
September 3, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete.yamlandcreate.yamlshare thebuild_contextstep, which requiredbucket_name_suffixunconditionally before deciding whether it was actually needed.bucket_namefrom service attributes, so it never needsbucket_name_suffix— but the old check ran first and could fail the delete for no reason.bucket_name(i.e. only when there's no existingbucket_nameto reuse).Test plan
bash -n aws-s3-bucket/scripts/aws/build_context(syntax check, passed locally)bucket_name_suffixbucket_name_suffixis missing