Skip to content

fix: delete workflow shouldn't require bucket_name_suffix - #22

Merged
sebastiancorrea81 merged 1 commit into
mainfrom
fix/s3-delete-requires-bucket-name-suffix
Sep 3, 2026
Merged

fix: delete workflow shouldn't require bucket_name_suffix#22
sebastiancorrea81 merged 1 commit into
mainfrom
fix/s3-delete-requires-bucket-name-suffix

Conversation

@sebastiancorrea81

Copy link
Copy Markdown
Contributor

Summary

  • delete.yaml and create.yaml share the build_context step, which required bucket_name_suffix unconditionally before deciding whether it was actually needed.
  • On delete, the script already reuses the previously computed bucket_name from service attributes, so it never needs bucket_name_suffix — but the old check ran first and could fail the delete for no reason.
  • Moved the required check inside the branch that actually computes a new bucket_name (i.e. only when there's no existing bucket_name to reuse).

Test plan

  • bash -n aws-s3-bucket/scripts/aws/build_context (syntax check, passed locally)
  • Create an S3 bucket service instance, then delete it, and confirm delete no longer fails on bucket_name_suffix
  • Confirm create still fails with a clear error when bucket_name_suffix is missing

The bucket_name_suffix check in build_context ran unconditionally,
before the fallback that reuses the existing bucket_name from service
attributes. This made delete fail requiring a field that's only
needed to compute a new bucket name on create.
@sebastiancorrea81
sebastiancorrea81 merged commit 467321b into main Sep 3, 2026
6 checks passed
@sebastiancorrea81
sebastiancorrea81 deleted the fix/s3-delete-requires-bucket-name-suffix branch September 3, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant