i18n(plateau): core.ja.json の孤立キーを削除する - #42
Merged
Conversation
current_tags, cancel and covered_note belonged to the floating tag-transfer panel that the editor-section migration replaced. They were removed from the English source (core.yaml) in 5457f49, but the Japanese translations are maintained by hand in core.ja.json, so they survived there. Nothing references them. This only trims the file; with them gone the ja and en key sets for height_transfer match again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
フローティングパネル撤去時の残骸として
core.ja.jsonに残っていた 3 キーを削除します。current_tagscancelcovered_noteパネルをエンティティエディタのセクションに作り直した際、英語ソースの
core.yamlからは 5457f49 で削除済みでした。日本語訳はcore.ja.jsonを直接管理しているため、そちらだけ残っていました。コード全体を検索しても参照はありません。削除後、
height_transferのキー集合が ja と en で一致します。テスト 727 件グリーン。