AWS identity store - #161
Open
michelemin wants to merge 1 commit into
Open
Conversation
michelemin
force-pushed
the
aws_identity_store
branch
from
June 13, 2025 12:52
c9ecf54 to
bc11436
Compare
michelemin
force-pushed
the
aws_identity_store
branch
from
July 4, 2026 15:40
bc11436 to
1a2c646
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new AWS wrapper module intended to call AWS Identity Store operations (create/delete user, add/remove user to/from group), along with dependency and error plumbing needed under the existing aws feature gate.
Changes:
- Adds
aws-sdk-identitystoreas an optional dependency under theawsfeature. - Introduces a new AWS module (
apis/aws/iam.rs) implementing Identity Store user/group membership operations. - Extends
ApiErrorwith anIamError(String)variant (behindawsfeature).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/plaid/src/apis/mod.rs | Adds an AWS-gated IamError(String) variant to ApiError. |
| runtime/plaid/src/apis/aws/mod.rs | Exposes the new iam module from the AWS API namespace. |
| runtime/plaid/src/apis/aws/iam.rs | New Identity Store client wrapper with create/delete user and group membership operations. |
| runtime/plaid/Cargo.toml | Adds aws-sdk-identitystore as an optional dependency under the aws feature. |
| runtime/Cargo.lock | Locks new transitive dependencies for aws-sdk-identitystore, including additional Smithy crate versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michelemin
force-pushed
the
aws_identity_store
branch
from
July 4, 2026 17:05
1a2c646 to
7fc84a6
Compare
michelemin
marked this pull request as ready for review
July 4, 2026 17:05
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
runtime/plaid/Cargo.toml:31
aws-sdk-identitystore = 1.73.0pulls in olderaws-smithy-http/jsonversions than the otheraws-sdk-*crates (see Cargo.lock now containing both 0.62.x and 0.63.x), which increases compile time/binary size and can complicate dependency resolution. Consider bumpingaws-sdk-identitystoreto a version aligned with the other AWS SDK crates in this workspace so Smithy dependencies converge.
async-trait = "0.1.56"
aws-config = "1.8.16"
aws-sdk-dynamodb = { version = "1.111.0", optional = true }
aws-sdk-identitystore = { version = "1.73.0", optional = true }
aws-sdk-kms = { version = "1.106.0", optional = true }
aws-sdk-s3 = { version = "1.132.0", optional = true, default-features = false }
aws-sdk-secretsmanager = "1.104.0"
aws-sdk-sqs = { version = "1.98.0", optional = true }
michelemin
force-pushed
the
aws_identity_store
branch
from
July 4, 2026 17:08
7fc84a6 to
c988f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add APIs for AWS Identity Store to