Skip to content

AWS identity store - #161

Open
michelemin wants to merge 1 commit into
mainfrom
aws_identity_store
Open

AWS identity store#161
michelemin wants to merge 1 commit into
mainfrom
aws_identity_store

Conversation

@michelemin

@michelemin michelemin commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Add APIs for AWS Identity Store to

  • Create a user
  • Delete a user
  • Add a user to a group
  • Remove a user from a group

@michelemin
michelemin changed the base branch from main to shadow June 13, 2025 12:50
@michelemin
michelemin force-pushed the aws_identity_store branch from c9ecf54 to bc11436 Compare June 13, 2025 12:52
Base automatically changed from shadow to main July 10, 2025 07:32
@michelemin
michelemin force-pushed the aws_identity_store branch from bc11436 to 1a2c646 Compare July 4, 2026 15:40
Copilot AI review requested due to automatic review settings July 4, 2026 15:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new AWS wrapper module intended to call AWS Identity Store operations (create/delete user, add/remove user to/from group), along with dependency and error plumbing needed under the existing aws feature gate.

Changes:

  • Adds aws-sdk-identitystore as an optional dependency under the aws feature.
  • Introduces a new AWS module (apis/aws/iam.rs) implementing Identity Store user/group membership operations.
  • Extends ApiError with an IamError(String) variant (behind aws feature).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
runtime/plaid/src/apis/mod.rs Adds an AWS-gated IamError(String) variant to ApiError.
runtime/plaid/src/apis/aws/mod.rs Exposes the new iam module from the AWS API namespace.
runtime/plaid/src/apis/aws/iam.rs New Identity Store client wrapper with create/delete user and group membership operations.
runtime/plaid/Cargo.toml Adds aws-sdk-identitystore as an optional dependency under the aws feature.
runtime/Cargo.lock Locks new transitive dependencies for aws-sdk-identitystore, including additional Smithy crate versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runtime/plaid/src/apis/aws/mod.rs
Comment thread runtime/plaid/src/apis/aws/iam.rs Outdated
Comment thread runtime/plaid/src/apis/aws/iam.rs Outdated
Comment thread runtime/plaid/src/apis/aws/iam.rs Outdated
Comment thread runtime/plaid/Cargo.toml
@michelemin
michelemin force-pushed the aws_identity_store branch from 1a2c646 to 7fc84a6 Compare July 4, 2026 17:05
@michelemin
michelemin marked this pull request as ready for review July 4, 2026 17:05
Copilot AI review requested due to automatic review settings July 4, 2026 17:05
@michelemin michelemin added enhancement New feature or request API Relating to the API subsystems AI Prompted The code was primarily generated via prompts. Using AI code complete, does not count. labels Jul 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

runtime/plaid/Cargo.toml:31

  • aws-sdk-identitystore = 1.73.0 pulls in older aws-smithy-http/json versions than the other aws-sdk-* crates (see Cargo.lock now containing both 0.62.x and 0.63.x), which increases compile time/binary size and can complicate dependency resolution. Consider bumping aws-sdk-identitystore to a version aligned with the other AWS SDK crates in this workspace so Smithy dependencies converge.
async-trait = "0.1.56"
aws-config = "1.8.16"
aws-sdk-dynamodb = { version = "1.111.0", optional = true }
aws-sdk-identitystore = { version = "1.73.0", optional = true }
aws-sdk-kms = { version = "1.106.0", optional = true }
aws-sdk-s3 = { version = "1.132.0", optional = true, default-features = false }
aws-sdk-secretsmanager = "1.104.0"
aws-sdk-sqs = { version = "1.98.0", optional = true }

Comment thread runtime/plaid/src/apis/aws/identity_store.rs
@michelemin
michelemin force-pushed the aws_identity_store branch from 7fc84a6 to c988f27 Compare July 4, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Prompted The code was primarily generated via prompts. Using AI code complete, does not count. API Relating to the API subsystems enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants