docs(views): cite the view that defines the board, not the deleted tabs key - #1337
Merged
Merged
Conversation
…bs key `docs/feature-inventory.md`'s OPP-009 row was wrong on both halves. The source citation `src/views/opportunity.view.ts`(`list.tabs`) dangled — PR #1316 deleted that key from every view file — and now points at `listViews.pipeline_kanban`, where the board is defined. The entry-point sentence named the inert `tabs[].name` "pipeline"; the console labels that tab with the target view's own `label`, so it now names what the switcher really prints, "Sales Pipeline". `src/views/event_attendee.view.ts`'s header had decayed rather than gone false. "It carries no `tabs` and no navigation entry" was offered as a distinguishing property of this junction bundle, but no view file carries `tabs` any more, so the clause was trivially true of all 14. The dead clause is dropped; the live half is kept verbatim. Prose only. No metadata changed. The token ratchet is comment-stripped, so its numbers are unmoved. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ED4cusQ7pxZ7d7TCLKrZb
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
os-trump
marked this pull request as ready for review
August 26, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1319
Two residuals PR #1316 left behind, unrelated except in cause. One was wrong;
the other had merely gone empty — and that difference is what drove two
different fixes rather than one.
①
docs/feature-inventory.md:96— wrong on both halvesThe source citation
src/views/opportunity.view.ts(list.tabs) dangled:#1316 deleted that key from every view file, so the row pointed at a key that no
longer exists anywhere. It now cites
listViews.pipeline_kanban, where the boardis actually defined (
src/views/opportunity.view.ts:136).The entry-point description named 「
pipeline标签页」, which was the inerttabs[].name— the console labels that tab with the target view's ownlabel,so a reader looking for a tab called pipeline would not find one. Re-derived
from source rather than from the card:
pipeline_kanbancarrieslabel: 'Sales Pipeline'(src/views/opportunity.view.ts:139), so the row nownames Sales Pipeline. This is the internal-page counterpart to the same class
of error #1318 / #1324 corrected on the published corpus.
OPP-009's other columns are untouched, as are all other rows.
②
src/views/event_attendee.view.ts:9— not false, decayedThe clause was offered as something that distinguishes this junction bundle.
After #1316 no view file carries
tabs, so "carries notabs" was trivially trueof all 14 and distinguished nothing. The dead clause is dropped and the live half
kept verbatim — it is still true and still load-bearing. The paragraph is not
rewritten and the sentence is not deleted.
Before:
After:
Word-for-word identical minus
no+ backtick-tabs-backtick +and; the threelines are re-wrapped only to keep the block's existing width.
Acceptance
The card's criterion is mechanical, and the zero is paired with control terms
proving the search reached all three trees (a bare zero has been worth nothing on
this lane before):
⇒
list.tabsgoes 1 → 0 repo-wide, while the same command shape in the samepaths still returns hits for all three control terms. For ② there is no count;
the before/after text is quoted above.
Gates —
pnpm verifygreen on this commitRun under the shared verify lock at
3b6f980, the tree of this PR's only commit(
git status --porcelainempty andgit diff HEADempty immediately after thecommit, so the verified tree and the committed tree are the same tree). Quoting
each gate's own verdict line:
Token ratchet, checked deliberately because
event_attendee.view.tssits inthe measured interaction layer: the numbers are byte-identical to base
d456ea3— interaction layer33 files / 4,600 lines / 149,724 chars / ~37,431 tokenson both trees, ceiling ~40,000. The ratchet is comment-stripped bydocumented design, so a comment edit cannot move it. No re-anchor was needed and
nothing here overlaps #1317.
Changeset
Empty-frontmatter, the sanctioned "releases nothing" declaration documented in
.github/workflows/changeset-check.yml. Prose only: the onesrc/edit is acomment, and no object, field, view, label, page or hook changed.
Scope
content/docs/**was not touched or inspected — that ground was #1318 / #1324,both already landed. No
src/views/*.view.tswas touched beyond the singlecomment line in
event_attendee.view.ts, andcontent/docs/releases/**was nottouched.
Generated by Claude Code