Skip to content

docs(views): cite the view that defines the board, not the deleted tabs key - #1337

Merged
os-trump merged 1 commit into
mainfrom
claude/issue-1319-dangling-tabs-references
Aug 26, 2026
Merged

docs(views): cite the view that defines the board, not the deleted tabs key#1337
os-trump merged 1 commit into
mainfrom
claude/issue-1319-dangling-tabs-references

Conversation

@os-trump

Copy link
Copy Markdown
Collaborator

Fixes #1319

Two residuals PR #1316 left behind, unrelated except in cause. One was wrong;
the other had merely gone empty — and that difference is what drove two
different fixes rather than one.

docs/feature-inventory.md:96 — wrong on both halves

The source citation src/views/opportunity.view.ts(list.tabs) dangled:
#1316 deleted that key from every view file, so the row pointed at a key that no
longer exists anywhere. It now cites listViews.pipeline_kanban, where the board
is actually defined (src/views/opportunity.view.ts:136).

The entry-point description named 「pipeline 标签页」, which was the inert
tabs[].name — the console labels that tab with the target view's own label,
so a reader looking for a tab called pipeline would not find one. Re-derived
from source rather than from the card: pipeline_kanban carries
label: 'Sales Pipeline' (src/views/opportunity.view.ts:139), so the row now
names Sales Pipeline. This is the internal-page counterpart to the same class
of error #1318 / #1324 corrected on the published corpus.

OPP-009's other columns are untouched, as are all other rows.

src/views/event_attendee.view.ts:9 — not false, decayed

The clause was offered as something that distinguishes this junction bundle.
After #1316 no view file carries tabs, so "carries no tabs" was trivially true
of all 14 and distinguished nothing. The dead clause is dropped and the live half
kept verbatim — it is still true and still load-bearing. The paragraph is not
rewritten and the sentence is not deleted.

Before:

crm_event_attendee is no exception. It carries no tabs and no navigation
entry: an attendee is never something you go looking for on its own, you
reach it through the meeting.

After:

crm_event_attendee is no exception. It carries no navigation entry: an
attendee is never something you go looking for on its own, you reach it
through the meeting.

Word-for-word identical minus no + backtick-tabs-backtick + and; the three
lines are re-wrapped only to keep the block's existing width.

Acceptance

The card's criterion is mechanical, and the zero is paired with control terms
proving the search reached all three trees (a bare zero has been worth nothing on
this lane before):

$ git grep -n "list\.tabs" -- docs src content      # before: 1 hit (this row)
$ git grep -n "list\.tabs" -- docs src content      # after:  no output, exit 1
$ git grep -c "OPP-009"          -- docs src content
docs/feature-inventory.md:1
$ git grep -c "pipeline_kanban"  -- docs src content
content/docs/sales/index.mdx:1 … docs/feature-inventory.md:1 src/apps/crm.app.ts:1 src/views/opportunity.view.ts:2
$ git grep -c "crm_event_attendee" -- docs src content
content/docs/sales/meetings-and-calls.mdx:1 … docs/feature-inventory.md:1 src/views/event_attendee.view.ts:4

list.tabs goes 1 → 0 repo-wide, while the same command shape in the same
paths still returns hits for all three control terms. For ② there is no count;
the before/after text is quoted above.

Gates — pnpm verify green on this commit

Run under the shared verify lock at 3b6f980, the tree of this PR's only commit
(git status --porcelain empty and git diff HEAD empty immediately after the
commit, so the verified tree and the committed tree are the same tree). Quoting
each gate's own verdict line:

✓ Validation passed (1322ms)                     # validate
                                                 # typecheck (tsc --noEmit, silent)
✓ i18n lint gate: 0 `i18n/missing-*` issues      # lint + lint:i18n-gate
✓ source hygiene clean                           # hygiene
✓ source token ratchet clean                     # hygiene:tokens
✓ Build complete (1749ms)                        # build
  Test Files  142 passed (142)                   # test
       Tests  2997 passed | 1 skipped (2998)
os-verify-lock: VERDICT command-exit 0 · held the lock 222s (3m42s)

Token ratchet, checked deliberately because event_attendee.view.ts sits in
the measured interaction layer: the numbers are byte-identical to base
d456ea3 — interaction layer 33 files / 4,600 lines / 149,724 chars / ~37,431 tokens on both trees, ceiling ~40,000. The ratchet is comment-stripped by
documented design, so a comment edit cannot move it. No re-anchor was needed and
nothing here overlaps #1317.

Changeset

Empty-frontmatter, the sanctioned "releases nothing" declaration documented in
.github/workflows/changeset-check.yml. Prose only: the one src/ edit is a
comment, and no object, field, view, label, page or hook changed.

Scope

content/docs/** was not touched or inspected — that ground was #1318 / #1324,
both already landed. No src/views/*.view.ts was touched beyond the single
comment line in event_attendee.view.ts, and content/docs/releases/** was not
touched.


Generated by Claude Code

…bs key

`docs/feature-inventory.md`'s OPP-009 row was wrong on both halves. The source
citation `src/views/opportunity.view.ts`(`list.tabs`) dangled — PR #1316 deleted
that key from every view file — and now points at `listViews.pipeline_kanban`,
where the board is defined. The entry-point sentence named the inert
`tabs[].name` "pipeline"; the console labels that tab with the target view's own
`label`, so it now names what the switcher really prints, "Sales Pipeline".

`src/views/event_attendee.view.ts`'s header had decayed rather than gone false.
"It carries no `tabs` and no navigation entry" was offered as a distinguishing
property of this junction bundle, but no view file carries `tabs` any more, so
the clause was trivially true of all 14. The dead clause is dropped; the live
half is kept verbatim.

Prose only. No metadata changed. The token ratchet is comment-stripped, so its
numbers are unmoved.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ED4cusQ7pxZ7d7TCLKrZb
@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hotcrm Ignored Ignored Aug 26, 2026 9:21am

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation metadata Declarative metadata — schema, security posture, UI surfaces labels Aug 26, 2026
@os-trump
os-trump marked this pull request as ready for review August 26, 2026 09:26
@os-trump
os-trump added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 08613ad Aug 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation metadata Declarative metadata — schema, security posture, UI surfaces

Projects

None yet

2 participants