docs(operate): correct audit-logs missing-notification diagnostic - #230
Merged
Merged
Conversation
The subscription->recipient expansion is not wired (AudienceSpec has no 'subscribers' member, EmitInput.audience is required, and no RecipientResolver branch reads sys_notification_subscription), so a subscription row cannot filter a delivery out. Only the preference filter (PreferenceResolver.filter() in emit()) is real. Drop "a subscription or" and name the two real causes: the audience did not resolve to the user, or their preference muted the topic on that channel. Fixes #146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
What
content/docs/operate/audit-logs.mdx:102told admins that a missing inboxmessage "usually means a subscription or preference filtered the event out."
The subscription half is false — the subscription-to-recipient expansion is
not wired, so a
sys_notification_subscriptionrow cannot filter a delivery.This drops "a subscription or" and names the two real causes: the audience
did not resolve to that user, or their preference muted the topic on that
channel. The preference half was already true and is unchanged in substance.
Basis (re-verified at dispatch,
objectstackorigin/main@e452ad5, up from the2866d5f97ethe card was filed against)AudienceSpec(packages/services/service-messaging/src/messaging-service.ts)is
string | { ownerOf: {...} }— no'subscribers'member;EmitInput.audienceis required.RecipientResolver.resolveOne()(recipient-resolver.ts) branches onuser:/role:/team:/owner_of:/ email / bare id — no branchreads
sys_notification_subscription.⚠️ [#9807] ... NOT WIRED in this repo.MessagingService.emit()does callPreferenceResolver.filter()on theresolved recipients and logs
suppressed for all recipients by preferencewhen it empties — that half of the original sentence is real.
Scope
One sentence, one file (
content/docs/operate/audit-logs.mdx), per theissue's declared surface and the 2026-08-23 triage adjudication (not
re-litigated here). No locale siblings exist for this page. The same false
claim on
content/docs/configure/notifications.mdxis issue #147's surfaceand is not touched here. The
cloud-repo leg stays the issue's declared,unmeasured narrowing.
Tests
Run from the repo root (
objectoshas no changeset flow and nopackages/):pnpm turbo run build --force→Tasks: 1 successful, 1 totalpnpm turbo run test --force→Tasks: 1 successful, 1 total(includesthe
check-locale-surface.mjsself-tests)node .github/scripts/check-locale-surface.mjs(exit 0) →✓ every advertised URL has a source file and every source file is advertised; both llms bodies carry every en-only page title and none from the other locales; and no page slug in the content tree contains a dotVerified at commit
4515729.Generated by Claude Code