Skip to content

docs(ci): correct lint.yml corpus-claim-drift comment for #13745's shipped rows - #14790

Merged
baozhoutao merged 2 commits into
mainfrom
claude/issue-14601-lint-yml-corpus-claim-comment
Sep 3, 2026
Merged

docs(ci): correct lint.yml corpus-claim-drift comment for #13745's shipped rows#14790
baozhoutao merged 2 commits into
mainfrom
claude/issue-14601-lint-yml-corpus-claim-comment

Conversation

@claude

@claude claude Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #14601

What

.github/workflows/lint.yml, in the comment block above the Teaching-corpus lexical anti-drift ratchet step (run: pnpm check:corpus-claim-drift), said the vocabulary table carried the $exists family ONLY and forward-referenced the retired $regex spelling and #13532's visibleWhen claims as pending. #13745 (PR #14604, merged) shipped all three rows to scripts/check-corpus-claim-drift.mjs, so every clause of that sentence was false on origin/main. This PR replaces the comment with the wording the card offered — triage-verified against the landed state.

Before → after

Before (lint.yml:1966-1968 on the base commit):

# Table-driven by the #13582 triage ruling, carrying the `$exists` family
# ONLY — each further word (the retired `$regex` spelling, #13532's
# `visibleWhen` claims) pays its own baseline on its own card.

After:

# Table-driven by the #13582 triage ruling. #13582 shipped the `$exists`
# family alone; #13745 added the `(NoSQL)` portability gloss, the retired
# `$regex` spelling and #13532's `visibleWhen` claims, each with its own
# legitimate-usage survey. Each further word pays its own baseline on its
# own card, and the gate's `--self-test` pins the shipped row set as an
# exact enumeration.

Evidence the new wording is true on this base

scripts/check-corpus-claim-drift.mjs (untouched by this PR — verified only, not edited):

  • scripts/check-corpus-claim-drift.mjs:184id: 'exists-portability' (the (NoSQL) portability gloss row)
  • scripts/check-corpus-claim-drift.mjs:202id: 'regex-retired' (the retired $regex spelling row)
  • scripts/check-corpus-claim-drift.mjs:227id: 'section-visiblewhen-unbound' (docs(ui,protocol,lint): a form SECTION visibleWhen binds current_user — retire the claim from the three prose sites #13074 left unswept #13532's visibleWhen claims row)
  • scripts/check-corpus-claim-drift.mjs:575-580SHIPPED_ROW_IDS pins the exact enumeration (exists-key-presence, exists-portability, regex-retired, section-visiblewhen-unbound) that the gate's --self-test asserts the live VOCABULARY table equals, no more and no less.

Scope

Exactly the three comment lines named above. Nothing else in lint.yml (two open drafts hold other regions of this hot file per triage: PR #14763 near :5200, PR #14277 elsewhere). The gate script itself — its header, its VOCABULARY JSDoc, its --self-test — is untouched; #13745 already updated those. No sweep for other stale comments elsewhere in the file, per the triage ruling.

$ git diff origin/main...HEAD --stat
 .github/workflows/lint.yml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Verification

  • YAML parses clean: node -e "require('yaml').parse(...)" → 6 jobs, no errors, on both the pre-merge and post-merge tree.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml → 23 derived families (13 pnpm, 10 direct node), unchanged before and after merging origin/main.
  • All 23 run: 22 green; pnpm check:type-check-debt refuses with its own documented PREREQUISITE NOT MET (55 workspace packages missing built dist/*.d.ts in this worktree — exit 3, explicitly "not a finding, nothing was measured") — unrelated to this comment-only change, and building the full workspace closure is out of scope for a 3-line workflow comment. Recorded as NOT-MEASURED with reason via node scripts/pm/dispatch-gates.mjs --ran, which reconciled: 23 derived famil(ies) accounted for — 22 run, 1 NOT-MEASURED.
  • Re-verified after merging origin/main (ba39057ac): the derived family list is identical (merge touched no gate-source path for this card), and re-ran check-self-test-workflow-commands.mjs, check-required-contexts.mjs (both spellings), check:pm-dispatch-gates, check:required-contexts, check:workflow-status-functions — all green on the merged head.

skip-changeset: this PR touches only .github/workflows/lint.yml (a comment) — nothing is published from any released package.


🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ipped rows

The comment above the Teaching-corpus lexical anti-drift ratchet step said
the vocabulary table carried the `$exists` family ONLY and forward-referenced
`$regex` / `visibleWhen` as pending. #13745 (PR #14604) shipped all three
rows to scripts/check-corpus-claim-drift.mjs, so every clause was false.
Replace the comment with wording that matches the landed state.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33713928872 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test:  FAIL   integration  test/run-dev-unbuilt-workspace.e2e.test.ts > the mirror direction: a reader that is never coming back > gives up and exits instead of waiting forever
      ↳ 失败原因: @objectstack/cli:test: AssertionError: the harness SIGKILLed the child — it was still alive at the ceiling. cap 180000 ms (RUN_TIMEOUT_MS, constant and load-independent by design); this child ran 1800
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 54 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33714189853 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test:  FAIL   integration  test/run-dev-unbuilt-workspace.e2e.test.ts > the mirror direction: a reader that is never coming back > gives up and exits instead of waiting forever
      ↳ 失败原因: @objectstack/cli:test: AssertionError: the harness SIGKILLed the child — it was still alive at the ceiling. cap 180000 ms (RUN_TIMEOUT_MS, constant and load-independent by design); this child ran 1800
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • ⚠️ 本 PR 过去 24h 已在队列失败 1 次(不含本次)。 内容未变而反复失败 ⇒ 高度怀疑 flaky 测试或与同组 PR 的语义冲突,重排不解决。
  • 过去 24h 队列共有 59 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Merged via the queue into main with commit b1cf795 Sep 3, 2026
31 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14601-lint-yml-corpus-claim-comment branch September 3, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants