Skip to content

fix(pm): correct stale four/two-copy decision-frame comments to two-copy truth - #15105

Merged
os-steve merged 1 commit into
mainfrom
claude/issue-14870-frame-copies-comments
Sep 3, 2026
Merged

fix(pm): correct stale four/two-copy decision-frame comments to two-copy truth#15105
os-steve merged 1 commit into
mainfrom
claude/issue-14870-frame-copies-comments

Conversation

@os-steve

@os-steve os-steve commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes #14870

What

check:skill-frame-sync's COPIES table dropped from four entries to two (internal-pm.claude/skills/pm-dispatch/SKILL.md, published-pmskills/objectstack-pm-dispatch/SKILL.md) once the dev-side frame copies were retired — the dispatch PM now pastes its own copy into the dev prompt's {decision_frame} slot at dispatch time instead of either side embedding one. Six comments across three gate scripts still described the old four/two-copy state as present-tense fact. This PR rewrites exactly those six sites to the current truth, plus one unrelated one-word usage-line fix folded in by the seat. Comment/string text only — no behaviour, no verdict line, no ceiling value changed anywhere.

The six sites (before → after)

scripts/pm/dispatch-gates.mjs

  1. MANDATORY_TIER_GLOBS why-string for .claude/agents/os-dev.md — kept the mandate (clause ① protocol semantics still holds), fixed only the false reason:
    • before: …every dispatched dev runs under it, and it carries an enforced copy of the decision frame
    • after: …every dispatched dev runs under it, and receives the decision frame the PM pastes into its prompt at dispatch time rather than carrying a copy of its own
  2. MANDATORY_TIER_GLOBS why-string for skills/objectstack-pm-dispatch/SKILL.md:
    • before: …the published PM skill carries two enforced copies of the decision frame (check:skill-frame-sync COPIES)…
    • after: …the published PM skill carries one enforced copy of the decision frame (check:skill-frame-sync COPIES)…
  3. Self-test assertion label only (the boolean it asserts is untouched):
    • before: t('the published PM skill (two enforced frame copies) is fable-mandatory', …)
    • after: t('the published PM skill (one enforced frame copy) is fable-mandatory', …)

Docblock line at the old :8468 ("every file carrying an enforced copy of the decision frame (the COPIES table…)") was checked against the ruling's "if it counts wrongly" condition and left untouched: it never asserts a specific number, and it already lists the dev-agent definition as a separate item rather than as a frame-copy carrier — so it doesn't count wrongly post-reduction.

scripts/pm/check-skill-line-ratchet.mjs — the os-dev.md ceiling ledger comment justifying its 466→469 raise:

scripts/check-skills-token-ratchet.mjs — three ledger comments for skills/objectstack-pm-dispatch/SKILL.md's history:

  • …and this file carries TWO enforced frame copies (check:skill-frame-sync COPIES)……and this file carries one enforced frame copy (check:skill-frame-sync COPIES)…
  • …this file carries TWO\n enforced frame copies (check:skill-frame-sync COPIES)……this file carries one\n enforced frame copy (check:skill-frame-sync COPIES)…
  • …the two gate-pinned copies of the decision frame stay in this file……the one gate-pinned copy of the decision frame stays in this file…
  • Checked the nearby "The largest of the five and the frame the other four are read under" sentence (:324) against the same "if it counts wrongly" condition: it's an unrelated sense of "frame" (the skill-package reading order, not the decision frame) and an unrelated "five"/"four" (SKILL.md package count, not COPIES) — left untouched, per the mechanism-assumptions note that this file's comment block counts other things ("the five rules/*.md rows" elsewhere) for reasons that have nothing to do with frame COPIES.
  • Ceiling values are unchanged throughout.

The one-word member (folded in per the seat's dispatch)

dispatch-gates.mjs's USAGE_LINE presented --changed as a whole-invocation alternative that takes no other flag (… [<path> ...] | --changed | --self-test), though --changed --commands is legal and answers (verified live: exit 0, 23 commands). Moved --changed into the position <path> ... occupies — the other path source it stands in for — matching how #15036 placed --residue inside the alternation it really combines with:

- ' [--repo owner/name] [<path> ...] | --changed | --self-test';
+ ' [--repo owner/name] [<path> ... | --changed] | --self-test';

Pinned beside the existing #15036 usage-line pins with three new self-test cases, including a live CONTROL that --changed --commands really answers (so the fix isn't cosmetic on a refusal that doesn't exist).

Tests

All run through the shared verify lock; self-test verdict lines quoted exactly, before/after byte-identical for the six comment-text sites.

  • node scripts/check-skill-frame-sync.mjs (unaffected file, sanity check both before and after): ✓ check-skill-frame-sync: 2 copies of the decision frame are structurally isomorphic across 2 files — unchanged.
  • node scripts/pm/check-skill-line-ratchet.mjs --self-test: before ✓ check-skill-line-ratchet self-test: 136 cases pass.after ✓ check-skill-line-ratchet self-test: 136 cases pass. (identical).
  • node scripts/pm/check-skill-line-ratchet.mjs (regular verdict, post-edit): green, ceilings/headroom unchanged (AGENTS.md 1157/1162, CLAUDE.md 36/86, one declared cross-file move, etc.) — no ratcheted file was touched by this PR.
  • node scripts/check-skills-token-ratchet.mjs --self-test: before ✓ check-skills-token-ratchet self-test: 64 cases pass.after ✓ check-skills-token-ratchet self-test: 64 cases pass. (identical).
  • node scripts/check-skills-token-ratchet.mjs (regular verdict): before/after diff on full output is empty (byte-identical) — ✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.
  • node scripts/pm/dispatch-gates.mjs --self-test (the heavy one, run through the lock each time):
    • baseline (pre-edit, origin/main 0f94cc7c): ✓ dispatch-gates self-test: 1319 cases pass.
    • final (all edits applied, working tree): ✓ dispatch-gates self-test: 1322 cases pass. — exactly +3, the new --changed usage-line pins (item 2); zero anywhere in either run.
  • pnpm check:pm-skill-ratchet (the wrapped gate form): green, same ceiling readings as the direct run above.
  • pnpm check:skill-frame-sync: ✓ check-skill-frame-sync self-test: 13 cases pass, plus 5 dispatch-gates declaration cases and 3 scan-population cases then ✓ check-skill-frame-sync: 2 copies … across 2 files — the 5 "dispatch-gates declaration cases" cross-check MANDATORY_TIER_GLOBS against COPIES and stayed green, confirming cross-file consistency after the edits.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (live re-derivation against this diff, no paths passed): 28 families owed total (21 matched by path + 1 by change-kind convention [node scripts/pm/bare-root-worklist.mjs --self-test, triggered because this diff edits gate scripts] + 6 always-run whole-tree). All 28 run below.
  • Re-run on the committed HEAD cd303b24 (this PR's exact head, after push): node scripts/pm/dispatch-gates.mjs --self-test✓ dispatch-gates self-test: 1322 cases pass. (exit 0); node scripts/pm/check-skill-line-ratchet.mjs --self-test✓ check-skill-line-ratchet self-test: 136 cases pass. (exit 0, identical to baseline); node scripts/check-skills-token-ratchet.mjs --self-test✓ check-skills-token-ratchet self-test: 64 cases pass. (exit 0, identical to baseline).
  • npx eslint scripts/pm/dispatch-gates.mjs scripts/pm/check-skill-line-ratchet.mjs scripts/check-skills-token-ratchet.mjs --no-inline-config --format json: 3 files linted (count read from the JSON output itself), 0 errors, 0 warnings. Narrowed-but-proven per this repo's own lint config, which never enables type-aware linting for any file (eslint.config.mjs's own comment: "never enables type-aware linting … for ANY" file) — so this diff (comment/string edits in 3 files) cannot move any untouched file's verdict, and the full repo-wide pnpm lint is deferred to CI rather than re-run locally.

Full local gate table (all green, exit code captured before any pipe)

node scripts/check-ci-filter-parity.mjs                            — OK
node scripts/check-closing-keyword-parity.mjs --self-test          — ✓ 24 assertions, 5 mutations driven red
node scripts/check-closing-keyword-parity.mjs                      — OK (5 files carrying the grammar, all registered)
node scripts/check-comment-mask-corpus.mjs                         — ✓ 5849 files, 0 disagree
node scripts/check-cross-package-test-inputs.mjs                   — OK
node scripts/check-self-test-wired.mjs --self-test                 — ✓ 7 batteries, 50 cases
node scripts/check-self-test-wired.mjs                             — ✓ 166/166 self-tests wired
node scripts/check-shard-attestation.mjs                           — ✓ 2 aggregates, 3 legs
node scripts/check-test-completeness.mjs                           — exit 3, PREREQUISITE NOT MET (NOT MEASURED, by design — no local turbo-test log; no vitest package touched)
node scripts/check-whole-set-label-write.mjs --self-test           — ✓ all cases pass
node scripts/check-whole-set-label-write.mjs                       — ✓ (160 pins cleared)
node scripts/pm/bare-root-worklist.mjs --self-test                 — OK (66 rows, none stale/missing/contradicted) — convention-triggered by editing gate scripts
pnpm check:agent-test-spelling                                     — EXIT 0
pnpm check:bash32-floor                                            — ✓ 153 self-test cases; 26 shell files clean
pnpm check:cli-command-ids                                         — ✓ 39 self-test cases; 324 literals resolve
pnpm check:cross-package-test-inputs                                — ✓ 117 self-test cases; OK
pnpm check:declared-population-live                                 — ✓ 16 assertions; 190/240 families
pnpm check:entry-guard                                              — ✓ 54 self-test cases; 206 files clean
pnpm check:nul-bytes                                                — ✓ 75 self-test assertions; OK (8211 files, 0 raw control bytes)
pnpm check:parse-guard                                              — EXIT 0
pnpm check:pm-dispatch-gates                                        — = dispatch-gates.mjs --self-test (see above); wrapper confirmed equivalent from its own header
pnpm check:pm-skill-ratchet                                         — green (see Tests above)
pnpm check:pnpm-filter-targets                                      — ✓ 54+40 self-test assertions; 142/181 filters resolve
pnpm check:ratchet-remedy-authority                                 — OK 186 scripts swept
pnpm check:refd-timer-probe                                         — ✓ 11 self-test cases; 1 approved site
pnpm check:watch-hint-literal                                       — ✓ 57 self-test cases; 48 declarations clean
node scripts/check-skills-token-ratchet.mjs --self-test             — ✓ 64 cases pass (identical before/after)
node scripts/check-skills-token-ratchet.mjs                         — ✓ (identical before/after, diff empty)

Also ran ad hoc (not on the given list, but load-bearing for this PR):

node scripts/check-nul-bytes.mjs (targeted grep on the 3 touched files) — clean, no control bytes
git grep for stray "carries two enforced"/"four…COPIES" text repo-wide outside the 3 files — zero hits

Repo-wide pnpm lint and the changeset-triggered gate family were not run locally — this PR's surface is exactly three scripts/** files (no package publish, no .changeset/), so those either don't apply or are deferred to CI per the standard local-scope discipline.

Scope discipline

skip-changeset

This PR publishes nothing from any released package (scripts/pm/** and scripts/*.mjs tooling only) — applying the skip-changeset label per the repo's real mechanism, with an additive write and read-back.


Generated by Claude Code

…opy truth

check:skill-frame-sync's COPIES table dropped from four entries to two
(internal-pm, published-pm) when the dev-side frame copies were retired —
the dev prompt now receives the frame pasted from the PM's own copy at
dispatch time instead of embedding one. Six comments across
dispatch-gates.mjs, check-skill-line-ratchet.mjs and
check-skills-token-ratchet.mjs still described the old four/two-copy state
as present-tense fact; this rewrites them to the current truth without
touching any behaviour, verdict line, or ceiling value (every affected
self-test prints the identical case count before and after).

Also moves dispatch-gates.mjs's `--changed` flag from a whole-invocation
usage-line alternative (implying it excludes --commands/--json) to the
position `<path> ...` occupies, matching how #15036 placed --residue —
`--changed --commands` is legal and answers, so the old line advertised a
refusal the argv chain does not make. New self-test pins lock the fix,
including a live CONTROL that the combination really works.

Fixes #14870

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox
@github-actions github-actions Bot added the size/s label Sep 3, 2026
@os-steve os-steve added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026 — with Claude
@os-steve
os-steve marked this pull request as ready for review September 3, 2026 23:00
@os-steve
os-steve enabled auto-merge September 3, 2026 23:01
@os-steve
os-steve added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit 369da91 Sep 3, 2026
36 checks passed
@os-steve
os-steve deleted the claude/issue-14870-frame-copies-comments branch September 3, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants