Skip to content

fix(pm): CONTRACT_REVIEW_TIER's docblock states a REVIEW tier, not a dispatch mandate #17509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-litant merged 1 commit into from
Sep 10, 2026
Merged

fix(pm): CONTRACT_REVIEW_TIER's docblock states a REVIEW tier, not a dispatch mandate #17509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/pm/dispatch-gates.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10486,10 +10486,12 @@ export function residueLines(

/**
* The single source of truth for the model tier the PM lane's governance
* reads — clause ②'s CONTRACT-REVIEW tier: the tier a card that changes
* contract accept/reject behaviour or widens the public surface must be
* dispatched at, and the tier the `needs:contract-review` re-review sub-round
* must itself be running at (its opening self-check reads this). Declared HERE
* reads — clause ②'s CONTRACT-REVIEW tier: the tier the clause-② REVIEW runs
* at, both halves of it — the spec seat's review of a card that changes
* contract accept/reject behaviour or widens the public surface, and the
* `needs:contract-review` re-review sub-round (its opening self-check reads
* this). The BUILD of such a card is at the default judgment tier, so this
* constant is a review tier and never a dispatch mandate. Declared HERE
* and only here, as a constant, so a model upgrade is a one-line change in one
* file — the clause-① mandate rows below read it, the self-test compares
* against it, and the PM skill's prose names it, so the model id is spelled as
Expand Down
Loading