fix(types,plugin-designer)!: the app wizard saves a document the spec accepts — a separator without label, branding kept on edit, no Layout control (objectui#10867) - #10889
Merged
objectstack-fleet[bot] merged 6 commits intoSep 28, 2026
Conversation
…tor without label, branding kept on edit, no Layout control
- @object-ui/types: NavigationItem is a union of NavigationEntryItem and
NavigationSeparatorItem. The separator arm admits exactly the spec
separator's keys (type, id, order); every other entry key is `?: never`.
menuItemToNavigationItem drops a legacy separator's label.
AppWizardDraft.layout is removed.
- spec-derived-unions: the blocker-3 pin (separator label) is lifted and
replaced by an agreement pin against the spec separator at both tiers.
- @object-ui/plugin-designer: the wizard and NavigationDesigner write a
separator as { id, type }; the wizard's Layout control is removed;
EditAppPage keeps every stored branding key the spec's AppBrandingSchema
declares (accentColor included) through the edit save.
- @object-ui/i18n: the four appDesigner.layout* keys are removed from all
ten packs, and stepBasicDesc no longer names a layout.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…842 and 3162 entries The new changeset declares @object-ui/types minor (BREAKING authoring banner) and @object-ui/plugin-designer and @object-ui/i18n patch. The 10842 entry's "the wizard's layout choice is not saved" and the 3162 entry's "three semantic blockers" get dated notes; both frontmatters are byte-identical. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…ry-only key is read or written - layout: resolveNavItemLabel answers '' for a separator; the mobile bottom nav's leaf list is typed as entries; collectPinnedItems checks the type before `pinned`. - plugin-designer: NavigationDesigner's label / icon / visibility patchers skip a separator. - layout tests: fixtures that spread an entry and add `visible` or `requiredPermissions` are typed as NavigationEntryItem. - changeset: @object-ui/layout patch, and the migration line for spreads. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…Studio nav walk - useNavPins: togglePin registers a favorite only for an entry (a separator is never pinnable and carries no label); applyPins leaves a separator as it is. - UnifiedSidebar: the Studio navigation walk returns a separator as it is, before rewriting children or the packages entry. - UnifiedSidebar.derivedAreaVisibility test: the spread fixtures are typed as NavigationEntryItem. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…eparator narrowing Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
github-actions
Bot
added
documentation
Contributor
|
changeset-claim-re-read
|
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
…r does not declare; changeset corrections (objectui#10867 round 1) - NavigationItemSchema's separator branch refuses every key outside the spec separator's own set (type, id, order), read off the spec AppSchema's navigation union rather than restated, with a message that names the key to drop. objectui validate no longer passes a separator label the save door refuses. - navigation-spec-parity: the separator-label row leaves the divergence list and becomes an agreement assertion; the mirror doc and the NavigationItemSchema ledger reason count four divergences, not five. - New pins: nav-separator-mirror-refusal-10867 (safeValidateSchema, the strict face and the mirror refuse a separator label; a bare separator is accepted), and an EditAppPage row that a cleared logo saves as ''. - Changeset: @object-ui/i18n is minor; the banner names the union-alias, validate and raw-key consequences; the layout, reading, designer and pins wording is corrected. The 10842 dated note keeps only its layout half (frontmatter byte-identical). - spec-derived-unions: the spec-validity pin's comment says what it can and cannot see. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Contributor
Author
Contract reviewServed-tier: ① Derived judgmentsMember 1, the union: correct.
The narrowing sites are render-neutral, including for a stored separator that still carries a label:
The one real behaviour change: the exported Member 2: correct, nothing is resurrected.
Member 3: complete. The census finds no Pins.
The changeset. Blocking.
Dated notes.
Follow-up. The zod mirror Out of scope, not made worse: ② Semver level
③ Boundary flags
Implemented-by: VERDICT: FAIL Required: the i18n bump to |
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
Author
Contract reviewServed-tier: This is an in-seat delta review of fix round 1 ( ① Derived judgments
② Semver level
③ Boundary flags
Implemented-by: VERDICT: PASS |
objectstack-fleet
Bot
deleted the
claude/issue-10867-app-wizard-saves-spec-app
branch
September 28, 2026 04:55
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 28, 2026
…ts name 41 objectui issues that answer 404 (objectui#10803, batch 5) (objectstack-ai#10892) Part of objectstack-ai#10803 Clause-②: no Dispatched implementation of the `domain:ui` seat 2 claim (comment `5862515185`) on objectui#10803, batch 5, session `https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`. Citations only: no sentence's claim moves, and every edited pending changeset's frontmatter is byte-identical. The runtime text that moves loses its dead pointer and nothing else, all in `@object-ui/types`: the six `ChatbotSchema` tombstone guidance strings open `RETIRED (ADR-0049) —` (rulings `5861129870` and `5861311219`), the `page` node's `actions` refusal, an ADR-0049 tombstone too, cites `(ADR-0049)` in place of its dead card (ruling `5861129870`, as measured in patch round 1), and the `ChartDataSeriesSchema.variant` description drops its pointer (amendment `5860244997`, Q1 = A). Two tests that pin changed text follow it, anchor only (ruling `5861900779`, route a). **Patch round 1** answers the contract review's one FAIL item on `afed8aa6b`: Special cases 7 had read the `actions` refusal as not ADR-0049 from a proxy (the `breadcrumbs` changeset, which only says the 2026-09-09 RULING is not borrowed). Measured from the retirement itself, it is an ADR-0049 tombstone, so under the seat's option (a) its string now reads "never was (ADR-0049): no renderer reads it". The runtime-strings changeset follows, and the sweep changeset notes that `@object-ui/types`' runtime text is declared separately. One text-only commit, `8255f14f4`; no merge, no force-push. ## Why `Part of`, not a closing line The card stays open for the other 23 numbers of the family remainder (seat amendment `5860244997`, Q2 = A), listed in **Acceptance notes** 1, and for the bare sister-repo numbers the C0 census below lists. ## Premise, re-measured - REST `GET /repos/objectstack-ai/objectui/issues/N` for each of the 41: all 41 answer 404, and a second read of each answers 404 again (41 of 41). `GET .../pulls/N` answers 404 for all 41 too. Lit controls: objectui#10533 and objectui#7714 answer 200. No number was dropped from the batch. - The same 41 in objectstack all answer 200. Three of them are the sites' real subject, read not guessed, and are re-qualified (Zone 1 item 5): - objectstack#3720 "列表行级 edit/delete 与批量删除未接入服务端 effective 操作集": the five `[objectstack-ai#3720]` sites in `ObjectGrid.tsx`, `rowCrudAffordances.ts` and `ListView.tsx` describe that gate, and their landing `ba4514511` is titled "gate list row Edit/Delete and bulk delete on the effective operation set (objectstack#3720)". - objectstack#5506, the "five more hardcoded English chrome strings" card: `useDetailTranslation.ts` wrote "the SAME key objectstack-ai#5506 gave NavigationOverlay's identical handle", and nine sibling in-scope lines already cite `objectstack#5506` for those strings. - objectstack#6936, the metadata-admin predicate fail-CLOSED card: `predicate.ts` wrote "objectstack-ai#6936's `true` verdict" one line below "objectstack#6936's unresolved-path ruling". - Every other site names an objectui card or pull request, confirmed by its landing commit below (for example objectstack#7853 is a `driver-memory` finding, while objectui#7853 is the cite-by-content ruling AGENTS.md objectstack-ai#11 names). - Every edited changeset is pending: it is present in `.changeset/` on `main`. - Branch point: `b2683a2c0`. `main` is now `4f8b7f86a`; its census still reads 215, and the merge of this head with it reads 0. Not a shallow checkout. ## C0: the bare-number remainder (measurement only) The instrument of PR objectui#10875, at the branch point: ``` git grep -hoP '(?:^|(?<=[^\w#&/.\-]))#\d+(?![0-9A-Za-z_])' b2683a2 -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | sort -u | wc -l ``` - **998 distinct bare numbers** at `b2683a2c0` (1002 at batch 4's `e32dae160`): the eight batch 4 re-pointed are gone, and four are new since: objectstack-ai#10321, objectstack-ai#8365 and objectstack-ai#9242 (at or below 10900, each read once: 200) and #20051. - **Above 10900: 23**, batch 4's 22 plus #20051. Each was read once with REST `GET .../issues/N`: **23 answer 404**, and each answered 404 again on a second read (23 of 23); `GET .../pulls/N` answers 404 for the 18 that are not colours. - None of them is an objectui citation, and none sits in a sentence or hunk this batch edits, so **nothing is folded here**: - **5 are CSS colours:** #334155, #336699, #475569, #737373, #953800. - **18 are objectstack numbers**, 16 of which answer 200 there with the sites' own subject. #13033 and #13413 answer 404 in objectstack too. Sites (lines / files, at `b2683a2c0`) are listed in **Acceptance notes** 2 for later batches. ## Census (the enumeration pin for this batch) The instrument PR objectui#10854 printed and PRs objectui#10869 / objectstack-ai#10875 reused, with this batch's 41 numbers substituted (REF = a commit or tree): ``` git grep -nE '(objectui#|#|issues/)(7091|7097|7108|7177|7612|7620|7623|7658|7666|7667|7669|7678|7681|7682|7703|7704|7708|7804|7844|7853|7869|7874|7877|7926|7959|7967|7979|7980|8058|8060|3720|5420|5503|5506|5737|6467|6936|6945|7622|7662|7684)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | grep -v 'objectstack#' | wc -l ``` - REF = `b2683a2c0` (branch point, and `main` now): **215** lines, 74 changeset lines in 55 files and 141 src lines in 47 files. - REF = `8255f14f4` (this head): **0**. Round 0's head `afed8aa6b` also read 0. - This head merged with a fresh `main` (`4f8b7f86a`, `git merge-tree --write-tree`, clean, tree `08f80168a`): **0**. REF = `4f8b7f86a` alone: 215. - **The filter hid nothing this time.** The 18 branch-point lines the `grep -v 'objectstack#'` drops name only objectstack#6936 or objectstack#5506; with those tokens deleted, none of them matches the instrument (0). Unfiltered, this head reads **26**, all live `objectstack#` lines: the 18, the seven re-qualified here, and the same spelling in the new sweep changeset. - Lit control, the same printed instrument over live objectui#7714 at this head: 17 lines. Hex-colour false positives (a number followed by a hex letter) at the branch point: 0. - **Out of scope, as it stands** (the instrument with the 41 numbers, unfiltered, whole tree at this head): 367 test lines in 98 files, 23 scripts lines in 5 files, 0 `.github`, 5 governed lines in 4 files (`AGENTS.md` and three `skills/objectui` files), and 51 other lines in 18 files: published `CHANGELOG.md` history (21 lines in 8 files), `content/docs` (11 in 4), `apps/console` (7 in 3), `eslint-rules` (8 in 2) and `eslint.config.js` (4). See **Acceptance notes** 4. ## Citation form - The 9-character backticked sha of the commit on `main` that landed the change the sentence rests on, as in PRs objectui#10707 / objectstack-ai#10766 / objectstack-ai#10797 / objectstack-ai#10854 / objectstack-ai#10869 / objectstack-ai#10875. All 40 distinct shas in the mapping are ancestors of `main`: `git merge-base --is-ancestor`, exit 0 each. Control leg in the same checkout: the head of PR objectui#10714 (`d2afdb6bf`) answers exit 1, and a known ancestor, `5f789538d`, answers exit 0. `git rev-parse --short=9` returns the same 9 characters for each. - A changeset's pointer to its OWN card is dropped, not replaced: `@changesets/changelog-git` prefixes each released entry with the hash of the commit that added the file, which is that landing. Where dropping it left a dangling word, the clause was minimally repaired (**Special cases** 5). - Where the sentence rests on a RULING, the ruling is cited by its date (**Special cases** 4). - Where a dead card sits beside a live pull request that IS its landing, the dead card is dropped and the live pointer stays (**Special cases** 1). - Where the claim lived only on the dead card (a finding, a ruling, a scope, a comment), the sha only locates it: "the card behind SHA", "the ruling behind SHA" (**Special cases** 3). Review `5861306588`'s lesson: a sha must carry what the sentence cites it for. - Where nothing answers, the pointer is dropped and the sentence names the card by role (objectstack-ai#7612, objectstack-ai#7666, objectstack-ai#7682, objectstack-ai#7844, and the open objectstack-ai#7804 parent). - Runtime text carries no sha: see **Special cases** 7. ## Mapping (number to resolution) Lines / files are the branch-point census for that number. "Method" is how the landing was found. The last column is why that commit carries what the sentence cites it for. | dead number | resolution | method | lines / files | why the commit carries it | |:--|:--|:--|:--|:--| | objectstack-ai#7091 (a pull request) | `969ba84f4` | `git log --grep`: its squash subject ends "(objectstack-ai#7091)" | 1 / 1 | it registers the console `app:launcher` renderer, which is what made the "not a page" clause false | | objectstack-ai#7097 | `3cab5703b`; own-card pointer dropped | changeset's adding commit | 3 / 3 | it adds the `2xl` read arm and the literal `GRID_COLS_2XL` class map, the value-level fix both sentences name | | objectstack-ai#7108 | `1267508ea`; own-card pointer dropped | changeset's adding commit | 3 / 2 | it tombstones a deleted record reference in the approvals inbox, the platform-flagged class the sentences name | | objectstack-ai#7177 | own-card pointer dropped (landing `ebc05b4d6`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7612 | "the 2026-09-20 ruling"; the card by role | `git log --grep` finds only `2ca238075`, the objectui#10150 record of the ruling; the switch, PR objectui#10054, closed unmerged | 3 / 2 | nothing landed: the ruling was "no". See **Special cases** 3 and 4 | | objectstack-ai#7620 | `c15d7eca6`; "ruling A behind `c15d7eca6`" where the sentence cites the ruling; own-card pointer dropped | changeset's adding commit, `git log -S` | 13 / 10 | it moves `data-table`'s date-only fallback onto `formatDate`'s default face, and its message records the two-faces fact pattern the sentences cite | | objectstack-ai#7623 | `5d0876c5c`; own-card pointer dropped | changeset's adding commit | 3 / 3 | it retires the inert dashboard-root `title` declaration | | objectstack-ai#7658 | `90c6d090d`; own-card pointer dropped | changeset's adding commit | 2 / 2 | it keeps code-span content out of `extractToc`'s HTML strip | | objectstack-ai#7666 | nothing answers: the card by role ("already-filed defect") | `git log -S` finds only `a472b0716`, which records it as an already-filed defect | 1 / 1 | see **Special cases** 3 | | objectstack-ai#7667 | `a472b0716`; own-card pointer dropped | changeset's adding commit | 2 / 2 | it gives `extractToc`'s emphasis rules the flanking rule that keeps `SCREAMING_SNAKE` underscores | | objectstack-ai#7669 (a pull request) | `a3eb5d07a` | `git log --grep`: its squash subject ends "(objectstack-ai#7669)" | 2 / 2 | it retires `FloatingChatbotConfig.triggerIcon` as the tombstone both sentences name | | objectstack-ai#7678 | `5f8190c8c` ("in its amended form"); own-card pointers dropped | changeset's adding commit; its body opens "Part of objectstack-ai#7678" | 21 / 14 | it brings every statement of the retire-vs-remove discriminator to the amended form, the surviving-carrier precondition included. See **Special cases** 6 | | objectstack-ai#7681 | `01c27c431`; own-card pointer dropped | changeset's adding commit | 6 / 4 | it routes a `dataKey`-shaped series through `normalizeSeries`, removing the fast path, so its `type` override is honoured | | objectstack-ai#7682 | nothing answers: "a separate card"; runtime pointer dropped | `git log -S` finds only `8fe8e5c16`, which defers that decision to it | 3 / 3 | see **Special cases** 3 | | objectstack-ai#7703 | `a4611b3e2`; runtime text `RETIRED (ADR-0049) —`; own-card pointer dropped | changeset's adding commit | 15 / 3 | it retires the six dark `ChatbotSchema` keys as ADR-0049 tombstones | | objectstack-ai#7704 | `20316bac3`; "the card behind `20316bac3`" for the scope note; own-card pointer dropped | changeset's adding commit | 3 / 2 | it adds `chatbot-enhanced` and `chatbot-floating` to `SchemaRegistry` | | objectstack-ai#7708 | `d3499b315`; PR objectstack-ai#8077 kept where it stands beside the dead card; "the card behind `d3499b315`" for the ruling; own-card and runtime pointers dropped | changeset's adding commit, `git log --grep` | 13 / 6 | it fences `chatbot-floating`'s raw props spread through `toDomProps` at the head of the element | | objectstack-ai#7804 (the handler-key parent) | per slice, by `git blame`: `75fca9669` (data-table), `7ca6ddd4b` (detail), `f1cd29032` (list-view), `5a41ce733` (object-kanban), `8d50bc2bf` (objectql.ts), `604476d97` (tree-view); own-card pointers dropped; "the handler-key parent card" where the sentence means the open parent | each slice changeset's adding commit, and `git blame` per line | 49 / 17 | each commit declares exactly the handler keys the site's arm or face names | | objectstack-ai#7844 | nothing answers: "their own card" | `git log -S` finds only `c4a1d39fe`, which leaves both sub-shapes dark | 1 / 1 | see **Special cases** 3 | | objectstack-ai#7853 | "the card behind `fa7d66c45`" | AGENTS.md objectstack-ai#11 names `fa7d66c45` as its landing | 3 / 3 | the ruling lived on the card; `fa7d66c45` is its one-site landing | | objectstack-ai#7869 | "the finding objectui#8344 discharged" / "the finding this card discharges" (landing `841dd2b7e`) | `841dd2b7e`'s message; the live objectui#8344's body, "Discharges the finding objectstack-ai#7869" | 2 / 2 | the measurement lived on the dead finding, and the live card that discharged it restates it | | objectstack-ai#7874 | `d9580f464`; PR objectstack-ai#7887 kept beside the dead card; own-card pointer dropped | changeset's adding commit | 3 / 3 | it retires the five dead `timeline.relative.*` rows | | objectstack-ai#7877 | `7dcda9cd4` | `git log -S` on the heading | 1 / 1 | it moves the hand-rolled-table data into `hand-rolled-tables.json`, the heading's subject | | objectstack-ai#7926 | `12b599219`; "the 2026-09-09 ruling"; "the `actions` refusal" by role beside PR objectstack-ai#8870; runtime text `(ADR-0049)`; own-card pointer dropped | changeset's adding commit | 15 / 6 | it refuses `actions` by name on the `page` node, measures `breadcrumbs` at 1 site and leaves it parsing, and pins that | | objectstack-ai#7959 | `36fc74629`; "the card behind `36fc74629`" for its scope restraint | the tests it added are headed "objectui#7959" | 8 / 6 | it adds `readEnvelopeFailureText`, the userMessage-first rule on `PackagesPage`, and the load-failure testid | | objectstack-ai#7967 | own-card pointer dropped (landing `0544ae958`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7979 | own-card pointer dropped (landing `bfa4fe728`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7980 | `a810bb2ae`; "the card behind `a810bb2ae`" for its surface and its comment; own-card pointer dropped | changeset's adding commit | 4 / 3 | it publishes `readEnvelopeFailureText` from the package entry | | objectstack-ai#8058 | `3f4b45886` | `git log -S storedRelationshipTarget` | 5 / 2 | it adds `storedRelationshipTarget`, the read door under both spellings, and rewrites the "costs nothing" claim | | objectstack-ai#8060 | `7dc31bb8d`; "step 1 of the card behind `7dc31bb8d`" | `git log --grep`: its subject names "(objectstack-ai#8060)" | 8 / 3 | it carries a stored type the designer cannot author through verbatim (`partitionStoredFields`) instead of flattening it to `text` | | objectstack-ai#3720 (C0) | re-qualified `objectstack#3720` | `ba4514511`'s subject; objectstack#3720's subject | 5 / 3 | see **Premise** | | objectstack-ai#5420 (C0) | own-card pointer dropped (landing `b470e9150`) | the adding commit's subject names "(objectstack-ai#5420)" | 1 / 1 | the only site is its own changeset's heading | | objectstack-ai#5503 (C0, a pull request) | `6f017e99c` | its squash subject ends "(objectstack-ai#5503)" | 1 / 1 | it puts the chart min-height floor on the element Recharts measures | | objectstack-ai#5506 (C0) | re-qualified `objectstack#5506` | nine sibling in-scope lines already cite it for the same strings | 1 / 1 | see **Premise** | | objectstack-ai#5737 (C0, "PR objectstack-ai#5737") | `d1ab06f0f` | its squash subject ends "(objectstack-ai#5737)" | 4 / 4 | it declares `record.*` the row-predicate canon and warns on the two deprecated spellings, which is Phase 1 | | objectstack-ai#6467 (C0) | own-card pointer dropped (landing `5ad0641e0`) | its subject names "(objectstack-ai#6467)" before its own "(objectstack-ai#7332)" | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#6936 (C0) | re-qualified `objectstack#6936` | the line above already cites it | 1 / 1 | see **Premise** | | objectstack-ai#6945 (C0, "PR objectstack-ai#6945") | `2c45966ff` | its squash subject ends "(objectstack-ai#6945)" | 1 / 1 | it declares the 13 renderer-read keys the sentence says objectui#6150 declared first | | objectstack-ai#7622 (C0, "PR objectstack-ai#7622") | `1cca678ba` | its squash subject ends "(objectstack-ai#7622)" | 1 / 1 | it retires the dashboard-root `title` read on all five surfaces | | objectstack-ai#7662 (C0, "PR objectstack-ai#7662") | `bc640ec56` | its squash subject ends "(objectstack-ai#7662)" | 1 / 1 | it is the change to `SchemaRegistry`'s kanban entry the sentence ascribes to objectui#7645 | | objectstack-ai#7684 (C0, "PR objectstack-ai#7684") | "the contract review of `8fe8e5c16`'s pull request" | its squash subject ends "(objectstack-ai#7684)" | 2 / 2 | the review lived on the dead pull request; the sha only locates it | ## Special cases (the judgement calls) 1. **A dead card beside its own live landing.** - `defaults-table-scan.ts`: "rows of objectui#7874 at all (retired in objectstack-ai#7887)" becomes "rows at all (retired in objectstack-ai#7887)". PR objectstack-ai#7887 answers 200 and is `d9580f464`'s pull request. - `7703-chatbot-dark-keys-retired.md`: "**after** objectui#7708's fence landed as PR objectstack-ai#8077" becomes "**after** the fence landed as PR objectstack-ai#8077". In the same file "until objectui#7708 the `chatbot-floating` registration ended…" becomes "until PR objectstack-ai#8077 the…", and the next sentence's "That card was ruled **fence**, not declare, and landed as PR objectstack-ai#8077" becomes "Its card was ruled **fence**, not declare, and landed as that PR", so it keeps an antecedent. - `8871-page-node-refuses-breadcrumbs.md` and `layout.zod.ts`: "corrects objectui#7926's "1 site"", beside "(PR objectstack-ai#8870)", becomes "corrects the `actions` refusal's "1 site"". The changeset's "objectui#7926's `patch` does not transfer here" becomes "The `actions` refusal's `patch` does not transfer here". 2. **The sister-repo numbers.** `[objectstack-ai#3720]` becomes `[objectstack#3720]` at five sites; "objectstack-ai#5506" and "objectstack-ai#6936's" become `objectstack#5506` and `objectstack#6936`'s. See **Premise**. 3. **The card named by role.** - **objectstack-ai#7612**, `clientValidation.ts`: "The switch was then put to the maintainer on objectui#7612" becomes "…on its own card". Nothing landed: the ruling said no, and the switch PR closed unmerged. The verbatim ruling quote 「7612 只需要服务端校验」 stays as the maintainer wrote it; it carries no `#`. - **objectstack-ai#7666**, `7667-toc-emphasis-flanking.md`: "(objectui#7666, a heading `extractToc` lists…)" becomes "(a heading `extractToc` lists…)". The sentence already calls it "a different, already-filed defect". - **objectstack-ai#7682**: "objectui#7682 owns that decision" becomes "a separate card owns that decision" (`7546-chart-series-keys-declared.md`), and "objectui#7682's decision" becomes "a separate card's decision" (`data-display.ts`). - **objectstack-ai#7844**, `8754-…` changeset: "the two further sub-shapes objectui#7844 records" becomes "the two further sub-shapes recorded on their own card". - **objectstack-ai#7804 as the open parent**: "whose disposition is still open on objectui#7804" becomes "…on the handler-key parent card" (`9447-…`); "both are ledgered to objectui#7804, which owns it" becomes "…to the handler-key parent card" (`handler-key-reads-follow-cast-receivers.md`); `crud.zod.ts`'s "objectui#7804's rows are the handler keys" becomes "the handler-key parent card's rows…". - **"The card behind SHA"**, where the sentence rests on something that lived only on the card: - objectstack-ai#7620's ruling A: "following the maintainer's ruling A on objectui#7620" becomes "…ruling A behind `c15d7eca6`" in four `@object-ui/fields` widgets, and `GridField`'s "the split objectstack-ai#7620 ruled on" becomes "the split ruling A settled". `RelatedList.tsx`: "objectui#7443 and objectui#7620 spent two cards" becomes "objectui#7443 and the card behind `c15d7eca6` spent two cards". - objectstack-ai#7708's ruling: "objectui#7708 ruled FENCE" becomes "The card behind `d3499b315` ruled FENCE", and "That ruling was FENCE" after it becomes "The ruling behind it was FENCE" (`complex.ts`). - objectstack-ai#7853: "objectui#7853 ruled…" becomes "The card behind `fa7d66c45` ruled…" in both objectstack-ai#8875 changesets and in `defaults-table-scan.ts`'s list. - objectstack-ai#7959's scope restraint: "objectui#7959 kept/left it off the public entry as scope restraint — that card's file surface was…" becomes "The card behind `36fc74629` …" (`7980-…` changeset, `app-shell` `index.ts`). - objectstack-ai#7980: "see objectui#7980 comment 5583988475" becomes "as the card behind `a810bb2ae` records" (a comment on a dead card resolves nowhere); `PackageFormDialog.tsx`'s "is objectui#7980's surface" becomes "is the surface of the card behind `a810bb2ae`". - objectstack-ai#7704's scope note (`registry.ts`) and objectstack-ai#8060's "step 1" (`MetadataFieldsPage.tsx`) take the same form. - objectstack-ai#7869: the finding card is dead, and the live objectui#8344 discharged it and restates the measurement, so `base.zod.ts` reads "That is the finding objectui#8344 discharged: an off-spec `size`…" and objectstack-ai#8344's own changeset reads "the finding this card discharges measured…". 4. **Rulings by date.** - objectstack-ai#7612: the `AUTHOR_SHAPE_ONLY_TYPES` heading ends "(the 2026-09-20 ruling)"; `10150-author-shape-header-ruling.md` reads "the switch was put to the maintainer, and the 2026-09-20 ruling was option A". Its last sentence, "requires the docblock to name the ruling's card", becomes "…to name the ruling", because the pin it describes now anchors on the ruling (**Special cases** 8). - objectstack-ai#7926: "objectui#7926's maintainer ruling covers `actions`" becomes "The 2026-09-09 maintainer ruling covers `actions`", and "objectui#7926 does not rule on it" becomes "the 2026-09-09 ruling does not cover it" (`layout.zod.ts`). 5. **Own-card pointers that needed a word.** - `7097-grid-2xl-breakpoint.md`: the pointer sat on its own line, so the period moved up with it. - `7678-tombstone-discriminator-agreement.md`: "the site objectui#7678 was filed about" becomes "the site this card was filed about", the file's own wording two lines earlier. - `7804-object-kanban-handler-keys-judged.md`: "its `KNOWN_UNDECLARED_READS` row naming objectui#7804, which stays open and stays the parent" becomes "its `KNOWN_UNDECLARED_READS` row, which names the parent card". - The six `7804-*` slice changesets keep "(the … slice)" once the pointer goes, as batch 4 kept "(slice 2)". 6. **The discriminator form (objectstack-ai#7678).** "in the form objectui#7678 amended it to" becomes "in its amended form (`5f8190c8c`)" at every site; "as amended by objectui#7678" and "amended by objectui#7678" take the same wording; a bare "objectstack-ai#7678" in a precedent list becomes `5f8190c8c`. `mobile.ts`'s "without the precondition objectui#7678 added" becomes "without the precondition the amendment added", whose antecedent is the preamble's "amended form" two sentences up. `9684-discriminator-cited-once.md`: "objectui#7678's amendment had to be applied by hand" becomes "the amendment (`5f8190c8c`) had to be applied by hand", which is what that commit did. 7. **The runtime strings.** Only the listed text moves in each. | file | member | before | after | |:--|:--|:--|:--| | `types/src/zod/complex.zod.ts` | `ChatbotSchema.loading`, `.showAvatars`, `.userAvatar`, `.assistantAvatar`, `.markdown`, `.height` (tombstones) | "RETIRED (objectui#7703, ADR-0049) — …" | "RETIRED (ADR-0049) — …" | | `types/src/zod/complex.zod.ts` | `ChatbotSchema.showAvatars` (tombstone) | "… unfiltered props spread — was fenced by objectui#7708. Delete the key: …" | "… unfiltered props spread — was fenced. Delete the key: …" | | `types/src/zod/layout.zod.ts` | `PageNodeSchema.actions` refusal | "`actions` is not a key of the `page` node and never was (objectui#7926): no renderer reads it, …" | "`actions` is not a key of the `page` node and never was (ADR-0049): no renderer reads it, …" | | `types/src/zod/data-display.zod.ts` | `ChartDataSeriesSchema.variant` `.describe()` | "… the renderer-internal `current` spelling is not a member (objectui#7682)" | "… the renderer-internal `current` spelling is not a member" | **The ADR-0049 condition, measured from the retirement itself** (Zone 1 item 4): the six tombstones already cited `ADR-0049` beside the dead card; the zod comment above them opens "ADR-0049 retirement tombstones"; their landing `a4611b3e2` is titled "retire six dark ChatbotSchema keys as ADR-0049 tombstones"; and the pending `7703-chatbot-dark-keys-retired.md` says "ADR-0049 retirement tombstones". The `actions` refusal is an ADR-0049 tombstone too, measured the same way: its arm is `retirementTombstone(PAGE_ACTIONS_REFUSAL)`, its landing `12b599219` calls it "an ADR-0049 `retirementTombstone` arm", and `7926-page-node-refuses-actions.md` calls it "an ADR-0049 refusal arm". Its string has no `RETIRED` opener, so its own parenthetical becomes `(ADR-0049)`, the spelling its `breadcrumbs` sibling already uses. The TypeScript twins in `complex.ts` read "ADR-0049 RETIREMENT TOMBSTONE — `loading` (`a4611b3e2`)", the comment form. 8. **What follows the text, and nothing else in it** (ruling `5861900779`, route a; ruling `5861129870`). - `chatbot-dark-keys-retired-7703.test.ts` pins the six guidance strings as full literals. Their openings follow to `RETIRED (ADR-0049) — `, the `showAvatars` literal follows "was fenced.", its `prescriptive` anchor `'was fenced by objectui#7708'` becomes `'was fenced.'`, and `toContain('RETIRED (objectui#7703')` becomes `toContain('RETIRED (ADR-0049) —')`. Its test names and `@ts-expect-error` comments still read "RETIRED (objectui#7703)"; they describe the `?: never` TypeScript face and are out of class (**Acceptance notes** 6). - `clientValidation.authorShapeRuling-10150.test.ts` pins that the `AUTHOR_SHAPE_ONLY_TYPES` header names the ruling and `extractDraftBody`. Its subject `'objectui#7612'` becomes `'the 2026-09-20 ruling'`; its message and title are unchanged. - No test, doc or changeset quotes the `actions` refusal or the `variant` description verbatim: a whole-tree search for the old strings returns only the source lines. 9. **The anchor sweep (PR objectui#10875 Special cases 10 shape).** - **Instrument:** every string, template, numeric and regex literal in all 3822 test and script files under `packages/` and `scripts/`, enumerated with `git ls-tree` at head and parsed with TypeScript (113091 distinct literals). - **Test applied to each literal:** does its occurrence count DROP between `b2683a2c0` and head in any file this PR changes, in raw text or in a comment-flattened form? - **Run 1, on `8c267051f`** (the sweep commit, before any test moved): 336 distinct literals drop. Read against the files they sit in, the specific anchors are the two pins in item 8 (the six literals, the `prescriptive` anchor and the `toContain` in the first; `'objectui#7612'` in the second). Also listed and read: the `'objectui#7804'` values of `check-handler-key-read-sites`'s `KNOWN_UNDECLARED_READS` ledger and its test, which assert over the script's own data and never read a changed file, and `tombstone-discriminator-agreement-9684`'s `/RETIRED \(objectui#/`, which it applies to `mobile.ts` alone, untouched here. - **Everything else** is a generic token (whitespace, punctuation, single letters and digits, `objectui#`, character-class regexes of whole-tree scanners), none an assertion over text this PR changed. - **Run 2, on round 0's head `afed8aa6b`:** 327 distinct literals; the nine literals the two pins moved are gone from the drop set, nothing new appears, and the only one left naming a batch number is that ledger value. - **Run 3, patch round 1, over the delta `afed8aa6b..8255f14`:** 18 (literal, file) drops, every one a generic token (`' is'`, `'dropped'`, a `/(\w+):/g` scanner); no test pins the changed refusal text. ## Held **By the serial rule: nothing.** Patch round 1 re-read: 8 open besides this PR (objectui#10896, objectstack-ai#10891, objectstack-ai#10890, objectstack-ai#10889, objectstack-ai#10888, objectstack-ai#10777, objectstack-ai#10278 and the release PR objectstack-ai#5400; objectstack-ai#10886 and objectstack-ai#10714 have left the open list). New since round 0, objectui#10896 shares `plugin-grid/src/ObjectGrid.tsx` and `plugin-list/src/ListView.tsx`; trial merges of this head with every open head are clean except objectstack-ai#10278 (conflicts identical against `main` alone) and the release PR objectstack-ai#5400, which regenerates. The round's one source edit, in `layout.zod.ts`, is held by no open PR. Round 0, re-read before its push: 11 open besides this PR. They are objectui#10890, objectstack-ai#10889, objectstack-ai#10888, objectstack-ai#10886, objectstack-ai#10884, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714, objectstack-ai#10278 and the release PR objectstack-ai#5400. - Five of them hold files this PR edits: - objectui#10890: `types/src/ai.ts`; - objectui#10888: `.changeset/8344-node-recursion-point-redirect.md`; - objectui#10886: `types/src/objectql.ts` and `types/src/zod/objectql.zod.ts`; - objectui#10714: `types/src/data-display.ts`, `types/src/layout.ts`, `types/src/zod/data-display.zod.ts` and `types/src/zod/layout.zod.ts`; - objectui#10278: `plugin-grid/src/ObjectGrid.tsx`. - Each one's hunks were read against its merge-base, with 3 lines of context. **None of the 47 lines this PR changes in those files appears inside or beside any of their hunks.** - Trial merges of each open PR head with this head (`git merge-tree --write-tree`) are clean for objectstack-ai#10890, objectstack-ai#10889, objectstack-ai#10888, objectstack-ai#10886, objectstack-ai#10884, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777 and objectstack-ai#10714. - objectstack-ai#10278 (`eab4c8e52`) conflicts in `ObjectGrid.tsx`, `plugin-grid/README.md` and `content/docs/plugins/plugin-grid.mdx`, and conflicts identically against `main` alone. - PR objectstack-ai#5400 (Version Packages) regenerates and is not a hold. ## Changesets - `.changeset/10803-dead-citation-sweep-fifth-batch.md`, EMPTY frontmatter: the comment-only edits in 15 released packages and the private `@object-ui/test-support`. No published behaviour changes through them. It marks `@object-ui/types` as the package "whose runtime text is declared separately below" (patch round 1) and points at the second file for it. - `.changeset/10803-fifth-batch-runtime-strings.md`, `'@object-ui/types': patch`: the six tombstones open `RETIRED (ADR-0049) —` with everything after the dash unchanged except the `showAvatars` pointer; the `actions` tombstone cites `ADR-0049` in place of its dead card; and the `variant` description loses its pointer. No key, path, issue code, accept set, refusal or severity moves. ## Proof of prose-only (C4), against `b2683a2c0`, on this head `8255f14f4` - **Source.** Each of the 49 touched `.ts` / `.tsx` files (47 non-test sources and the two pins) was parsed at `b2683a2c0` and at this head with TypeScript's `createSourceFile` and re-printed by `createPrinter({ removeComments: true })`. - 44 of 49 prints are identical. - The other 5 are equal once exactly the 19 listed substitutions are applied to the base print, each matched once: `complex.zod.ts` 7 (six openings and the fence pointer), `layout.zod.ts` 1 (the pointer becomes `(ADR-0049)`), `data-display.zod.ts` 1, `chatbot-dark-keys-retired-7703.test.ts` 9 (the same seven, the `prescriptive` anchor and the `toContain` anchor), `clientValidation.authorShapeRuling-10150.test.ts` 1. - 0 parse diagnostics. - Lit controls on the same instrument: dropping "(ADR-0049)" from the `loading` string moves the print; re-spacing the "ADR-0049 retirement tombstones" comment does not. - **Changesets.** The frontmatter block of every one of the 55 edited changesets is byte-identical at `b2683a2c0` and this head (55 of 55, by md5). The overwrite gate below agrees. - **Scope of the diff:** 106 files: 55 edited and 2 new changesets, 47 non-test source files, and 2 tests. ## Gates, on this head `8255f14f4` Each line is the gate's own verdict and exit code, captured by redirect-then-`$?`. - `node scripts/check-changeset-presence.mjs`, exit 0: "48 source file(s) of 15 released package(s) changed, and this change declares 2 changeset(s): .changeset/10803-dead-citation-sweep-fifth-batch.md, .changeset/10803-fifth-batch-runtime-strings.md." (48 = the 46 released sources and the 2 tests under released packages' `src/`; `test-support` is under a package changesets ignores.) - `pnpm changeset:check`, exit 0: "All workspace packages are in the changeset fixed group." / "No changeset declares a `major` bump." - `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2 changeset(s) added, 55 modified, 0 deleted". `declared at base` equals `declares now` for 55 of 55. - `pnpm check:changeset-claims` (report-only), exit 0: - born-false: "Every one of those 2 address(es) either names the tree it was read from, or points at a line this change does not move"; - self-contradiction: "Every package declared across those 45 body(ies) is either not negated in its own prose, or negated only in an ASPECT of it that may legitimately hold still"; - the standing notice "103 pending changeset(s) describe a file this change touches". - Read against the diff: a pending changeset quoting a replaced pointer would itself carry the dead number and so sit in the census, which reads 0. No pending changeset quotes a changed runtime string. - `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned 9145 tracked text file(s); skipped 85 binary)." - `pnpm check:new-line-citations`, exit 0: "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0". - Also run: `pnpm check:pending-changeset-literals`, exit 0: "No test source names a pending changeset."; the governed-surface predicate over the 106 paths, exit 0: "NOT GOVERNED — 106 path(s) checked against 5 governed surface(s); none matched." (lit control `AGENTS.md`: exit 3). **Tests**, through the shared verify lock. - **Red, reproduced first.** The branch-point copies of the two pins were written over the committed sweep tree and run: `Test Files 2 failed (2)`, `Tests 13 failed | 29 passed (42)`, for example "expected 'RETIRED (ADR-0049) — never read: chat…' to contain 'RETIRED (objectui#7703'". Both files were then restored with `git checkout HEAD --`, each checked by blob hash against `HEAD`, and `git diff HEAD` came back empty. - **Patch round 1, on this head `8255f14f4`:** `page-actions-refusal-7926` (it pins the message's remedy words `actions`, `children` and `page:header` and that it is not zod's generic text, never the pointer; verified by reading it), `page-breadcrumbs-refusal-8871`, `guide-layout-page-buttons-7926`, `zod-mirror-parity`, `chatbot-dark-keys-retired-7703`, `clientValidation.authorShapeRuling-10150` and `tombstone-discriminator-agreement-9684` give `Test Files 7 passed (7)`, `Tests 134 passed (134)`, under `VERDICT command-exit 0`. A whole-tree search for "never was: no renderer" finds no test or doc quoting it (only the source line and the runtime-strings changeset, both updated); an anchor sweep over the round's delta finds only generic tokens. - **Green, round 0, on `afed8aa6b`:** `chatbot-dark-keys-retired-7703`, `clientValidation.authorShapeRuling-10150`, `tombstone-discriminator-agreement-9684`, `page-actions-refusal-7926`, `page-breadcrumbs-refusal-8871`, `chart-series-keys-7546`, `zod-mirror-parity`, `chatbot-display-mode-retired` and `schema-registry-chatbot-keys-7704` give `Test Files 9 passed (9)`, `Tests 173 passed (173)`, under `VERDICT command-exit 0`. **Declared narrowing (per the dispatch: the named checks, not wider sweeps).** NOT MEASURED locally: the full suites and type-check of the 15 touched packages, and eslint. Reason: the comment-stripped syntax tree of 44 of the 49 touched files is identical to `main`, and the other 5 differ only by the listed literal edits. Every test that anchors on a changed string or comment was found by the anchor sweep (**Special cases** 9) and run above. CI runs the full farm. ## Acceptance notes 1. **The remainder rides this card, unchanged (seat amendment `5860244997`, Q2 = A).** Of the 53 numbers PR objectui#10875's Acceptance notes 1 lists, this PR carries the first 30 in ascending order, plus the 11 C0 404s of its Acceptance notes 2. The other **23** are: objectstack-ai#8072 objectstack-ai#8127 objectstack-ai#8137 objectstack-ai#8204 objectstack-ai#8229 objectstack-ai#8248 objectstack-ai#8307 objectstack-ai#8408 objectstack-ai#9231 objectstack-ai#9241 objectstack-ai#9244 objectstack-ai#9365 objectstack-ai#9373 objectstack-ai#9375 objectstack-ai#9542 objectstack-ai#9553 objectstack-ai#9585 objectstack-ai#10117 objectstack-ai#10119 objectstack-ai#10120 objectstack-ai#10129 objectstack-ai#10132 #14026. None of them occurs in any hunk of this diff. 2. **The C0 bare numbers above 10900, for later batches** (sites at `b2683a2c0`, lines / files). Each answers 404 as an objectui issue, and none is an objectui citation, so the fix is a re-qualification to objectstack, not a landing sha: - written with a word that names the repository but not in `repo#N` form ("objectstack PR #N", "upstream #N", "framework #N", "spec #N"): objectstack-ai#11289 (2 / 2), #11662 (1 / 1), #12616 (1 / 1), #12718 (1 / 1), #13033 (1 / 1), #13413 (1 / 1), #13733 (1 / 1), #13906 (6 / 3), #14274 (1 / 1), #15469 (2 / 2), #20160 (2 / 2); - written bare: #13337 (1 / 1), #13632 (3 / 3), #13855 (1 / 1), #14945 (1 / 1), #15948 (1 / 1), #17493 (1 / 1), #20051 (1 / 1); - #13033 and #13413 answer 404 in objectstack as well; - not citations: #334155, #336699, #475569, #737373, #953800 (CSS colours). 3. **A live-but-wrong bare number beside a re-qualified one.** `rowCrudAffordances.ts` cites "(`/me/permissions` `apiOperations`, objectstack-ai#3391)" at the two sites that now read `[objectstack#3720]`. objectui#3391 answers 200 with an unrelated subject (a record-header api action placeholder), while objectstack#3391 is the apiMethods whitelist contract card that objectstack#3720's own title names. It is not a 404, so it is outside the family pin and was not touched. Carrier: none. 4. **Published or shipped text outside the two in-scope classes still names some of these numbers** (counts in **Census**). It is untouched by scope, as another class the triage split did not scope here: published `CHANGELOG.md` history (never re-addressed), `content/docs` (for example the chatbot and layout guides), `apps/console` (the approvals inbox and the agent-connect section), `eslint-rules` and `eslint.config.js`, three `skills/objectui` files and `AGENTS.md` (governed). Carrier: none. 5. **Filenames are not citations.** Pending changeset and test FILENAMES carry several of these numbers. They stay, as in PRs objectui#10707, objectstack-ai#10797, objectstack-ai#10854, objectstack-ai#10869 and objectstack-ai#10875. 6. **Test comments left as they are.** `chatbot-dark-keys-retired-7703.test.ts`'s test names and `@ts-expect-error` comments still read "RETIRED (objectui#7703)", and `clientValidation.authorShapeRuling-10150.test.ts`'s header, title and message still name objectui#7612. Only anchors moved (ruling `5861900779`). --- _Generated by [Claude Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 28, 2026
…bject views, detail-view, email, password) and repair the shorthand Omit erasure (objectui#9256) (objectstack-ai#10897) Part of objectstack-ai#9256 Clause-②: yes **Clause-② `yes`, as the claim declared:** twelve published arms stop accepting an authored `children`, and two published TypeScript faces stop erasing the members they inherit. Both narrow an accept set; a contract review is owed before landing. The E3 residual that the maintainer's ruling on objectui#8284 (comment `5861449497`, Q2 A) moved onto this card: keys with a published arm whose renderer reads **neither** content channel. It also carries the ruling's execution parameter 3, the `InputShorthandSchema` / `UiCalendarSchema` TypeScript `Omit` erasure. objectui#9256 stays open for the rest of family D. ## What changed - **Narrowed (12 keys):** `object-grid`, `object-form`, `object-kanban`, `object-map`, `object-tree`, `object-view`, `object-gantt`, `object-calendar`, `object-chart`, `detail-view`, `email`, `password`. - TypeScript face: `body?: never` and `children?: never`, each with a docblock naming what the node renders instead. - zod mirror: `body` and `children` are two `retirementTombstone` members fed ONE string from the new `neitherContentChannelGuidance` builder in `zod/tombstone.zod.ts`. Both stay MEMBERS, so `zod-mirror-parity`'s key sets stay equal. - `body` was already refused on these arms (by `BaseSchema`, objectui#6771), except on the `email` / `password` TypeScript face, which the `Omit` erased. It is restated because `BaseSchema`'s refusal names `children` as the remedy, and `children` is dead here too. - **`Omit` erasure repaired:** `InputShorthandSchema` and `UiCalendarSchema` now inherit through `OmitDeclared` (`form.ts`, not exported). It is a key-remapping mapped type: it drops exactly the named keys and keeps every other named member and the index signature. - `ui:calendar` gains no refusal of its own. Its face now re-exposes what `CalendarSchema` declares, so the published TypeScript face refuses `body`, `children` and a `mode` outside the declared enum, which the erased face accepted. Its mirror (a `.extend()` of that one) already refused them. - I measured the `ui:calendar` renderer anyway (`renderers/form/calendar.tsx`, typed `CalendarSchema`). It reads `defaultValue`, `mode` and `value`, and no channel. - **Held (3 keys): `br`, `hr`, `img`.** See "Held, and the question it leaves" below. ## Per-key measurement, taken on `origin/main` `0c50f1863` before any edit **Instrument.** The TypeScript compiler API, ⛔ not grep. It builds one program per workspace package from that package's own `tsconfig.json`: 40 programs over 1573 source files, on a BUILT tree (turbo build 42/42 first), with `@object-ui/types` resolving to `packages/types/dist`. It files every `.body` / `.children` read (property access, string element access, object destructuring) under the declared type of its receiver. - 547 channel reads were filed. - **Lit controls fire:** `ButtonSchema` 1, `DivSchema` 1, `CardSchema` 1, `ContainerSchema` 1 (each `children`). - **Receiver-reachability control:** the same program sees every narrowed declaration as a receiver of the keys its renderer reads. The zeros below are readings, not blindness. | key | registration(s) claiming it | registration hop → reader, and the type it reads the node as | `body` / `children` reads under that type | receiver reads (reachability) | arm, TS face: before → after | arm, zod face: before → after | disposition | |---|---|---|---|---|---|---|---| | `object-grid` | `plugin-grid:object-grid` (+ console `registerLazy` of the same plugin) | `ObjectGridRenderer` (`any`) → `ObjectGrid` · `ObjectGridSchema` | 0 / 0 | 158 reads, 38 keys | body refused (BaseSchema), children accepted → both refused | same → both refused by name | narrowed | | `object-form` | `plugin-form:object-form` | `ObjectFormRenderer` (`any`) → `ObjectForm` · `ObjectFormSchema` | 0 / 0 | 200 / 44 | same | same | narrowed | | `object-kanban` | `plugin-kanban:object-kanban` (+ lazy) | `ObjectKanbanRenderer` (`any`) → `ObjectKanban` · `ObjectKanbanSchema` | 0 / 0 | 67 / 13 | same | same | narrowed | | `object-map` | `plugin-map:object-map` (+ lazy) | `ObjectMapRenderer` (`any`) → `ObjectMap` · `ObjectMapSchema` | 0 / 0 | 30 / 16 | same | same | narrowed | | `object-tree` | `plugin-tree:object-tree` (+ lazy) | `ObjectTreeRenderer` (`any`) → `ObjectTree` · `ObjectTreeSchema` | 0 / 0 | 13 / 8 | same | same | narrowed | | `object-view` | `plugin-view:object-view` (and the `view` alias) | `ObjectViewRenderer` (`any`) → `ObjectView` · `ObjectViewSchema` | 0 / 0 | 112 / 19 | same | same | narrowed | | `object-gantt` | `plugin-gantt:object-gantt` (+ lazy) | `ObjectGanttRenderer` (`any`) → `ObjectGantt` · `ObjectGanttSchema` | 0 / 0 | 61 / 48 | same | same | narrowed | | `object-calendar` | `plugin-calendar:object-calendar` (+ lazy) | `ObjectCalendarRenderer` (`any`) → `ObjectCalendar` · `ObjectCalendarSchema` | 0 / 0 | 40 / 12 | same | same | narrowed | | `object-chart` | `plugin-charts:object-chart` (+ lazy) | `ObjectChartBlock` (`any`) → `ObjectChart` · `ObjectChartSchema` | 0 / 0 | 123 / 15 | same | same | narrowed | | `detail-view` | `plugin-detail:detail-view` | `DetailViewRenderer` (`any`) → `DetailView` · `DetailViewSchema` | 0 / 0 | 195 / 31 | same | same | narrowed | | `email` | `ui:email` (`field:email` stands down) | `any` wrapper spreads the node into `InputRenderer` · `InputSchema` | 0 / 0 | 23 / 17 | BOTH accepted (erased `Omit`) → both refused | body refused, children accepted → both refused by name | narrowed | | `password` | `ui:password` (`field:password` stands down) | same as `email` | 0 / 0 | 23 / 17 | same as `email` | same as `email` | narrowed | | `br` | `ui:br` | html-elements factory (`any`), void tag: passes `undefined` as the child | reads neither (the one `schema?.children` read is behind the void-tag guard) | n/a (`any`) | body refused, children accepted (family arm) → unchanged | same → unchanged | **held** | | `hr` | `ui:hr` | same | same | n/a | same | same | **held** | | `img` | `ui:img` | same | same | n/a | same | same | **held** | The residual count stays 15: no key reads `children` today. 12 are narrowed and 3 are held. **`any`-typed receivers, attributed rather than assumed.** - Every hop above is `any`-typed. Each hop body was read: none contains a channel read. - The any-typed reads in the eleven hosting files and packages were attributed one by one: - React `children` destructured off internal components' own props (`SchemaRenderer` passes no node child as a React child); - `document.body` and `err.body`; - `TreeNode.children` on the record hierarchy `ObjectTree` builds; - `FeedItem.body`; - `record:alert`'s own `props.body`, which is another registration. - The html factory's `schema?.children` read sits behind `isVoid ? undefined : …`. **Delegation hosts, checked for pass-through.** Every `SchemaRenderer` call in the ten object/detail packages was traced. The node it renders is built one of three ways: - key by key — `ObjectForm` / `ModalForm` / `DrawerForm` / `TabbedForm` / `SplitForm` / `WizardForm` all build their `form` node that way, and the `form` renderer DOES draw `children`, which is why this was checked; - from a sub-key — `DetailView`'s `header` / `footer` / tab `content`, `ObjectChart`'s drill-down table; - or from a generated `object-*` node — `ObjectView` assembles `object-kanban`, `object-calendar`, `object-gallery`, `object-timeline`, `object-gantt`, `object-map`, `object-tree` and `object-chart` from named keys, and every one of those reads neither channel (for gallery and timeline: `packages/plugin-list` and `packages/plugin-timeline` hold no node-channel read). No host spreads its own node into a node that reads `children`. **Generic traversers** (`validateChildren` in core, `sdui-parser` `validateTree`, the metadata-admin preview canvases, the vscode validator) walk children to validate or preview. They render nothing and are node-agnostic, as for every row family D already holds. **objectui#9910 cross-check.** None of the 12 narrowed registrations declares a `children` slot input: a grep over their registration files finds 0 hits, and the lit control is `html-elements.tsx` / `div.tsx`, which do. **Producers.** `pnpm census:body-dialect --keys` over the 15, plus `ui:calendar` and `input`, with `div` / `card` / `page` / `button` / `p` / `h1` as lit controls in the same pass: 8981 files, 2744 candidate nodes. - **0** nodes author `children` on any of the 15. - 1 node authors `body` on `ui:calendar`: it was the family-D TRIPWIRE test line (test bucket), moved by this change. - The controls read `div` 170 / `card` 183 / `page` 47 `children`. - Producers derived: none. Nothing was migrated. ## The `Omit` repair — measured on the BUILT d.ts A probe program under `packages/components` resolved `@object-ui/types` to `packages/types/dist/index.d.ts` (`--traceResolution`). It carried 15 `@ts-expect-error` pins (the 10 object/detail `children`, `email` `children`, `password` `body`, `email` `label: 42`, and the `ui:calendar` `children` and `mode: 'default'`), a lit control (`const n: number = 'x'`), and 12 channel-free controls. - **On this branch:** exit 0 — every directive used, every control compiles, the lit control fires. - **On the base dist:** exit 2 with 15 × TS2578, and the lit control is still used. - The emitted `dist/form.d.ts` declares `OmitDeclared` locally and both heritage clauses use it. ## Red on base, then green — one-shot, the restore proven by state The predictions were written to a file BEFORE the mutation. The mutation was `git checkout 0c50f18 -- THE-SEVEN-DECLARATION-FILES`, with every test file at HEAD. It was proven by 7/7 blob hashes equal to BASE plus anchor counts (`neitherContentChannel` 0, `OmitDeclared` 0). The run sat under `trap … EXIT INT TERM` with absolute paths. | reader | mutated (BASE arms) | restored (HEAD `14fd13c51`) | |---|---|---| | vitest, the new pin file | **RED** exit 1 — 73 failed / 90 passed; exactly the predicted 12 × 5 `children` families + 12 `body`-message rows + 1 nested row | **GREEN** 163 / 163 | | `tsc -p packages/types/tsconfig.test.json` | **RED** exit 2 — 18 × TS2578 and 3 × TS2322 (the `Eq` pins) in the new file, plus 3 in `zod-mirror-parity` naming the two re-collapsed pairs and the stale `KnownDrift` row; 0 elsewhere | **GREEN** exit 0 | | built-d.ts probe (types rebuilt; dist markers 0 → 29 / 6) | **RED** exit 2, 15 × TS2578 | **GREEN** exit 0 | The restore was proven by 7/7 blob hashes equal to HEAD, `git diff HEAD` empty and `git status` clean, both after the restore and at the end.⚠️ **The `body` rows on the ten object/detail arms are GREEN on base, by design:** `BaseSchema` already refused `body` there. Only their MESSAGE changes, and the message rows are the ones that turn red. `?: never` is erased before vitest runs, so the TypeScript half is read by `tsc` alone. The vitest run cannot see it. ## Serial constraints - **Mapped at branch time (`0c50f1863`).** PRs objectui#10714, objectstack-ai#10883 and objectstack-ai#10884 were open then; all three have since merged, and PR objectui#10875 was the base. - `layout.ts` (TabItem) and `layout.zod.ts` (TabItemSchema): untouched, because `br` / `hr` / `img` are held and neither file is edited. - `content-channel-family-d-9256.test.ts`: the only edits are forced ones, clear of PR objectui#10714's hunks, which sit in the ListItem and Tabs sections: - The file's own `ui:calendar` TRIPWIRE said "when the collapse is repaired this line goes RED … turn it back into a `@ts-expect-error` pair". The repair fired it. - The pair moved to the new file. That file lost the tripwire line, its `uiCalendarBody` array entry (32 → 31) and the now-unused `UiCalendarSchema` type import. - No pin was added there. - `objectql.ts`: the insertion after `ObjectViewSchema`'s last member is clear of PR objectui#10883's `NamedListView` docblock edit. - `object-view-unmirrored-keys-7779.test.ts` (PR objectui#10884): untouched. - **Open PRs the branch-time map missed** (re-mapped by contract review `5863631182`): - PR objectui#10890 rewrote the same two `KnownDrift` header figures in `zod-mirror-parity.test.ts` and landed first (`c30c8dd4c`). This branch merged `main` at that commit (merge commit `31bb63bcb`, no rebase, no force-push) and recounted the figures from the merged table; see "Merge round" under Gates. - PRs objectui#10888, objectstack-ai#10889 and objectstack-ai#10892 are textually disjoint, and all three have since merged. `git merge-tree` of the merge head against `main` at `6a7f24e92`, which carries all of them, reports no conflict. - ⛔ `zod/index.zod.ts` and the `packages/cli` ratchet (objectui#10872) are untouched. ## Collateral that the repair and narrowing made true or false — each measured, none widened - **`zod-mirror-parity.test.ts`:** - The two `Omit` COLLAPSE rows (32 + 26 keys) leave `MirroredUndeclared`. Its figures move from 4 / 60 to 2 / 2, and the class note records the emptying. - Restoring the named members NARROWED those faces: a collapsed face accepted every key at `any`. So this is not the "declare the keys" remedy that ledger refuses. - The repaired shorthand face now carries `InputSchema`'s `onChange` runtime slot. It enters `KnownDrift` as inherited drift: one entry, one key. After the merge with PR objectui#10890 (which took `ai.zod.ts#AIFormAssistSchema` out, one entry and two keys), the table holds 49 entries / 88 keys, and both header sites say so. - The union-arm non-vacuity leg had no multi-arm entry left in this ledger. It now takes the same reader's arm-walking on `KnownDrift` and re-arms here when a multi-arm entry lands. - **`object-view-spec-parity.test.ts`:** `body` / `children` are redeclared envelope keys on `object-view` now. They are triaged into `SANCTIONED_LOCAL` as refusal-only surface, like `viewTabBar`, and the declared-surface figure moves 24 → 26. - **`CalendarSchema`'s texts on both faces said the TypeScript `Omit` "collapses … and carries no member".** That became false; they are corrected. - **Two comments** that spelled the old plain-`Omit` heritage (`index.ts`, `form-barrel-mirror-9406.test.ts`) are corrected. - **`scripts/check-handler-key-read-sites.mjs`** caught my first spelling. It was a computed spread (`...helper(…)`) that the gate cannot resolve, so it stopped judging all eleven arms and its `detail-view` `onTabChange` waiver read stale. The fix, the second commit, declares both members explicitly. Now 49 / 49 reads are judged and 0 are left unjudged. ## Held, and the question it leaves `br` / `hr` / `img` read neither channel, but their only published arm is `HtmlElementSchema`: ONE object over 38 tags, whose renderer draws `children` for the other 35 (`p`, `h1`, …). Refusing the key on three tags means splitting that family arm, or refining it per tag. Both change a published contract's shape. - The option the ruling adopted (option A in measurement `5859897857`) reads: "leaving the three void tags to the tier because their arm is the shared HtmlElementSchema family whose per-tag split was ruled out (objectui#9067)". - The parser tier already names them: the registration declares no `children` slot on a void tag, so `validateTree` reports `not-a-container`. - A HELD control in the new pin file records the shared-arm fact, so the hold is visible. That the brief listed them among the keys to narrow is recorded as a conflict in the report, ⛔ not resolved here by guessing. ## Gates (at HEAD `14fd13c51`, exit codes captured by redirect-then-capture; heavy runs through the shared verify lock) | gate | result | |---|---| | `@object-ui/types` build (tsc + vite + dist completeness) | exit 0 — 132 emitted files verified | | `@object-ui/types` `type-check` (`tsc --noEmit` + examples + `tsconfig.test.json`) | exit 0 | | `pnpm exec vitest run packages/types/` (parity, node-slot, arm, mirror, family-D and the new pins) | 259 files / 5670 tests, exit 0 | | `pnpm exec vitest run scripts/` | 177 passed + 2 skipped of 179 files / 5317 tests, exit 0 | | consumer type-check — every package naming a narrowed type (28 packages: the ten object plugins, app-shell, components, core, fields, cli, react, runner, console, schema-catalog, vscode-extension …) | exit 0, 28 × `type-check: Done` | | `pnpm --filter @object-ui/types lint` | 0 errors; 0 findings on any added line (eslint JSON over the 13 touched files) | | `check:control-bytes` · `check:new-line-citations` (0 new) · `changeset:check` · `check-changeset-presence` · `check:changeset-claims` · `check:pending-changeset-literals` | exit 0 each | | `check:doc-types` · `check:doc-snippets` · `check:doc-examples` · `check:skill-examples` · `check:doc-fences` · `check:doc-example-ids` (against the built types) | exit 0 each | | `check:handler-key-reads` · `check:component-surface-parity` · `check:prompt-keys` · `check:registry-bare-names` · `check:spec-symbols` · `check:readme-exports` · `pnpm check` (CLI self-check) | exit 0 each | | governed guard `--test` over the 14 paths | NOT GOVERNED | NOT MEASURED: - `check:sdui-registration-pins` exits 2 without a console build. The diff touches no registration and no `sideEffects` array. Left to CI. - The 4-way `pnpm test` shards beyond `packages/types` and `scripts/`, plus `test:dist` and E2E: left to CI. ### Merge round — head `31bb63bcb` (merges `main` at `c30c8dd4c`) The one conflict was the two `KnownDrift` header figures in `zod-mirror-parity.test.ts`. It was resolved by RECOUNTING the merged table with the test's own AST reader, not by picking a side: | tree | `KnownDrift` | |---|---| | base `0c50f1863` | 49 entries / 89 keys | | PR objectui#10890 removes `ai.zod.ts#AIFormAssistSchema` | −1 entry / −2 keys (48 / 87 on `c30c8dd4c`) | | this branch adds `form.zod.ts#InputShorthandSchema` | +1 entry / +1 key (50 / 90 on `14fd13c51`) | | merged `31bb63bcb` | **49 entries / 88 keys** | The population bullet and the KNOWN_DRIFT restatement both read 49 / 88, and the bullet keeps both histories in landing order. The other ledgers read the same as before: `MirroredUndeclared` 2 / 2, `UnmirroredDeclared` 12 / 84, `RuntimeOnlyDeclared` 3 / 7, `WiderThanDeclared` 6 / 7. The merge head differs from `main` by exactly this PR's 14 files. | gate at `31bb63bcb` | result | |---|---| | `zod-mirror-parity` + `content-channel-e3-residual-9256` | 2 files / 200 tests, exit 0 | | `@object-ui/types` build · `type-check` (incl. `tsconfig.test.json`) | exit 0 · exit 0 | | `pnpm exec vitest run packages/types/` (incl. PR objectui#10890's `ai-zod-arms-10859` / `ai-node-faces-agree-10874` and the family-D file PR objectui#10714 edited) | 261 files / 5696 tests, exit 0 | | `pnpm exec vitest run scripts/` | 177 passed + 2 skipped of 179 files / 5322 tests, exit 0 | | `check:control-bytes` · `check:new-line-citations` · `changeset:check` · `check-changeset-presence` · `check:changeset-claims` · `check:pending-changeset-literals` · `check:handler-key-reads` | exit 0 each | ## Acceptance notes — out of scope, not fixed here - **`input` reads neither channel as well.** `InputSchema`: 0 channel reads, 17 keys read; the registration declares no `children` slot. - It is this card's remaining family-D name, and it was not in this claim. - Its old hold-out ground ("a TS `Omit` carries nothing") is gone with this repair: a tombstone on `InputSchema` now propagates on both faces. - Carrier: the next objectui#9256 slice. - **`PartialSchema`'s docblock in `index.ts`** says every generic re-spelling of its `Omit` collapses for the same `keyof T` reason. `OmitDeclared` is a generic spelling that does not: this PR measures it on two faces. - Carrier: the next objectui#9256 slice, which touches the same `Omit` subject. objectui#6397, that alias's card, is closed. - Noted, not filed. - **The family-D test header** still records `InputSchema` as "family E, frozen" and `DetailViewSchema` as unattributable. Both readings are superseded by this change. - Carrier: the next objectui#9256 slice. - Noted, not edited: PR objectui#10714 held that file while this PR was written. It has since merged, so the next slice edits the header freely. --- _Generated by [Claude Code](https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10867
Clause-②: yes (narrowing). Published
@object-ui/typesmembers narrow: the separator arm ofNavigationItemloseslabel, andAppWizardDraftloseslayout. That makes thisminorplus a BREAKING (authoring) banner, and nevermajor.Dispatched by the
domain:uiseat 2 PM (claim comment 5861866471, triage 5861615446), sessionhttps://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN(mode:subagent, so that id is also this run's). Branchclaude/issue-10867-app-wizard-saves-spec-app, cut fromorigin/mainb93e245f9(BASE); head2c19f3047after fix round 1 (round-0 heade2493c796).What changed
Member 1 — a separator carries only
type,idandorder(the p1).@object-ui/types:NavigationItemis now a union of two arms, discriminated bytype.NavigationEntryItemis the former interface withtypenarrowed to every spec nav type except'separator', and it keeps its requiredlabel.NavigationSeparatorItemadmitstype,idandorder, the spec separator's keys, and every other entry key is?: neveron it. Thoseneverkeys are derived fromNavigationEntryItem, so a key added there is refused on the separator without an edit. Both arms are exported from the package root.menuItemToNavigationItemmaps a legacy separator to{ id, type: 'separator' }and drops its label.spec-derived-unions.test.ts: the blocker-3 pin (_specSeparatorStillHasNoLabel) is lifted. It is replaced by three agreement pins._separatorAdmitsTheSpecKeysand_separatorAdmitsTheSpecInputKeyssay the separator arm admits exactly the spec separator's keys at the output and input tiers._localSeparatorIsSpecValidsays the value types of the keys the arm admits are ones the spec's separator accepts at both tiers.extendsignores extra keys, so the key agreement is carried by the first two: the third alone passes a labelled arm, and it is vacuous on BASE. "Admits" means a key whose type is notnever. The two remaining blockers (visible: boolean, andpinned/defaultOpen) are unchanged, and so is the umbrella verdict.@object-ui/typeszod mirror (fix round 1):NavigationItemSchema's refinement has an explicit separator branch, and it used to return early, soobjectui validatepassed a separatorlabelthat the save door refuses with 422. That branch now refuses every key the spec's separator does not declare, each at its own path, with a message that names the key and the fix ("a separator carries onlytype,idandorder; droplabel"). The allowed set is read off the spec, not restated: the spec does not exportSeparatorNavItemSchema, so it is taken from the separator arm of the specAppSchema's ownnavigationunion. That schema already crosses the mirror's import boundary, so the objectui#8317 population is unchanged. The read throws if the arm is ever missing, instead of silently allowing everything.@object-ui/plugin-designer:AppCreationWizard's "Add separator" andNavigationDesigner's two add paths (now onenewNavItemhelper) write{ id, type }.NavigationDesignerno longer writes alabelonto a new separator, and its label, icon and visibility patchers skip one.@object-ui/layout:resolveNavItemLabelanswers''for every separator. A stored separator carrying a non-emptylabel, whichmenuItemToNavigationItemproduced before this change, used to resolve to that label. No renderer asks it for a separator's label. The mobile bottom nav's leaf list, which already skipped separators, is typed as entries.collectPinnedItemstests the type beforepinned.@object-ui/app-shell:useNavPinsregisters a favorite only for an entry and leaves a separator as it is. The Studio sidebar's navigation walk passes a separator through unchanged.visibleorrequiredPermissionsare typed asNavigationEntryItem. These are in layout'sAppSchemaRendererandresolveHreftests and app-shell'sUnifiedSidebar.derivedAreaVisibilitytest.Member 2 — an edit keeps the stored branding.
EditAppPagenow mergesbrandingone level down, by the objectui#10842 rule. It keeps every stored key the spec'sAppBrandingSchemadeclares, read fromAppBrandingSchema.shape, and the wizard's values win for the keys it maintains. A storedaccentColorsurvives the save. A stored key the spec does not declare is still left out.Member 3 — the Layout control is gone.
AppWizardDraft.layoutis removed. The Basic Info step's Layout fieldset is removed, with its three icons and the draft default.EditAppPageno longer pre-fillslayout. The step description now reads "Name, title, and icon". The fourappDesignerlayout keys are removed fromDESIGNER_DEFAULT_TRANSLATIONSand from all ten locale packs, andappDesigner.stepBasicDescis retranslated in all ten.Text that the change made false:
app.tsmodule header and theNavigationAreadocblock;wizardDraftToAppSchemadocblock;@object-ui/types:NavigationItemand@object-ui/types:NavigationItemSchemaledger reasons inscripts/check-spec-symbol-derivation.mjs(the second now counts four divergences, not five);NavigationAreaSchemadocblock, which listed a separatorlabelamong the keys only the spec refuses;navigation-spec-parity.test.ts: the faces now agree, so it left the divergence list and is asserted as an agreement (both refuse it);Changesets.
.changeset/10867-app-wizard-saves-spec-app.md:@object-ui/typesand@object-ui/i18nminor (removing published pack keys is a narrowing), and@object-ui/plugin-designer,@object-ui/layoutand@object-ui/app-shellpatch, with theClause-②: yesline. The BREAKING (authoring) banner names every consequence, and each was checked against the code at TypeScript 6.0.3 by a throwaway probe:labelinto astringslot fails (TS2322);interface … extends NavigationItemfails (TS2312);NavigationItemfails (TS2300);objectui validaterefuses a separatorlabel;t()on a removed key renders the raw key unless the call passes adefaultValue. The provider-less fallback is the defaults table, thendefaultValue, then the key, and i18next is configured withreturnNull: falseand no missing-key parser.10842-wizard-app-declared-keys.md, titled "the wizard has no layout choice": its "the wizard's layout choice is not saved" has no choice left. Frontmatter md55b8e68791c8bc51ef72179570fd15a1cbefore and after.3162-types-ledger-batch8-verdicts.md: its "three semantic blockers" count. Frontmatter md52ee28f1e1b449ccc2dd97fdcc6c2bc1fbefore and after.Fixture triage:
layoutkey was dropped from theAppWizardDraftfixtures inapp-creation-types,app-declared-keys-10842andapp-logo-one-spelling-10827. These are spelling fixes: the key was there only because the type required it.'layout' in schemaassertion inapp-creation-types"should handle draft with empty navigation" was removed.navigation-model's "should convert a separator" pinned the removedlabel: ''branch, so it was replaced by an exact-shape assertion.label: ''was dropped from separator fixtures innavigation-model, layout'sAppSchemaRenderer.testand app-shell'sphase1-page-blocks.render.test.H1 to H3 (measured on BASE
b93e245f9, installed@objectstack/spec17.4.0)H1 — reproduced. A probe run through
wizardDraftToAppSchema, then the spec'sAppSchema.safeParse:{ id, type: 'separator', label: '' }, gave[{"code":"unrecognized_keys","path":"navigation.1","keys":["label"]}];label: parses green;menuItemToNavigationItem({ type: 'separator', label: 'Section' })gave{"id":"migrated_0","type":"separator","label":"Section"}.The new DOM pin gives the same reading through the real wizard and
CreateAppPageon the base source: "the saved document parses green through the specAppSchema" fails withunrecognized_keys["label"]atnavigation.1.H2 — reproduced. The new pin "a stored
accentColorsurvives the edit round trip" drives the real wizard throughEditAppPage. On the base source it fails: the savedbrandingis{ favicon, logo, primaryColor }, and"accentColor": "#f59e0b"is missing.H3 — census (
git grepover packages, apps, docs, examples, skills and content). Each hit goes or is corrected:AppWizardDraft.layoutand the draft default:app.ts— removed;DEFAULT_DRAFT.layoutinAppCreationWizard— removed;EditAppPage'slayout: appToEdit.layout || 'sidebar'pre-fill — removed;app-layout-*test ids,draft.layoutreads and writes) and its three icon imports — removed.appDesigner.layout,layoutSidebar,layoutHeaderandlayoutEmptyinDESIGNER_DEFAULT_TRANSLATIONSand in ten locale packs — removed;appDesigner.stepBasicDesc("Name, title, and layout") in eleven places — corrected.content/docs/guide/console.mdandconsole-architecture.mddescribe the wizard's four steps and never the Layout control, so they are unchanged.layout: 'sidebar'hits incontent/docs/core/app-schema.mdx,content/docs/guide/schema-overview.md, the runner tests and theAppComponentSchemafixtures areAppComponentSchema.layout, the renderer node's own layout strategy. They are untouched, and the changeset says so.Pins and ablation
New pins:
packages/types/src/__tests__/app-wizard-separator-layout-10867.test.ts: vitest halves, and@ts-expect-error/satisfieshalves run undertsc -p tsconfig.test.json.packages/plugin-designer/src/__tests__/AppWizard.specDocument-10867.test.tsx: drives the realAppCreationWizardthroughCreateAppPageandEditAppPageand reads what reachessaveItem.spec-derived-unions.test.tsagreement pins.packages/types/src/__tests__/nav-separator-mirror-refusal-10867.test.ts.safeValidateSchema, the strict authoring face (StrictAnyComponentSchema) and the mirror itself each refuse a separatorlabel, each at its own path; the mirror also refusesiconandpinnedon a separator. Controls: a bare{ id, type: 'separator' }(and one withorder) is accepted by both faces and the spec, the spec refuses the samelabel, and an entry keeps itslabel.EditAppPagerow, "a logo the author clears saves as cleared, not as the stored value". It is a guard, not a red-on-BASE pin: green on BASE and on HEAD, it fails if a later tidy-up drops empty strings from the merge.Red on BASE. Run from a committed tree: the source files were checked out at BASE, the new pins kept, and everything was restored from
HEADunder a trap. The restore was proven by blob hash equal to HEAD and an emptygit diff HEAD.Tests 8 failed | 6 passed (14). The 8 failures are every non-control row:menuItemToNavigationItem;tsc -p tsconfig.test.jsoninpackages/typesgives the new pins':label);@ts-expect-errorfor a labelled separator and for a draft withlayout);layoutsatisfiesand the two separator-agreement pins).Red before the mirror fix (round 1). From the committed round-1 head, only
app.zod.tswas checked out at the round-0 heade2493c796, under a trap; the restore was proven blob == HEAD andgit diff HEADempty. The new mirror pins plusnavigation-spec-paritygave vitestTests 4 failed | 17 passed (21). The 4 failures are the refusal rows and the new agreement row; the controls passed.Green on HEAD. Round 0, at
e2493c796:Test Files 284 passed (284),Tests 5676 passed (5676). Round 1, at2c19f3047: see Gates. Thepackages/typestsc -p tsconfig.test.jsonhas 0 errors at both heads.Ablation: the separator branch is reverted, and only the separator rows redden. Three anchored mutations went through
ablation-replace.mjs, each proven landed and restored by blob hash:NavigationItemalias gives its separator arm a requiredlabelagain;menuItemToNavigationItemwriteslabelagain;label: ''again.Result:
Tests 3 failed | 11 passed (14). The failures aremenuItemToNavigationItem, "the saved document parses green" and "the saved separator carries onlytypeandid". The branding and Layout rows stay green.tsc -p tsconfig.test.json: 5 errors, all on separator lines. TS2322 ×2 (bare separators), TS2578 ×1 (labelled separator) and TS1360 ×2 (the two agreement pins). The Layout type pin stays green.blob == HEADandgit diff HEADempty for both files.Cross-package reverse check. The downstream type-checks resolve
@object-ui/typesthrough its rebuiltdist. Their first runs went red only on sites the new union refuses: layout 3, plugin-designer 4, app-shell 3 in source plus 4 in tests. They were green after narrowing. That red could only come from the rebuilt declaration.Gates
Fix round 1, at
2c19f3047, all under the verify lock:packages/types/,packages/plugin-designer/andpackages/i18n/:Test Files 356 passed (356),Tests 6861 passed (6861).examples/schema-catalog/test/, the two clivalidatesuites and the three spec-symbol script suites:Test Files 57 passed (57),Tests 2487 passed (2487).NavigationItemSchemaor the app zod mirror, or runssafeValidateSchema/StrictAnyComponentSchemaover an app or navigation document, was found bygit grepand run with per-file verdicts: 34 files, 1251 tests, 0 failed. They includezod-mirror-parity37/37,navigation-spec-parity15/15,imported-defaults-8317124/124,nav-target-exclusivity-856315/15,navigation-model28/28,zod-lazy-getter-identity-791831/31,page-nav-misc-spec-parity44/44,handler-keys-json-refusal-6124336/336, the two app-shell studio-design nav suites 22/22 and 3/3, clivalidate-root-path-line6/6 and the catalogtree-view-nodes-mirror-693922/22.tsc -p packages/types/tsconfig.test.json: 0 errors.@object-ui/typestype-check: 0error TS.@object-ui/plugin-designertype-check, after rebuilding its closure: clean.check-changeset-presence✅;changeset:check✅ (nomajor);check:changeset-claims(report-only) lists 15 pending entries naming a touched file; the six new ones (4895, 6335, 7113, 7735, 7918 and 8871) were read, and none claims anything a separator refusal falsifies;check-changeset-overwrite(report-only): the two dated-note edits;check:pending-changeset-literals✅.check:control-bytesOK,check:new-line-citations0 new,check:spec-symbols✅, the three i18n gates ✅,type-check:coverage✅.Round 0, at
e2493c796unless noted:pnpm exec vitest run packages/types/ packages/plugin-designer/:Test Files 284 passed (284),Tests 5676 passed (5676).pnpm --filter@object-ui/types,@object-ui/layout,@object-ui/plugin-designerand@object-ui/app-shellrun type-check(eachtsc --noEmit && tsc -p tsconfig.test.json; types also runstsconfig.examples.json): verify-lockVERDICT command-exit 0.@object-ui/consoletype-checkafter rebuilding its dependency closure: exit 0, 0error TS.packages/layout/andpackages/plugin-designer/(after the narrowing):Tests 436 passed (436).packages/i18n/, app-shelldefaults-maps-mirror-en-pack,phase1-page-blocks.renderand layoutAppSchemaRenderer, plus thecheck-spec-symbol-derivation,spec-symbol-ledger-anchor-liveness-9537andspec-symbol-ledger-types-7265script suites:Tests 1354 passed (1354).Tests 160 passed (160).check-changeset-presence✅ (5 released packages, 1 changeset);changeset:check✅ (nomajor);check:changeset-claims(report-only): 9 pending entries name a touched file, and each was read — none is falsified;check-changeset-overwrite(report-only): lists the two dated-note edits;check:pending-changeset-literals✅.check:i18n-keys✅,check:i18n-drift✅ ("Every changed en value was followed by all nine translation packs"),check:i18n-designer-parity✅.check:spec-symbols✅;check:control-bytesOK;check:new-line-citations:VERDICT new-cross-file-line-citations: 0 new citation(s);type-check:coverage✅ (43/43);check:test-path-rootsOK;check:vi-mock-specifiers,check:vi-mock-inheritandcheck:vi-mock-override-shapeOK;check:metadata-write-doorsOK;check:unreferenced-sourcesOK;check:handler-key-readsOK..ts/.tsx/.mjsfiles (repo config, inline config honoured): 0 errors and 47 warnings. Each warned file carries the same warning count at BASE, measured by linting the BASE blob through--stdin, so no warning is new. The repo-widepnpm lintis CI's.check:readme-exportsfor the unbuilt@object-ui/cliand@object-ui/plugin-aiREADMEs, which are untouched here. Its judged population read 548 self-imports and 0 fabricated.Serial
of(objectui#10337) #10780, fix(app-shell): PageView refreshes a page action’s data in place on the invalidation bus instead of remounting the page (objectui#10519) #10777, feat(components,types)!: a list item and a tabs item drawcontentonly, and both item faces refusebodyby name (objectui#9590) #10714 and feat(plugin-grid): one display page size read from the spec, and a distinct fetch batch (objectui#9853) #10278, plus the release PR. None of their file lists intersects this diff.origin/mainhas moved tob2683a2c0since BASE.git merge-tree --write-treeagainst it is clean. Of the files main moved, onlyen.tsoverlaps, on other keys. No file main moved mentionsNavigationItem,AppWizardDraftor the removed keys.Acceptance notes
EditAppPage's kept set would make the save succeed silently and lose the author's value. The spec's current loud refusal carries a prescription, so this is left as it is.BrandingConfig.fontFamily.BrandingEditorreads and writes it, and removing it is not a cheap change inside these files.AppComponentSchema.layoutis untouched. It is a different member, the renderer node's layout strategy.navigationfrom the selected objects unconditionally. In edit mode that replaces the stored tree, so separators, groups, URL entries and dashboards are lost on every save. Measured with a throwaway probe throughEditAppPageand the real wizard: a stored[object, separator, group with a dashboard child, url]saved as[object]only.Generated by Claude Code