Skip to content

fix(i18n): a bound action's copy is read from its own object, never from globalActions (objectui#11439) - #11764

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-11439-bound-action-label
Oct 7, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-11439-bound-action-label

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11439

Clause-②: no

What changes

An action's translated copy is read from ONE bundle node, chosen by the object the action belongs to, the way @objectstack/spec 17.7.0 reads it (actionTranslationNode behind lookupActionField). This implements triage's amended ruling on this card (comment 6030552631, amending 5942994297), route B.

  • packages/i18n/src/useObjectLabel.ts, actionSuffixes: a key object reads objects.OBJECT._actions.ACTION.TAIL only. No key object reads globalActions.ACTION.TAIL only. The object-then-global chain objectui#3372 added is gone. The eight action resolvers (actionLabel, actionConfirm, actionSuccess, actionOutcome, actionDescription, actionResultDialog, actionParamText, actionParamOptionLabel) keep their signatures, and their docblocks now state the rule. getAppNamespaces still counts globalActions as an app scope, because object-less actions need it.
  • packages/react/src/hooks/useActionTextLocalizer.ts: the key object is the action's declared objectName, else the host the caller passes. That is what translateObject stamps on an embedded action. It is also what the runtime-side resolvers in useConsoleActionRuntime and RecordDetailView already compute for the description, params and result dialog. No parameter is added: objectName is a spec key the action object already carries.
  • packages/i18n/src/__tests__/useObjectLabel-globalAction.test.tsx: the docblock is corrected. The two bound-action cases (actionLabel / actionSuccess on crm_case / log_call) are re-pointed to the object-scoped copy, each with a comment citing 6030552631. The case "still resolves a globalAction when objectName is omitted" is byte-identical.
  • apps/console/src/preview-samples.ts, the translation sample: close_order, which the action sample binds to sales_order, moves from globalActions.close_order to objects.sales_order._actions.close_order as a { label } node. fields.amount becomes a { label } node.
  • .changeset/11439-bound-action-copy.md: patch on @object-ui/i18n and @object-ui/react.

Behaviour change, in plain words: a bound action's copy filed under globalActions no longer applies, on any of the action's texts. Move it to objects.OBJECT._actions.ACTION. An action with no object still reads globalActions.

No input, export, prop or language-pack key is added.

Dispatch sites measured for the key-object rule

Every caller of useActionTextLocalizer passes its host object and draws actions from that object's own actions array, so a declared objectName there equals the host or is absent:

  • DeclaredActionsBar: its objectName prop. The dispatch stamps that host as objectName.
  • ObjectView, toolbar and row actions: objectDef.name.
  • RecordDetailView, record actions: objectDef.name.
  • RelatedRecordActionsBridge: childDef.name. The dispatch stamps the child object as objectName.
  • record:quick_actions and record:related_list: the context object, or undefined when there is none.
  • page:header: ctx.objectName, with ids resolved against that object's actions.
  • The permission-set clone dispatch in PermissionMatrixEditor: PERMISSION_SET_OBJECT.

None of these files changes. With the localizer reading the declared objectName first, each one already reaches actionSuffixes with the key object. The localizer line changes one case: an action that declares objectName but is drawn where the caller passes no object. It now reads its own object's copy instead of globalActions.

Census of objectui's own bundles

git grep -c globalActions over the tree at 77c12b9, CHANGELOGs excluded, finds one bundle-data hit: the preview sample's close_order, which is bound and moves here. It also serves as the live positive control, since the card's census comment named it. The spec-translations passthrough fixture's globalActions.save names no declared action, so it is object-less and stays. The other hits are resolver code, UI chrome (the TranslationPreview category) and catalogue keys.

Sample parse: TranslationDataSchema from @objectstack/spec/system 17.7.0

  • Before: 2 issues, objects.sales_order.fields.amount: invalid_type and globalActions.close_order: invalid_type.
  • After: success.

The new apps/console/src/__tests__/preview-samples-translation-data-11439.test.ts pins this. In the spec-valid test, the sample stays in KNOWN_STALE for its record-vs-collection question. This PR does not touch that question, and that test's reverse row stays green.

Tests

New pins:

  • In the pin file, "never reads globalActions copy for a bound action": for an action translated only under globalActions, all eight resolvers keyed on crm_case show the authored text. With no key object, they read the global node (control).
  • packages/react/src/hooks/__tests__/useActionTextLocalizer.keyObject-11439.test.tsx:
    • a bound action with only global copy shows its authored text;
    • a bound action with object copy reads that copy;
    • the declared objectName is the key when the caller passes no host;
    • the declared objectName wins over the caller's host;
    • an embedded action keys on its host;
    • an action with no key object reads globalActions.

Ablations. Each went through ablation-replace.mjs. The mutation landing was shown by anchor count and blob hash. The restore was proven by blob equal to HEAD and an empty git diff HEAD. The subjects resolve through vitest's source alias, so no build sits in between.

  1. The old chain restored in actionSuffixes turns 4 pins red: the pin file's "never reads globalActions copy for a bound action" (expected '合并工单' to be 'Merge Cases') and three localizer pins (expected '关闭订单(全局)' to be 'Close Order').
  2. A localizer that ignores the declared objectName turns 2 pins red: "the declared objectName is the key even where the caller knows no object" and "the declared objectName wins over the host the caller passes".
  3. The sample's fields.amount put back as a flat string turns the parse pin red (objects.sales_order.fields.amount: invalid_type).

Local gates

All runs are at HEAD 48858e9, from the worktree root.

  • pnpm exec vitest run --maxWorkers=2 packages/i18n/ packages/react/ plus the action-copy consumers: page-header-action-i18n, page-header-action-ids, record-quick-actions.actionText-i18n, record-quick-actions.resultDialog, RecordRelatedListRenderer.authoredActions-11163, record-alert.resultDialog, DeclaredActionsBar, useConsoleActionRuntime.overrideNotice, and the four console preview-samples-* tests. Result: Test Files 202 passed (202), Tests 2835 passed | 13 skipped (2848).
  • pnpm --filter @object-ui/i18n type-check exit 0 and pnpm --filter @object-ui/react type-check exit 0, after pnpm --filter '@object-ui/react^...' build. Each package's test project lists the touched test (--listFilesOnly).
  • @object-ui/console type-check: NOT MEASURED locally. It resolves every workspace dependency through built dist, so it needs the whole console closure built. It is declared to CI's Type Check job. In its place, a narrowed tsc ran over the six touched source and test files with root paths extended to sources (200 workspace files in the program) and exited 0. A deliberately mistyped control file added to the same program went red with TS2322.
  • pnpm exec eslint on the six touched files: 0 errors. There are no new warnings: the localizer's as any count is 8, as on the base.
  • check:control-bytes, check:test-path-roots, check:changeset-claims, check:pending-changeset-literals, check:new-line-citations (0 new) and scripts/check-changeset-presence.mjs: all exit 0.

Acceptance notes

  • Object-less actions on an object's bar. Such an action now reads that object's scope only, because the host is its key object (ruling rule 1). The retriage found no measured producer.
  • Boundary, noted and not filed: an action that declares an objectName different from the object whose actions array carries it.
    • The localizer keys its label, confirm, success and outcome copy on the declared object, as translateObject does.
    • DeclaredActionsBar, RelatedRecordActionsBridge and the clone dispatch stamp the host as the dispatched objectName, so the runtime-side description, params and result dialog would key on the host.
    • No measured producer writes that shape. Carrier: none.
  • Not this PR:
    • the three objectstack texts that describe objectui's reader as object-scoped first, then globalActions: the action.zod.ts docblock, the globalActions docblock in translation.zod.ts, and packages/spec/liveness/action.json. The landing comment names them for the objectstack domain:spec lane;
    • objectui#11755, the translation designer's object-rendering row. It is graded on its own.
  • Docs: no README or guide page describes the globalActions fallback (git grep over content/, the two package READMEs and skills/), so none changes.
  • origin/main moved to 7b17705 (fix(app-shell): Installed Apps reads a package the runtime refused to load as not loaded (objectui#11645) #11759) after this branch's base. That commit touches none of these files.

Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8


Generated by Claude Code

claude added 3 commits October 7, 2026 04:24
…longer reads globalActions

actionSuffixes reads OBJECT._actions.ACTION.* for a key object and
globalActions.ACTION.* only when there is none, mirroring
actionTranslationNode in @objectstack/spec 17.7.0. useActionTextLocalizer
keys on the action's declared objectName, else the caller's host.

The objectui#3372 pin's two bound-action cases are re-pointed to the
object-scoped copy (triage's amended ruling); the object-less case is
unchanged. The console translation sample files close_order under
objects.sales_order._actions and writes fields.amount as a label node.

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 332 chunks) 3507.8 KB 3551.8 KB
Main entry chunk (gzip) 155.3 KB 350 KB
Entry file index-Ye5Qiah9.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.82KB 6.58KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 578.94KB 139.21KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 235.41KB 65.46KB
fields (index.js) 266.88KB 67.46KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 38.37KB 10.31KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.50KB 11.82KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.39KB 15.52KB
plugin-charts (index.js) 84.26KB 23.05KB
plugin-chatbot (index.js) 199.63KB 47.46KB
plugin-dashboard (index.js) 144.22KB 38.99KB
plugin-designer (index.js) 231.46KB 48.87KB
plugin-detail (index.js) 247.73KB 65.20KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 176.62KB 45.75KB
plugin-gantt (index.js) 179.17KB 45.07KB
plugin-grid (index.js) 238.51KB 65.53KB
plugin-kanban (index.js) 52.17KB 16.37KB
plugin-list (index.js) 116.85KB 29.12KB
plugin-map (index.js) 25.60KB 8.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.10KB 11.81KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 90.64KB 22.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 7, 2026 05:45
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 7, 2026 05:45
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit 92f4e2b Oct 7, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11439-bound-action-label branch October 7, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants