fix(plugin-tree): re-key ObjectTree's record-fetch effect onto dataConfig primitives (#6700)

[os-sales]

Fixes #6700

What

packages/plugin-tree/src/ObjectTree.tsx's record-fetch effect closed over
dataConfig — a useMemo over the schema prop — as a dependency, instead
of the primitive fields it actually reads off it. This is the last
dataConfig-identity dependence left in the component: #6696 already
re-keyed the schema-resolution half onto useSettledSchema's primitive
schemaKey, so this PR closes out the component (not just one effect),
completing the #6592 census for ObjectTree.

Re-derived read set

Scanning the effect body directly (not the issue's suggested list, which
conflated this effect with an unrelated headerObjectName read at
ObjectTree.tsx:503-504 outside this effect) — three primitives:

• dataConfig?.provider — gates both the 'object' and 'value' branches.
• dataConfig.object — read only inside the provider === 'object' branch.
• dataConfig.items — read only inside the provider === 'value' branch.

Before / after deps

- }, [dataConfig, dataSource, schema.filter, objectSchema, schemaSettled, (rest as any).data]);
+ }, [dataProvider, dataObjectName, dataItems, dataSource, schema.filter, objectSchema, schemaSettled, (rest as any).data]);

with the three derived right after the useSettledSchema call:

const dataProvider = dataConfig?.provider;
const dataObjectName = dataConfig?.provider === 'object' ? dataConfig.object : undefined;
const dataItems = dataConfig?.provider === 'value' ? dataConfig.items : undefined;

Mirrors the pattern already shipped for ObjectMap/ObjectCalendar/
ObjectGantt (objectui#6592) — same naming, same shape.

Discard-pin demonstration (ObjectTree.discardedConfigMemo.test.tsx)

Trigger: two schema object literals with identical primitive content but
different references, rerendered in place. ObjectTree's own dataConfig
memo is useMemo(() => getDataConfig(schema), [schema]) — keyed on the
whole schema object — so a reference swap reliably forces a recompute,
which is the same "different identity, same content" observable a genuine
useMemo cache discard would produce with schema held constant.
useSettledSchema's own internal effect is keyed on the derived primitive
schemaKey string (not schema/dataConfig), so this swap leaves
objectSchema/schemaSettled referentially stable and can't confound the
result through that channel.

RED-pre-fix proof (mutation leg of the ablation below): reverted
ObjectTree.tsx to the pre-fix origin/main content, kept the new pin,
rebuilt, and ran it —

AssertionError: expected 2 to be 1 // Object.is equality
- 1
+ 2
 ❯ ObjectTree.discardedConfigMemo.test.tsx:77:47
 Test Files  1 failed (1)
      Tests  1 failed | 1 passed (2)

The discard-proxy test failed (an extra dataSource.find call fired on the
schema-reference swap); the "still refetches for a genuinely different
object" counter-probe passed either way, as expected — that behavior
predates this fix.

Ablation — predicted vs. observed

Leg	Prediction	Observed
Revert fix, keep pin, rebuild	discard-pin RED (extra find call)	RED — expected 2 to be 1
Restore fix (git checkout HEAD -- <path>), rebuild	discard-pin GREEN	GREEN — Tests 2 passed (2)

Restoration proven byte-identical: git diff HEAD empty, git hash-object
match (94ba6dce7… both before and after the mutation leg). Mutation
landing on disk proven by anchored grep -c on the pre-fix deps-array
marker (dataConfig, dataSource, schema.filter → 1 hit) and the post-fix
primitive marker (dataProvider → 0 hits) before rebuilding.

Both legs matched prediction (no direction surprise, unlike #6592's
ObjectCalendar trigger — verified this component's actual [schema]-keyed
memo forces the recompute before trusting the trigger).

Gate table

All commands run from the repo root, exit captured by redirect-then-capture
(never after a pipe), at final commit ee86dc339:

Gate	Command	Verdict
Build (upstream closure)	pnpm --filter '@object-ui/plugin-tree^...' build	exit 0
Build (package)	pnpm --filter '@object-ui/plugin-tree' build	exit 0
Type-check	pnpm --filter '@object-ui/plugin-tree' type-check	exit 0, no output
Vitest (root-level, objectui#3378)	pnpm exec vitest run packages/plugin-tree/	Test Files 6 passed (6) / Tests 22 passed (22)
check:control-bytes	node scripts/check-control-bytes.mjs	✅ OK (scanned 5554 tracked text file(s)...)
Lint (scoped, --format json)	pnpm exec eslint --no-inline-config --format json <2 touched files>	population 2 files (measured from JSON, not assumed); errorCount 0 both files; warnings are pre-existing (@typescript-eslint/no-explicit-any, react-hooks/exhaustive-deps, react-hooks/set-state-in-effect) — confirmed identical rule/count set against the pre-fix source, config carries no parserOptions.project/projectService so type-aware linting is off repo-wide and this diff cannot move any untouched file's verdict
check:changeset-presence	node scripts/check-changeset-presence.mjs	✅ 2 source file(s) of 1 released package(s) changed... declares 1 changeset(s)
check:changeset-no-major	node scripts/check-changeset-no-major.mjs	✅ No changeset declares a major bump.
check:changeset-fixed	node scripts/check-changeset-fixed.mjs	✅ All workspace packages are in the changeset fixed group.

Changeset: patch on @object-ui/plugin-tree, per check:changeset-presence's own verdict.

Fence

packages/plugin-tree only. Did not touch packages/types, app-shell,
plugin-designer (#6527), packages/react/src/utils/visibilityDiagnostic.ts
(#6504), or packages/react's useSettledSchema hook (consumed as-is).

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 49 chunks)	3231.9 KB	3266.6 KB
Main entry chunk (gzip)	157.2 KB	350 KB
Entry file	index-DY-GPSlw.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	11.89KB	4.50KB
app-shell (runtime-config.js)	20.61KB	7.35KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.18KB	10.59KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	509.32KB	115.60KB
core (index.js)	5.30KB	2.13KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	173.10KB	47.96KB
fields (index.js)	239.05KB	60.06KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.44KB	1.39KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	26.89KB	9.04KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	33.40KB	8.71KB
i18n (useSafeTranslation.js)	5.60KB	2.33KB
layout (index.js)	38.95KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.55KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useResponsiveConfig.js)	1.37KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.53KB	3.38KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.64KB	1.50KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	1.93KB	0.88KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.89KB	12.91KB
plugin-charts (index.js)	64.66KB	18.32KB
plugin-chatbot (index.js)	190.33KB	45.10KB
plugin-dashboard (index.js)	133.26KB	34.43KB
plugin-designer (index.js)	212.80KB	43.15KB
plugin-detail (index.js)	245.29KB	62.39KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	132.01KB	32.23KB
plugin-gantt (index.js)	165.20KB	40.37KB
plugin-grid (index.js)	201.51KB	54.54KB
plugin-kanban (index.js)	53.11KB	14.62KB
plugin-list (index.js)	113.01KB	27.57KB
plugin-map (index.js)	20.17KB	6.66KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	43.51KB	11.94KB
plugin-timeline (index.js)	26.44KB	7.59KB
plugin-tree (index.js)	9.00KB	3.08KB
plugin-view (index.js)	85.87KB	21.12KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	65.97KB	21.98KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	2.44KB	1.21KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	20.57KB	5.88KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	10.35KB	3.60KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	2.74KB	1.41KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	4.72KB	2.24KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped