Conversation
Elena-Bruyako
suggested changes
Sep 17, 2026
Elena-Bruyako
left a comment
Elena-Bruyako
left a comment
There was a problem hiding this comment.
fix CI/CD
fix checkstyle
Have you done first Create repo HW?
see comments
Comment on lines
+23
to
+27
| return bookService.getBookById(id); | ||
| } | ||
| @PostMapping | ||
| public BookDto createBook(@RequestBody CreateBookRequestDto bookDto) { | ||
| return bookService.createBook(bookDto); |
There was a problem hiding this comment.
Suggested change
| return bookService.getBookById(id); | |
| } | |
| @PostMapping | |
| public BookDto createBook(@RequestBody CreateBookRequestDto bookDto) { | |
| return bookService.createBook(bookDto); | |
| return bookService.getBookById(id); | |
| } | |
| @PostMapping | |
| public BookDto createBook(@RequestBody CreateBookRequestDto bookDto) { | |
| return bookService.createBook(bookDto); |
| public BookDto getBookById(@PathVariable Long id) { | ||
| return bookService.getBookById(id); | ||
| } | ||
| @PostMapping |
|
|
||
| @Entity | ||
| @Table(name = "books") | ||
| @Data |
There was a problem hiding this comment.
don't use @Data for entities
Suggested change
| @Data | |
| @Getter | |
| @Setter |
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| private String title; |
| import org.example.springbootweb.model.Book; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface BookRepository extends JpaRepository<Book, Long> { |
There was a problem hiding this comment.
you should implement logic by using Session and Transaction
Comment on lines
+8
to
+10
| BookDto createBook(CreateBookRequestDto bookDto); | ||
| List<BookDto> getAll(); | ||
| BookDto getBookById(Long id); |
There was a problem hiding this comment.
Suggested change
| BookDto createBook(CreateBookRequestDto bookDto); | |
| List<BookDto> getAll(); | |
| BookDto getBookById(Long id); | |
| BookDto createBook(CreateBookRequestDto bookDto); | |
| List<BookDto> getAll(); | |
| BookDto getBookById(Long id); |
| spring.datasource.password=password | ||
| spring.jpa.database-platform=org.hibernate.dialect.H2Dialect | ||
| spring.jpa.show-sql=true | ||
| spring.jpa.hibernate.ddl-auto=update |
There was a problem hiding this comment.
Suggested change
| spring.jpa.hibernate.ddl-auto=update | |
| spring.jpa.hibernate.ddl-auto=create-drop |
| @@ -0,0 +1,7 @@ | |||
| spring.datasource.url=jdbc:h2:mem:testdb | |||
There was a problem hiding this comment.
h2 is used only for test purposes
Elena-Bruyako
suggested changes
Sep 21, 2026
| } | ||
|
|
||
| @PostMapping | ||
| @ResponseStatus(HttpStatus.CREATED) // Add status 201 |
There was a problem hiding this comment.
Suggested change
| @ResponseStatus(HttpStatus.CREATED) // Add status 201 | |
| @ResponseStatus(HttpStatus.CREATED) |
Comment on lines
+8
to
+10
| Book save(Book book); | ||
| List<Book> findAll(); | ||
| Optional<Book> findById(Long id); |
There was a problem hiding this comment.
add emtpy lines between methods
check your checkstyle (looks like don't work properly)
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
this is wrong file
come back to the first HW (Create repo) and find correct version of the checkstyle file
if you have some issues - ask in chat
Elena-Bruyako
left a comment
Elena-Bruyako
left a comment
There was a problem hiding this comment.
Please, open Spring Boot Intro lesson -> Create a Repo and read requirements
Aslo, fix CI/CD
See this section in Create a Repo task
Create a .github directory (pay attention to the folder name, it should start with . (dot)) in your project root directory. Inside this directory create a new directory workflows. (as an example please see [this project's](https://github.com/mate-academy/hibernate-relations-hw) structure)
Inside the workflows directory create a new file ci.yml and paste this code into it:
name: Java CI
on:
- push
- pull_request
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'temurin'
cache: maven
- name: Build with Maven
run: mvn --batch-mode --update-snapshots verify
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0"?> | |||
| <!DOCTYPE module PUBLIC | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.