Compatibility with OCaml 5.5 - #75
Merged
shindere merged 4 commits intoAug 12, 2026
Merged
Conversation
|
Hi @thierry-martinez. The fork you created when working on this seems to have overwritten the old repo and since the fork does not contain any releases it's no longer possible to |
Member
Author
|
Oops, thank you for pointing this out, @danielfl-iar! I've mirrored all the releases from ocamllibs/stdcompat in the fork, so the broken URLs should now be fixed. |
Collaborator
|
Many thanks for the impressive work and sorry for my delayed response, I
completely missed this!
I am wondering whether you want to keep the commit history as it
currently is?
My impression is that most of these 15 commits could be squashed into
one, just to make sure a bisection wouldn't reach a commit that does not
compile. Am I correct that currently some intermediary states of the PR
do not compile, actuallly?
I was also unsure about the commit "Check newer versions in
`check-generated-files`", and the head commit of your branch should I
think mention 5.5 rather than 5.6?
|
thierry-martinez
force-pushed
the
compatibility_with_OCaml_5.5
branch
2 times, most recently
from
August 12, 2026 13:54
6a910ba to
7ffee16
Compare
thierry-martinez
force-pushed
the
compatibility_with_OCaml_5.5
branch
from
August 12, 2026 13:59
7ffee16 to
96ae056
Compare
Member
Author
|
Sorry for the messy Git history! I've rebased it to clean it up. Each of the four commits should now work independently. |
shindere
approved these changes
Aug 12, 2026
Member
Author
|
Thank you, @shindere, for your approval! Which merge method should we prefer: rebase, squash, merge commit? |
Collaborator
|
This looks very nice to me, thanks.
I just approved and, since all check pass I am now merging.
Would you like me to release?
|
Member
Author
|
It would be great to make a release! Tell me if I can help. Thanks! |
Collaborator
|
Oops sorry if I went too fast on this. Ijust kept the default, which I
believe to be sane in the sense that the branch gets merged as-is, wich
will let you delete it with `gib branch -d` if you so wish, as Git will
be able ot notice that the branch got merged exactly as-is.
Are you happy with this way of doing? If not I guess we can always
revert, or even force-push backward. Or we can leave things as they are
and do differently in the future.
|
Collaborator
|
thierry-martinez (2026/08/12 07:32 -0700):
thierry-martinez left a comment (ocamllibs/stdcompat#75)
It would be great to make a release! Tell me if I can help. Thanks!
I'll give it a try and see how rusty I am at it. I'lllet you know in any
case.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.