Conversation
|
Thanks for the contribution! Before we can merge this, we need @liyimil to sign the Salesforce Inc. Contributor License Agreement. |
Contributor
|
Closed and re-opened to re-evaluate the CLA. |
Contributor
|
@liyimil , this looks like it resolves the issue where you needed to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
execute()'sdirwith partialloadOptionsignoreManifestdirplus{ignoreManifest: true}Why
Passing
loadOptionscurrently replacesdirentirely, so inferred values such asrootare lost. Supplying onlyignoreManifestthen reaches the loader without a root and fails before the option can take effect.Fixes #1533.
Checks
yarn compile --noEmittest/execute.test.tsyarn lint(passes with existing warnings)Prepared with Codex assistance; the diff was reviewed and the checks above were run locally.