lwt_pool: fix starvation bug - #1121
Merged
Merged
Conversation
… and no new thread try to use the pool
raphael-proust
previously requested changes
Jul 10, 2026
raphael-proust
self-requested a review
July 11, 2026 20:26
raphael-proust
dismissed
their stale review
July 11, 2026 20:28
gh interface is stupid, i can't find a way to approve the more recent changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUG] Pool waiters starve when in-use members fail and there are no new pool use attempts.
Lwt_pool.use has two failure paths, but only one wakes waiters:
Waiters can only be woken by a
releaseorreplace_disposed. If all members are disposed via the failed-use path (2) and there are waiters because of pool oversubscription, they sleep indefinitely.