Refactor - #3
Open
ultrasound1372 wants to merge 4 commits into
Open
Conversation
…es and grave 0 hacks to the root dict as phoneme strings and some left alone as word replacements. Progress haulted for now at line 182 of legacy dict.
… at line 288. * Fixed up spelling in the hertz regexps, and accounted for a scenario with which they might not be triggered. * removed parenthetical detection entries for now, in the add-on code they will be reimplemented in a regular expression form and will change pitch relative to the current rather than static. Some people use their eloqs at different pitches. * changed add-on file naming structure such that you may use both eloquences without things breaking because of the duplicate ad-on. They may be freely switched between each other, and to reload a root all you must do is open the synth dialog and select eloquence (yates) again. This is primarily done for testing purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch aims to begin the process of refactoring most of the pronunciations from the dictionary file into the root dictionary so they do not rely on ultraeloquence hacks to properly render SPRs.