fix(clipsync): resolve July 2026 audit issues - #36
Merged
Conversation
- Fix formatting failure in clipsync/ui.py - #26: refuse Syncthing signature verification when gpg is absent - #25: only update _last_synced after successful clipboard/file writes - #24: store encryption passphrase in OS keyring or encrypted fallback - #33: stop logging clipboard content in heartbeat debug lines - #32: clean up temp files on failed atomic clipboard writes - #31: build macOS autostart plist with plistlib - #30: safely decode non-UTF-8 watchdog paths - #29: bound received-file deduplication set with LRU OrderedDict - #28: try wl-paste when xclip fails on Linux image clipboard - #27: already fixed; regression test passes - Expand CI matrix to ubuntu-latest, macos-latest, windows-latest
- Use full settings path as secure storage namespace so multiple Settings instances in the same directory do not share a passphrase. - Install and start xvfb on Linux runners so pystray imports work headless. - Disable mypy warn_unused_ignores so platform-specific type: ignore comments do not break the Windows runner.
- Skip tests/integration in CI; they require xclip and a real clipboard. - Add type: ignore comments to Unix-only fcntl and SIGKILL usage so mypy passes on Windows runners.
- Use getpass.getuser() in the machine-secret fallback; os.getlogin() fails in headless CI environments. - Decode watchdog byte paths with surrogateescape so Windows (and any platform) does not crash on non-UTF-8 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining July 2026 audit issues (#24-#33) and fixes the current CI formatting failure. Expands CI to run on Ubuntu, macOS, and Windows.