chore(deps): update dependency typescript to v6 - #18
Merged
Conversation
Bump TypeScript from `^5.9.3` to `^6.0.3`. TypeScript 6 deprecates the `false` settings for `esModuleInterop` and `allowSyntheticDefaultImports`; both will stop functioning in TS 7. Drop those two lines from `tsconfig.json` rather than carry an `"ignoreDeprecations": "6.0"` escape hatch: - `verbatimModuleSyntax: true` is already set, which forbids the synthetic-default import patterns these flags were guarding against. Whether `esModuleInterop` is `false` (old TS default) or `true` (new TS 6 default), `verbatimModuleSyntax` enforces the same import discipline at the source level, so the runtime/emit behavior of this package's code is unchanged. - Removing the explicit values lets the project track each TS major's defaults without further changes when TS 7 lands. Verified locally on TS 6.0.3: `pnpm typecheck`, `pnpm lint`, `pnpm test` (2169/2169), and `pnpm build` all pass. Supersedes #14. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s TypeScript toolchain to TypeScript 6, and cleans up tsconfig.json by removing two compiler flags that are no longer needed given the project’s current module/interop constraints.
Changes:
- Bump
typescriptfrom^5.9.3to^6.0.3. - Remove explicit
esModuleInterop/allowSyntheticDefaultImportssettings fromtsconfig.json. - Regenerate
pnpm-lock.yamlto reflect the TypeScript update across the root workspace tooling.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsconfig.json | Removes explicit interop/import flags to rely on TS defaults under TS 6. |
| package.json | Updates the root workspace devDependency to TypeScript ^6.0.3. |
| pnpm-lock.yaml | Updates lock entries to TypeScript 6.0.3 for root tooling and peers. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
49
to
+56
| specifier: ^0.22.0 | ||
| version: 0.22.0(oxc-resolver@11.19.1(@emnapi/core@1.10.0)(@emnapi/runtime@1.10.0))(typescript@5.9.3)(unrun@0.2.37) | ||
| version: 0.22.0(oxc-resolver@11.19.1(@emnapi/core@1.10.0)(@emnapi/runtime@1.10.0))(typescript@6.0.3)(unrun@0.2.37) | ||
| typedoc: | ||
| specifier: ^0.28.19 | ||
| version: 0.28.19(typescript@5.9.3) | ||
| version: 0.28.19(typescript@6.0.3) | ||
| typescript: | ||
| specifier: ^5.9.3 | ||
| version: 5.9.3 | ||
| specifier: ^6.0.3 | ||
| version: 6.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^5.9.3to^6.0.3esModuleInterop: falseandallowSyntheticDefaultImports: falsefromtsconfig.json(both deprecated in TS 6, removed in TS 7)Why drop the two flags rather than
ignoreDeprecations: "6.0"?verbatimModuleSyntax: trueis already set intsconfig.json, which forbids the synthetic-default import patterns thatesModuleInterop=false/allowSyntheticDefaultImports=falsewere defending against. WhetheresModuleInteropresolves tofalse(TS 5 default) ortrue(TS 6 default),verbatimModuleSyntaxenforces the same source-level import discipline, so the runtime/emit behavior ofxlsx-kitis unchanged. Removing the explicit values means the project will keep tracking each TS major's defaults without another tsconfig nudge when TS 7 arrives.Verified locally on TS 6.0.3
pnpm typecheck— cleanpnpm lint— 0 warnings, 0 errorspnpm test— 2169/2169 passedpnpm build— completes with no warnings beyond the existing tsdownexternaldeprecation noticeTest plan
staticandtest (22|24|26)jobs are green onmain🤖 Generated with Claude Code