[ENG-925] removed encounter_class_history field - #3743
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe encounter class history field is removed from persistence and encounter API handling. Encounter class changes are rejected during updates. Administration exports and test fixtures no longer reference the removed field. ChangesEncounter class history removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change removes the encounter class history field without any actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3743 +/- ##
===========================================
- Coverage 79.63% 79.62% -0.01%
===========================================
Files 482 482
Lines 23282 23279 -3
Branches 2427 2427
===========================================
- Hits 18540 18537 -3
Misses 4140 4140
Partials 602 602 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Proposed Changes
encounter_class_historyfield from EncounterMerge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins
Summary by CodeRabbit