fix(client): let the section sidebar nav scroll when it overflows - #34
Open
yyyr-p wants to merge 1 commit into
Open
fix(client): let the section sidebar nav scroll when it overflows#34yyyr-p wants to merge 1 commit into
yyyr-p wants to merge 1 commit into
Conversation
The sidebar's nav list had no height constraint or scroll behavior, so on short windows (or with the repository settings section expanded) items past the visible area were clipped by the aside's overflow-hidden and unreachable. Give the nav flex-1, content-start, and overflow-y-auto so it fills the remaining height and scrolls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the shared section sidebar's nav list scroll when it overflows: give it the height remaining after the header, keep rows top-aligned, and let overflow scroll instead of being clipped by the sidebar's
overflow-hidden. This fixes nav items (for example the repository settings entries) becoming unreachable on short windows or at high display scaling, and applies to everySectionSidebarconsumer (repository, account, and team pages).Validation
pnpm typecheckpnpm --filter @oh-my-github/client build