fix: create-project writes inside the chosen directory on Windows - #309
Open
tonycoder-hub wants to merge 2 commits into
Open
fix: create-project writes inside the chosen directory on Windows#309tonycoder-hub wants to merge 2 commits into
tonycoder-hub wants to merge 2 commits into
Conversation
Handlebars treats \{{ as an escaped literal, so compiling a Windows
fsPath turned empty-ability\{{moduleName}} into a sibling folder
named empty-ability{{moduleName}}. Compile the relative POSIX path
instead so the module lands inside the chosen save path.
Fixes ohosvscode#219
Co-authored-by: Tony Coder <407243179@qq.com>
The vite-plus test runner polyfills node:path without win32, so assert
the compiled relative path and the Handlebars \\{{ escape directly.
Co-authored-by: Tony Coder <407243179@qq.com>
🦋 Changeset detectedLatest commit: 6c449d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 219.
On Windows, Handlebars escaped the template path so the new module was written as a sibling of the chosen directory.
The fix compiles only the path relative to the template root, then resolves it against the save directory.
lint passed