fix: resolve UIDesignKit titleBar after hmsPath is set - #310
Open
tonycoder-hub wants to merge 2 commits into
Open
fix: resolve UIDesignKit titleBar after hmsPath is set#310tonycoder-hub wants to merge 2 commits into
tonycoder-hub wants to merge 2 commits into
Conversation
HMS kit barrels resolved once hmsPath was configured, but nested @hms.* re-exports and ets/component attribute types (HdsNavigation.titleBar) were never indexed. Recursively map HMS api/kits/arkts declarations and include HMS component libs. Co-authored-by: Tony Coder <407243179@qq.com>
Co-authored-by: Tony Coder <407243179@qq.com>
🦋 Changeset detectedLatest commit: d7312e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 306.
After ets.hmsPath is set, @kit.UIDesignKit already resolved, but chained exports such as .titleBar on HdsNavigation stayed unresolved.
HMS kit barrels re-export those symbols from nested @hms modules, and the attribute types live in HMS ets/component. Neither was indexed.
Fix: recursively map HMS ets/api, ets/kits, ets/arkts; add HMS wildcards; include HMS ets/component in lib. Scoped to this bug, not issue 291. lint and tests passed.