fix: show a friendly dialog when SDK download is cancelled - #312
Open
tonycoder-hub wants to merge 2 commits into
Open
fix: show a friendly dialog when SDK download is cancelled#312tonycoder-hub wants to merge 2 commits into
tonycoder-hub wants to merge 2 commits into
Conversation
Treat abort/cancel errors from sdk-downloader as cancellation instead of showing the raw "下载错误" toast, and stop the install pipeline so SHA256 and extract do not continue after cancel. Co-authored-by: Tony Coder <407243179@qq.com>
Satisfy regexp/no-unused-capturing-group from eslint. Co-authored-by: Tony Coder <407243179@qq.com>
🦋 Changeset detectedLatest commit: ab1e1b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 64.
After the HTTP stream starts, abort was wrapped as DownloadError, so cancel looked like a failed download and SHA256/extract could continue.
Detect cancel, show sdk.install.cancelled, stop the install pipeline. lint and 52 tests passed.