fix: keep menu available when device discovery fails - #153
Open
Ha1baraA11 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Opening MiniSim can fail when
xcrun simctlis unavailable. The failure is surfaced as a ShellOut error and prevents the menu from opening.This change keeps MiniSim usable when device discovery for one platform fails, and makes the iOS setup check validate the actual
simctlcommand instead of only checking whether/usr/bin/xcrunexists.Changelog:
xcrun simctlduring iOS setup checks.Test Plan:
xcodebuild -scheme MiniSim -configuration Debug -sdk macosx -derivedDataPath /tmp/minisim-derived -clonedSourcePackagesDirPath /tmp/minisim-packages build CODE_SIGNING_ALLOWED=NOxcodebuild test -scheme MiniSim -destination 'platform=macOS' -derivedDataPath /tmp/minisim-derived -clonedSourcePackagesDirPath /tmp/minisim-packages CODE_SIGNING_ALLOWED=NOgit diff --checkAll tests passed.
Manual reproduction is environment-dependent because it requires an unavailable or misconfigured Xcode
simctlinstallation. The reported failure is documented in #150.