Skip to content

fix(types): preserve projector_info on ShowResponse #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seethinajayadileep wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(types): preserve projector_info on ShowResponse #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ollama/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,9 @@ class ShowResponse(SubscriptableBaseModel):

modelinfo: Optional[Mapping[str, Any]] = Field(alias='model_info')

projector_info: Optional[Mapping[str, Any]] = None
'Projector metadata for multimodal models (when present in /api/show).'

parameters: Optional[str] = None

capabilities: Optional[List[str]] = None
Expand Down
27 changes: 27 additions & 0 deletions tests/test_type_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,30 @@ def test_create_request_serialization_license_list():
request = CreateRequest(model='test-model', license=['MIT', 'Apache-2.0'])
serialized = request.model_dump()
assert serialized['license'] == ['MIT', 'Apache-2.0']


def test_show_response_preserves_projector_info():
"""/api/show may include projector_info for multimodal models."""
from ollama._types import ShowResponse

payload = {
'modelfile': 'FROM llava',
'template': '{{ .Prompt }}',
'parameters': 'num_ctx 4096',
'details': {
'parent_model': '',
'format': 'gguf',
'family': 'llama',
'families': ['llama'],
'parameter_size': '7B',
'quantization_level': 'Q4_0',
},
'model_info': {'general.architecture': 'llama'},
'projector_info': {'clip.projection_dim': 768},
'capabilities': ['completion', 'vision'],
}

response = ShowResponse.model_validate(payload)
assert response.projector_info == {'clip.projection_dim': 768}
dumped = response.model_dump()
assert dumped['projector_info'] == {'clip.projection_dim': 768}