add RFC-4 review 3b

[kevinyamauchi]

This adds the Dave Horsfall's review of RFC-4 (accept!).

cc @davehorsfall

[github-actions]

Automated Review URLs

• Readthedocs

[kevinyamauchi]

@joshmoore , as this is the second "accept" review and there are no other pending reviews, should I also update the status on the RFC-4 page and the table on the RFCs page? If so, does that mean the status is "S1 RFC accepted"?

[kevinyamauchi]

Also, I took the liberty of fixing a couple of markdown issues in the original Review 3 (39ed95a, 2a29b28). I'm not sure if that text is allowed to be edited, so let me know if I should revert.

[lubianat]

@joshmoore , as this is the second "accept" review and there are no other pending reviews, should I also update the status on the RFC-4 page and the table on the RFCs page? If so, does that mean the status is "S1 RFC accepted"?

As a comment, it is hard to say if there are any reviews pending (in terms of automatic status; #552) and if two initial implementations exist (as moving to S1 technically requires two initial implementations).

I wonder if we should have a new category "Implementations", where implementers share a document reporting on current status and future plans for implementation for a particular RFC

[joshmoore]

Thanks, @kevinyamauchi. Correcting other comments/reviews is also appreciated. Yes, please update the status if you don’t mind. I do believe that “S1” is now the correct status 🎉

[kevinyamauchi]

Thanks for the feedback! I have updated the status. I believe this is ready for review

[lubianat]

lgtm!

[lubianat]

(merged main into it, there was a conflict)

[lubianat]

Thank you, @kevinyamauchi! Merging.

Note that a new way to encode status is cooking in #552, hopefully simpler

[lubianat]

I think this status bump is worth a note on https://forum.image.sc/t/ngff-weekly-dev-update-thread/!

@kevinyamauchi @thewtex does anyone want to do the honours?

[kevinyamauchi]

I think this status bump is worth a note on https://forum.image.sc/t/ngff-weekly-dev-update-thread/!

@kevinyamauchi @thewtex does anyone want to do the honours?

Exciting! Great point, @lubianat . I think @thewtex should do it as he's the author (if he wants). I'm just the shepherd 😉

[thewtex]

Thanks all — and especially @davehorsfall for the review, @kevinyamauchi for shepherding the RFC and incorporating the review updates, and @lubianat and @joshmoore for the status discussion and merge!

I will add an update to the NGFF weekly development thread 👍.