dynamically load required schemas from - #86
Open
will-moore wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests the various schemas served from ome/ngff#581
Once that is merged, we can update the
baseUrl = "https://ngff--581.org.readthedocs.build..."in this PR.Instead of using a hard-coded list of schemas needed, we now parse each schema in turn and find all the
$ref.startsWith("0.6").&schemas=https://ngff--581.org.readthedocs.build/0.9.dev1/schemas/To test:
This
0.6dev4sample loads the appropriate version of the schema and validates correctly https://deploy-preview-86--ome-ngff-validator.netlify.app/?source=https://livingobjects.ebi.ac.uk/idr/zarr/test-data/v0.6.dev4/idr0050/4995115_output_to_ms.zarr/4995115_cropped_700_700_400_400_rot45.zarr. Previously, that schema loaded a0.6rc0schema and failed validationIf we specify a particular schema, e.g.
0.9.dev1, we can see expected failures https://deploy-preview-86--ome-ngff-validator.netlify.app/?source=https://livingobjects.ebi.ac.uk/idr/zarr/test-data/v0.6.dev4/idr0050/4995115_output_to_ms.zarr/4995115_cropped_700_700_400_400_rot45.zarr&schemas=https://ngff--581.org.readthedocs.build/0.9.dev1/schemas/A sample v0.9.dev1 image https://deploy-preview-86--ome-ngff-validator.netlify.app/?source=https://livingobjects.ebi.ac.uk/idr/zarr/test-data/v0.9.dev1/idr0079_XZYC.ome.zarr which validates with v0.9.dev1 schemas
NB: we have some workaround for
$ref: axes.schemaas described at ome/ngff#581 (comment)