New tag component - #100
Merged
Merged
Conversation
Genarito
requested changes
Jul 14, 2026
| }) | ||
| } | ||
|
|
||
| updateBiomarkerTag = async ( |
Member
There was a problem hiding this comment.
Dos correcciones sobre esta función:
- Documentala con JSDocs como hacemos con todas las demás.
- Pasalo a promises en vez de async/try/catch. Pedile a cualquier LLM que te haga la conversión. Pero estamos haciendo así en todo el proyecto, prefiero que no quede mixto. Después voy a ver si puedo agregar una regla de ESLint para que advierta sobre esto
| .finally(() => setLoadingTags(false)) | ||
| } | ||
|
|
||
| // Fetches all the Tags as soon as the component is mounted |
Member
There was a problem hiding this comment.
Poner como JSDocs (es decir, con la sintaxis /** ... */). De esa manera los IDEs pueden renderizarla cuando se le hace hover con el mouse
| setNewTag(getDefaultNewTag()) | ||
| } | ||
|
|
||
| // Keeps the internal selection in sync if the parent updates the Tag from outside |
Member
There was a problem hiding this comment.
Idem comentario anterior sobre JSDocs
| } | ||
|
|
||
| // Keeps the internal selection in sync if the parent updates the Tag from outside | ||
| // while the panel is closed (e.g. after a refresh of the underlying data) |
Member
There was a problem hiding this comment.
Idem comentario anterior sobre JSDocs
| handleClose() | ||
| } | ||
|
|
||
| // Discards any pending change made during this opening of the Dropdown |
Member
There was a problem hiding this comment.
Idem comentario anterior sobre JSDocs
| }) | ||
| } | ||
|
|
||
| // Sends the request to create or update a Tag and selects it as soon as it's saved |
Member
There was a problem hiding this comment.
Idem comentario anterior sobre JSDocs
Genarito
requested changes
Aug 1, 2026
| } | ||
| ).then((response) => { | ||
| response.json<Biomarker>().then((updatedBiomarker) => { | ||
| console.log('Respuesta del backend:', updatedBiomarker) |
Member
There was a problem hiding this comment.
Borrar todos los console logs que se hayan agregado de testing
| render () { | ||
| const { intl } = this.props | ||
| const { openSelectOptionModal, selectedOption } = this.state | ||
| const tagOptions: DropdownItemProps[] = [ |
Member
There was a problem hiding this comment.
Podemos seguir mejorando:
- Mover esta transformación de Tags a
DropdownItemProps[]dentro del componente. - Adecuar el nombre de la prop para que, en vez de llamarse
tagOptionsse llame simplementetags, y cambiar el tipo para que seaDjangoTag[].
De esta manera seguimos reduciendo código, y encima el día de mañana, si tenemos que cambiar la estructura que devuelve el map, solo cambiaríamos una función en un componente y no múltiples.
Genarito
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.