Feature/user search - #102
Merged
Merged
Conversation
Genarito
requested changes
Aug 1, 2026
|
|
||
| experiment = get_object_or_404(Experiment, id=experiment_id) | ||
| if not can_edit_shared_resource(experiment, request.user): | ||
| return Response( |
Member
There was a problem hiding this comment.
En vez de devolver un Response con 403, hacer un raise PermissionError("You do not ...") para que DRF lo ataje nativamente sin tanto verbose
| ) | ||
|
|
||
| biomarker = get_object_or_404(Biomarker, id=biomarker_id) | ||
| if not can_edit_shared_resource(biomarker, request.user): |
| biomarker = get_object_or_404(Biomarker, id=biomarker_id) | ||
| if biomarker.user.id != request.user.id: | ||
| if not can_edit_shared_resource(biomarker, request.user): | ||
| return Response( |
| biomarker = get_object_or_404(Biomarker, id=biomarker_id) | ||
| if biomarker.user.id != request.user.id: | ||
| if not can_edit_shared_resource(biomarker, request.user): | ||
| return Response( |
|
|
||
| biomarker = get_object_or_404(Biomarker, id=biomarker_id) | ||
| if not can_edit_shared_resource(biomarker, request.user): | ||
| return Response( |
| """REST endpoint: delete for StatisticalValidation model.""" | ||
|
|
||
| def get_queryset(self): | ||
| if self.request.method == 'GET': |
Member
There was a problem hiding this comment.
Explicar por qué se hace esta distinción entre GET y POST
| biomarker__user=request.user) | ||
| stat_validation = get_object_or_404(StatisticalValidation, pk=pk) | ||
| if not can_view_biomarker(stat_validation.biomarker, request.user): | ||
| raise ValidationError('You do not have permission to access this statistical validation.') |
Member
There was a problem hiding this comment.
Es PermissionDenied en vez de ValidationError. Corregir en los demas casos del archivo
| """ | ||
|
|
||
| def get_queryset(self): | ||
| if self.request.method == 'GET': |
|
|
||
| user_file = get_object_or_404(UserFile, pk=user_file_id) | ||
| if not can_edit_shared_resource(user_file, request.user): | ||
| return Response( |
Member
There was a problem hiding this comment.
Arrojar PermissionDenied Corregir en los demas casos del archivo
|
|
||
| institution = get_object_or_404(Institution, pk=institution_id) | ||
| if not user_file.institutions.filter(pk=institution.pk).exists(): | ||
| return Response( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.