Implement a new component for a better UX of Tags - #105
Merged
Conversation
Genarito
requested changes
Aug 14, 2026
| const [locale, setLocale] = useState<'en' | 'es'>('es') | ||
| const [locale, setLocaleState] = useState<Locale>(() => { | ||
| const storedLocale = localStorage.getItem(LOCALE_STORAGE_KEY) | ||
| return storedLocale === 'en' || storedLocale === 'es' ? storedLocale : 'es' |
Member
There was a problem hiding this comment.
Está bien la lógica pero es poco escalable. Considerar el siguiente código:
const LOCALES = ['en', 'es'] as const
type Locale = typeof LOCALES[number]
const LANG_SET: Set<Locale> = new Set(LOCALES)Lo que hace esto es definir Locale como todos los valores posibles de LOCALES si llegáramos a accederlos con índices numéricos (por eso el typeof LOCALES[number]).
Y después crea un Set para poder consultar rápidamente si un valor está dentro o no (es más rápido que un arreglo, ya que hace la búsqueda en un tipo log N y no en N como el arreglo).
Luego, al momento de setearlo, se puede simplificar a:
return LANG_SET.has(storedLocale) ? storedLocale : 'es'Si el día de mañana agregamos un lenguaje, solo hay que agregarlo al arreglo LOCALES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.