Restrict dataset management to owners - #106
Open
juanNH wants to merge 1 commit into
Open
Conversation
Genarito
requested changes
Aug 20, 2026
| /> | ||
| ) | ||
| : '-'} | ||
| <TableCellWithTitle value={formatDateLocale(userFileRow.upload_date as string, 'L')} /> |
Member
There was a problem hiding this comment.
Si upload_date no es siempre string en vez de hacer un as hacer una condición ternaria. O editar el tipo para que siempre sea string (si no va a fallar)
| size='large' | ||
| title={intl.formatMessage( | ||
| { id: 'files.manager.tooltip.sharedWith' }, | ||
| { list: (this.state.sharedInstitutionsByFile[userFileRow.id as number] ?? userFileRow.institutions).map((i) => i.name).join(', ') } |
Member
There was a problem hiding this comment.
Ya lo ví varias veces en el código. Guardar this.state.sharedInstitutionsByFile[userFileRow.id as number] en una constante
| filter_condition = Q(is_public=True) | ||
| else: | ||
| # Gets UserFiles which belongs to current user | ||
| filter_condition = Q(user=user) |
Member
There was a problem hiding this comment.
Ya que está editando estos archivos, mover esta condición a un if/else:
# Gets UserFiles
if private_only:
filter_condition = Q(user=user)
else:
# Gets public and institutions datasets too
filter_condition = user_file_visibility_q(user)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.