Skip zero shot sessions during cloud upload - #165
Open
Reillybags wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skips CloudLink upload/spooling for OpenFlight session files that contain zero shots.
Why was this required?
OpenFlight creates a local session whenever the server starts. With CloudLink enabled, those empty startup/test sessions can be uploaded to openflight.dev and appear as sessions with
0shots, which clutters the session list and makes real practice sessions harder to find.What changed?
Automated tests
Attempted locally:
uv run pytest tests/test_cloud_commands.py tests/test_cloud_spool.py -vThis was blocked by a local Windows/uv permission issue in the virtual environment/cache, not by a test assertion failure.
Manual testing
Observed on OpenFlight CloudLink that repeated server startups created uploaded sessions with
0shots. This PR prevents those empty sessions from being uploaded while preserving uploads for real sessions containing shots.