fix: resolve Windows test-suite issues, cloud push logging, and dynamic midpoint fallback - #226
Open
dieterolson wants to merge 1 commit into
Open
Conversation
…ic midpoint fallback Windows test-suite fixes: newline preservation in compare_trackman, Windows skips for POSIX permissions and symlinks, deterministic sim transport backoff, clean socket accept termination, and tmp_path basetemp config. Code fixes: cloud-push debug logging, dynamic capture midpoint calculation, and deduplicated angle limit constant.
jewbetcha
approved these changes
Aug 21, 2026
Member
|
Good to go after conflicts resolved |
Open
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Issue #15 (Windows test-suite fixes) and Issue #17 (verified upstream code fixes):
1. Windows Test Suite Fixes (Issue #15)
tests/test_compare_trackman.py: Addednewline=""topath.write_text(...)to prevent Windows CRLF automatic conversion from causing CRCRLF line-ending mismatch.tests/test_cloud_config.py: Skipped POSIX permission bits assertion on Windows where 0600 is not representable.tests/test_serial_latency.py: Skipped udev symlink resolution test on Windows where symlink creation requires elevation.tests/test_sim_transport.py: Replaced sleep-based backoff timing test with deterministic monkeypatched instant refusal socket and polling loop.tests/conftest.py: HandledOSErroronMockSimServer.accept()loop to allow clean and immediate shutdown upon socket closure during teardown without PytestUnhandledThreadExceptionWarning.pyproject.toml&.gitignore: Configuredaddopts = "--basetemp=.pytest_temp"andtmp_path_retention_policy = "none"under[tool.pytest.ini_options]and ignored.pytest_temp/to prevent Windows temp directory locking permission issues.2. Code Fixes (Issue #17)
src/openflight/server.py: Replaced silent exception swallow in_fire_cloud_pushwithlogger.debug("[SERVER] Cloud push trigger failed", exc_info=True).src/openflight/rolling_buffer/processor.py: Dynamically computed the capture midpoint fallback timestamp from(len(capture.i_samples) / self.SAMPLE_RATE) * 500.0instead of a hardcoded 68.0 ms.src/openflight/kld7/radc.py&src/openflight/server.py: Defined and deduplicatedDEFAULT_RADC_HORIZONTAL_ANGLE_LIMIT_DEG = 15.0.src/openflight/kld7/__init__.py&src/openflight/kld7/tracker.py: Moved the K-LD7 deprecation warning from the top-level__init__.pytoKLD7Tracker.__init__so importing sibling modules orsession_loggerdoes not emit deprecation warnings.Verification
1233 passed, 10 skippedcleanly with 0 failures.ruff checkandruff format --checkpass with 0 errors.pylintscores 9.70/10.