feat: add bun and pnpm support, refine npm logic to not be yarn-dependent - #173
Open
michaeljaltamirano wants to merge 11 commits into
Open
feat: add bun and pnpm support, refine npm logic to not be yarn-dependent#173michaeljaltamirano wants to merge 11 commits into
michaeljaltamirano wants to merge 11 commits into
Conversation
michaeljaltamirano
force-pushed
the
feat/support-npm-and-pnpm
branch
from
December 26, 2025 22:26
7a5cd7c to
3834dab
Compare
michaeljaltamirano
changed the title
michaeljaltamirano
force-pushed
the
feat/support-npm-and-pnpm
branch
2 times, most recently
from
December 29, 2025 20:02
0e23f25 to
9f765a0
Compare
tagoro9
approved these changes
Dec 29, 2025
tagoro9
left a comment
tagoro9
left a comment
Member
There was a problem hiding this comment.
Just a question on still falling back to npm
| package-manager: | ||
| description: The package manager used to install dependencies | ||
| value: ${{ steps.check_yarn_lock.outputs.files_exists == 'true' && 'yarn' || 'npm' }} | ||
| value: ${{ steps.check_bun_lock.outputs.files_exists == 'true' && 'bun' || (steps.check_pnpm_lock.outputs.files_exists == 'true' && 'pnpm' || (steps.check_yarn_lock.outputs.files_exists == 'true' && 'yarn') || (steps.check_npm_lock.outputs.files_exists == 'true' && 'npm')) }} |
Member
There was a problem hiding this comment.
Should this still fallback to npm when there is no lockfile for any tool but there is just a package.json file? Right now if there is no package-lock.json this is going to return an empty string
Toolo
approved these changes
Jan 5, 2026
michaeljaltamirano
force-pushed
the
feat/support-npm-and-pnpm
branch
from
January 13, 2026 23:16
83c1453 to
13157df
Compare
Release notes previewBelow is a preview of the release notes if your PR gets merged. 7.7.0 (2026-08-25)Miscellaneous
Features
Bug Fixes
Code Refactoring
|
OmarJaroudi
requested review from
OmarJaroudi
and removed request for
OmarJaroudi
April 14, 2026 21:48
Contributor
|
@michaeljaltamirano shall we ship this? I may have a one-off repo that uses pnpm soon, would be cool to get to use open-turo actions! |
chore(install-dependencies/action.yaml): update Compute lockfile hash to not be yarn-dependent feat: add support for bun, too
OmarJaroudi
force-pushed
the
feat/support-npm-and-pnpm
branch
from
August 25, 2026 17:10
0226a5a to
3b7453f
Compare
pnpm v8+ passes args to the script without needing --. The separator was causing jest to receive -- --coverage --shard=N/M which it interprets as file path patterns instead of flags, resulting in No tests found. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
actions-nodeGHA is relatively brittle, expectingyarnas the package manager for repos that rely on it, though there is fallback logic tonpmif noyarnartifacts are detected. This PR seeks to make the GHA compatible with two other tools:bunandpnpm. (denowas excluded to try not to add too much at once.) This will allow repos that rely on this GHA to use whichever tool best suits the needs for that given repo, without the restriction onyarn(classic) andnpm.