Fixes#3686
Open
benderl wants to merge 2 commits into
Open
Conversation
benderl
commented
Jul 20, 2026
benderl
commented
Contributor
- start simple-api server after installation
- cleanup unused code in data_migration.py
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the installation flow to start the simple API service immediately after install, and removes unused MQTT/broker-related code from the data migration helper module.
Changes:
- Start
openwb-simpleAPIviasystemctlat the end ofopenwb-install.sh. - Remove unused MQTT/broker imports from
data_migration.py. - Remove an unused broker-based helper class (
BrokerCphargepoints) fromdata_migration.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/helpermodules/data_migration/data_migration.py | Removes unused MQTT/broker imports and an unused broker helper class. |
| openwb-install.sh | Starts openwb-simpleAPI after installation completes (service already installed/enabled earlier in the script). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LKuemmel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.