fix: preserve response input message roundtrips - #954
Open
SiluPanda wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #584.
ResponseInputItem.Message.Builderleft its documented constanttypeunset, so serializing a user-built message omitted the union discriminator and deserializing it produced_unknown.EasyInputMessage.Builderhad the same missing default.This change:
type: "message"phasedeserialize to the narrowerResponseInputItem.MessagevariantEasyInputMessagepreference for string content, assistant roles, phase-bearing messages, missing roles, and unknown/future rolesThe tie-break is necessary because a structured
EasyInputMessageandMessagewith auser,system, ordeveloperrole and nophaseare wire-identical. The new test documentsMessageas the canonical branch for that shape rather than leaving the choice implicit.Validation
./gradlew :openai-java-core:test --tests com.openai.models.responses.ResponseInputItemTest --tests com.openai.models.responses.EasyInputMessageTest :openai-java-core:lintKotlin --console=plainResponseInputItemTest: 73 tests, 0 failuresEasyInputMessageTest: 2 tests, 0 failuresmain: 1,735 / 2,000 custom lines, with budget isolation and budget checks both passinggit diff --checkSecurity review note
This touches Jackson polymorphic deserialization. The added dispatch condition only examines the already-parsed
type,role,contentshape, andphasepresence; it adds no I/O, recursion, payload limit, or credential/logging behavior. Exact known input roles are required before changing the existing ordering, so malformed, missing, and future roles retain the currentEasyInputMessage-first path.AI assistance: I used Codex to help investigate the generated union behavior, draft the implementation and tests, and run validation. I reviewed the resulting code, the ambiguity tradeoff, and the test output.