Skip to content

introduce stylistic + update devDependencies - #77

Merged
KristjanESPERANTO merged 3 commits into
opening-hours:mainfrom
KristjanESPERANTO:lint-format
May 22, 2026
Merged

introduce stylistic + update devDependencies#77
KristjanESPERANTO merged 3 commits into
opening-hours:mainfrom
KristjanESPERANTO:lint-format

Conversation

@KristjanESPERANTO

Copy link
Copy Markdown
Member

Add @stylistic/eslint-plugin with single quotes enforcement. Foundation for future style rules - more can be enabled gradually.

The long-term goal would be to follow all the recommended stylistic rules.

@HolgerJeromin

Copy link
Copy Markdown
Contributor

"the world" of javascript is moving away from stylistic eslint rules to https://prettier.io

@KristjanESPERANTO

KristjanESPERANTO commented May 8, 2026

Copy link
Copy Markdown
Member Author

Prettier would cause massive unreviewable changes here, so I took an incremental approach. But I'm flexible - I've already set up a prettier branch to compare the impact if we wanted to switch.

Technically, linter and formatter are different roles, but I think it's good if both are handled by one tool. Some parts of the ecosystem seems to be moving that way (Biome, ESLint's expansion since v9). Happy to go either way.

@KristjanESPERANTO

KristjanESPERANTO commented May 22, 2026

Copy link
Copy Markdown
Member Author

To make some progress here, I'm merging this. I'm still open to other solutions, but for now I've decided to go with "stylistic" because

  1. it doesn't result in a massive amount of code changes in the first step and
  2. aligns with https://github.com/opening-hours/opening_hours.js/.

@KristjanESPERANTO
KristjanESPERANTO merged commit 5a2497e into opening-hours:main May 22, 2026
1 check passed
@KristjanESPERANTO
KristjanESPERANTO deleted the lint-format branch June 14, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants