feat: add GetTenantConfig and UpdateTenantConfig RPCs for tenant configuration - #127
Conversation
…ific configuration Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
cb80
left a comment
cb80
left a comment
There was a problem hiding this comment.
Can you move that into its own proto file please?
proto/kms/api/cmk/registry/tenant_config/v1
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
… changes Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com> Signed-off-by: Paweł Szeląg <pablo.szel@gmail.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com> Signed-off-by: Paweł Szeląg <pablo.szel@gmail.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com> Signed-off-by: Paweł Szeląg <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
| google.protobuf.FieldMask update_mask = 3; | ||
| } | ||
|
|
||
| message UpdateTenantConfigResponse {} |
There was a problem hiding this comment.
Is the response body (from what is in ticket) a deliberate drop (due to async)
There was a problem hiding this comment.
It's a deliberate drop due to async, I suggested to return here the initial request content, but Chris has suggested to just leave it empty.
| message TenantConfigurationValues { | ||
| // Maximum number of systems allowed per key configuration. | ||
| // Default: system default (global limit). | ||
| int32 system_limit = 1 [(buf.validate.field).int32.gte = 1]; |
There was a problem hiding this comment.
might be worth figuring and adding an upper bound?
There was a problem hiding this comment.
IIRC this was mentioned in the refinement, but we left it with no upper bound
4 participants
Implements the api-sdk portion of tenant-specific configuration overrides.
What changed
tenant_config.proto(new) — dedicated proto for tenant config atproto/kms/api/cmk/registry/tenant_config/v1. Contains theGetTenantConfigandUpdateTenantConfigRPCs,TenantConfigurationmessage withoptional int32 system_limitand its own status fields (TenantConfigStatus,error_message,updated_at), andTenantConfigActionenum for the orbital job — following the same pattern asauth.proto. Config status is self-contained — the tenant's ownStatusfield is unaffected during a config update.