feat: tenant configuration - #235
Conversation
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| authUpdateFn = newAuthUpdateFn(authgrpc.AuthStatus_AUTH_STATUS_REMOVING_ERROR) | ||
| case tenantgrpc.ACTION_ACTION_UPDATE_TENANT_CONFIG.String(): | ||
| slogctx.Error(ctx, "tenant config update job aborted", "tenantId", job.ExternalID) | ||
| return nil |
There was a problem hiding this comment.
If aborted we will get inconsistent state between registry and CMK. This is outside scope of PR (so I've ticked) but do you think we should address this?
There was a problem hiding this comment.
Good catch. I extended the comment here and left a comment under relevant CMK task: https://jira.tools.sap/browse/KMS20-7366
petersbingham
left a comment
There was a problem hiding this comment.
Some tests would be nice but otherwise fine.
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
19e303f
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
GetTenantConfigandUpdateTenantConfigRPCs for per-tenant configuration overrides (currentlysystem_limit)JSONBcolumn on the tenant rowapi-sdkto v0.20.0