Skip to content

feat: tenant configuration - #235

Merged
pabloszel11 merged 9 commits into
mainfrom
tenantConfiguration
Sep 14, 2026
Merged

pabloszel11 merged 9 commits into
mainfrom
tenantConfiguration

Conversation

@pabloszel11

Copy link
Copy Markdown
Contributor
  • Adds GetTenantConfig and UpdateTenantConfig RPCs for per-tenant configuration overrides (currently system_limit)
  • Stores overrides as a JSONB column on the tenant row
  • Propagates config changes to downstream CMK workers via a new Orbital job type
  • Bumps api-sdk to v0.20.0

Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ce3a9c4a-86e6-4831-a3f1-58daed3a65b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

authUpdateFn = newAuthUpdateFn(authgrpc.AuthStatus_AUTH_STATUS_REMOVING_ERROR)
case tenantgrpc.ACTION_ACTION_UPDATE_TENANT_CONFIG.String():
slogctx.Error(ctx, "tenant config update job aborted", "tenantId", job.ExternalID)
return nil

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If aborted we will get inconsistent state between registry and CMK. This is outside scope of PR (so I've ticked) but do you think we should address this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I extended the comment here and left a comment under relevant CMK task: https://jira.tools.sap/browse/KMS20-7366

petersbingham
petersbingham previously approved these changes Sep 11, 2026

@petersbingham petersbingham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be nice but otherwise fine.

Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
Signed-off-by: Pawel Szelag <pablo.szel@gmail.com>
@pabloszel11
pabloszel11 merged commit abf5ac8 into main Sep 14, 2026
12 checks passed
@pabloszel11
pabloszel11 deleted the tenantConfiguration branch September 14, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants