Fix coupled external source rate and transfer rate with destination material#3959
Merged
Conversation
…d with external transfer rate
…stination material
paulromano
approved these changes
Jul 24, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! I did a little bit of cleanup but also made two notable changes:
- On the branch where both transfer rates and external rates were being used, the call to
reformat_nuclide_vectorswas done at a point wheren_resultcontained every burnable material (across MPI ranks), butreformat_nuclide_vectorsitself only operates on the local materials. I moved the call further down aftern_resultis distributed back to individual MPI ranks. - The clamping of nuclide vectors was redundant in light of #3879 being merged, so I removed it.
Contributor
|
@church89 Also for future reference, per our developer's guide, PRs should be submitted from a fork (not a branch pushed to the |
paulromano
enabled auto-merge (squash)
July 24, 2026 15:33
Contributor
Author
|
Thanks @paulromano for the fixes/improvements and apologies for the oversight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables using external source rates together with transfer rates that specify a
destination_material. Previously, theIntegratorraised an error if both were set.Now the following steps are performed:
The implementation comes from a previous patch of Valerio Mascolino (https://github.com/vmascolino-anl).
Other
Documented missing external source rates in
methods/depletion.rstandusersguide/depletion.rstChecklist