test: cover STATS output end to end - #201
Open
autoblitzbot wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
info.stats.shend to end with synthetic maker historyalltotals are calculated once per maker event, without adding overlapping periodsFinding
The reported lifetime-total bug is not reproducible on current
master. The implementation already increments lifetime totals directly once per maker row. The new fixture makes this explicit: 100/200/300/400-sat events render day/week/month/all totals of 100/300/600/1000 and counts of 1/2/3/4.The controlled running-maker case also renders
1d:2h:3m. The field report may depend on the live process command/environment; #135 tracks a known Jam-specific uptime case. This PR adds the missing regression harness without speculative production changes.Closes #200.
Tests
bats tests/info.stats.bats— 1/1 passbats -r tests— 62/62 pass