feat(web): expose Pi thinking state - #375
Closed
seekskyworld wants to merge 1 commit into
Closed
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
This was referenced Sep 4, 2026
tt-a1i
approved these changes
Sep 7, 2026
tt-a1i
left a comment
tt-a1i
left a comment
Collaborator
There was a problem hiding this comment.
Exact-head standards/spec review found no confirmed P2 or higher issue. The optional runtime seam delegates thinkingLevel and available thinking levels to the real Pi AgentSession API and exposes read-only inspection without changing configuration, tools or model context. Focused existing runtime/host tests passed 39/39; source inspection verified the locked Pi public methods. These existing tests are not dedicated new endpoint coverage or installed UI acceptance. Current PR CI is green, but main integration conflicts in host/types; recommend keeping this narrow capability after resolving conflicts and validating integration. No merge performed.
tt-a1i
added a commit
that referenced
this pull request
Sep 7, 2026
…444) Integrate Session-scoped terminal details from #389, Pi thinking reads from #375, and unarchive from #361 while preserving current trust diagnostics. Add authenticated endpoint and persistent unarchive integration tests. Co-authored-by: testikun <320479488+testikun@users.noreply.github.com> Co-authored-by: seekskyworld <djh1813553759@gmail.com>
Collaborator
|
Integrated into main through #444 (1919542). The Pi-owned thinking inspection getter and endpoint were retained with host/type conflict resolution and additional authentication/fallback coverage. Original contributor seekskyworld is credited as a co-author. Full local validation and Node 22/24/26, Web E2E and Windows CI passed. Closing this source PR as integrated; thank you for the contribution. |
Matt-qwq
added a commit
to Matt-qwq/openpi
that referenced
this pull request
Sep 10, 2026
Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of openpi-dev#348 and continues the read-only GET /api/thinking inspection from openpi-dev#375/openpi-dev#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort. Research records: docs/research/OPENPI_WEB_THINKING_SELECTOR_PLAN_2026-09-11.md and the linked diagnosis.
Matt-qwq
added a commit
to Matt-qwq/openpi
that referenced
this pull request
Sep 10, 2026
Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of openpi-dev#348 and continues the read-only GET /api/thinking inspection from openpi-dev#375/openpi-dev#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort. Research records: docs/research/OPENPI_WEB_THINKING_SELECTOR_PLAN_2026-09-11.md and the linked diagnosis.
Matt-qwq
added a commit
to Matt-qwq/openpi
that referenced
this pull request
Sep 11, 2026
Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of openpi-dev#348 and continues the read-only GET /api/thinking inspection from openpi-dev#375/openpi-dev#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort. Research records: docs/research/OPENPI_WEB_THINKING_SELECTOR_PLAN_2026-09-11.md and the linked diagnosis.
Matt-qwq
added a commit
to Matt-qwq/openpi
that referenced
this pull request
Sep 11, 2026
Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of openpi-dev#348 and continues the read-only GET /api/thinking inspection from openpi-dev#375/openpi-dev#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort.
Matt-qwq
added a commit
to Matt-qwq/openpi
that referenced
this pull request
Sep 11, 2026
Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of openpi-dev#348 and continues the read-only GET /api/thinking inspection from openpi-dev#375/openpi-dev#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort.
tt-a1i
added a commit
that referenced
this pull request
Sep 12, 2026
) * feat(web): add a Pi-native thinking-level selector to the composer Expose Pi's native thinking/reasoning level in the Web workbench: a runtime setter with a bounded merge-to-latest, a lease-sensitive POST /api/thinking, a bounded optional thinking projection with a monotonic revision on the snapshot, a last-intent-wins client store with a revision gate, and an icon-only composer picker with a disabled placeholder for unsupported models. Levels come from Pi's getAvailableThinkingLevels()/supportsThinking(); OpenPI adds no second reasoning store and no persisted configuration (session-only). Advances the change-thinking-level criterion of #348 and continues the read-only GET /api/thinking inspection from #375/#444, preserving its unknown fallback. Adds browser coverage (22 e2e incl. an axe pass) and a hermetic provider e2e that proves the selected level reaches the next provider request as reasoning_effort. * test(web): make unsupported thinking fixture deterministic --------- Co-authored-by: tt-a1i <53142663+tt-a1i@users.noreply.github.com> Co-authored-by: tt-a1i <tt-a1i@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adds the reasoning-state inspection slice of #348. The Web workbench could not show the active Pi thinking level or model-supported levels.
Value
Users can inspect reasoning configuration from the browser while Pi remains authoritative.
Approach
Expose optional runtime
getThinkingState()backed by Pi AgentSession and an authenticatedGET /api/thinkingendpoint. Existing controllers remain compatible; no credentials or configuration writes are introduced.Validation
npx tsc --noEmitgit diff --checkImpact