feat(web): render tool evidence and preview session artifacts - #496
Open
SSK988I wants to merge 3 commits into
Open
feat(web): render tool evidence and preview session artifacts#496SSK988I wants to merge 3 commits into
SSK988I wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #345. Tool output is difficult to review as generic text, and local artifact links cannot use ordinary Web navigation to reach authenticated files. Includes the controlled artifact access and revision-following slice requested in the maintainer's comments:
Value
Users can inspect file contents, additions/deletions, test observations and terminal receipts, then open/download a generated report and see its next version after modification. Presentation stays tied to observed tool results rather than a success label.
Approach
Validation
Final merged revision:
943d13d(includes main0d17f45). Validation is not fully green:bun run check: passes in a clean LF export of the final commit. The Windows working checkout fails format checking on existing CRLF files; no repository-wide line-ending rewrite was made..spec.tsfiles through the repository's Vitest runner: 10 files / 132 tests passed after the merge.bun run test:web:e2e: 11 passed / 1 failed after the merge. The new artifact scenario passes, using real Pi read/write/edit operations and the real Host with fixture model responses. The failing upstream workspace-selection test computesworkspaceNamewithcanonicalWorkspace.split("/"), leaving a full backslash-separated Windows path and timing out finding the menu item (tests/web/openpi-web.e2e.ts:805-816). It is unchanged by this PR. Before the upstream merge, all 10 browser tests passed.bun run test: latest parallel Node phase 1370 passed / 2 failed / 9 skipped, then the runner stopped before the serial/frontend phases. Failures were the existing setup integration child-process timeout and detached-workflow settlement timeout. Both files passed isolated earlier. An earlier full run also hung after background-terminal manager assertions completed; owned test processes were stopped and remaining tests run separately. No claim of a complete passing full-suite run.git diff --check: passed.Impact
writeimplementation adds bounded result details; its ordinary textual response is preserved.